From patchwork Wed Oct 21 07:24:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Pettit X-Patchwork-Id: 533617 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (unknown [IPv6:2600:3c00::f03c:91ff:fe6e:bdf7]) by ozlabs.org (Postfix) with ESMTP id 14252140787 for ; Wed, 21 Oct 2015 18:25:00 +1100 (AEDT) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 8BF6B105F1; Wed, 21 Oct 2015 00:24:51 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v1.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 5F62A105E2 for ; Wed, 21 Oct 2015 00:24:50 -0700 (PDT) Received: from bar3.cudamail.com (bar1 [192.168.15.1]) by mx3v1.cudamail.com (Postfix) with ESMTP id C387C618ADE for ; Wed, 21 Oct 2015 01:24:49 -0600 (MDT) X-ASG-Debug-ID: 1445412289-03dd7b105e15fcf0001-byXFYA Received: from mx3-pf3.cudamail.com ([192.168.14.3]) by bar3.cudamail.com with ESMTP id eSTF1u5KhuyJRzko (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 21 Oct 2015 01:24:49 -0600 (MDT) X-Barracuda-Envelope-From: jpettit@nicira.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.3 Received: from unknown (HELO mail-pa0-f47.google.com) (209.85.220.47) by mx3-pf3.cudamail.com with ESMTPS (RC4-SHA encrypted); 21 Oct 2015 07:24:49 -0000 Received-SPF: unknown (mx3-pf3.cudamail.com: Multiple SPF records returned) X-Barracuda-RBL-Trusted-Forwarder: 209.85.220.47 Received: by padhk11 with SMTP id hk11so46843693pad.1 for ; Wed, 21 Oct 2015 00:24:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=QB5MGiaRCpRNbHZmAErgpVGxqsQm6PCad0DGscGfhbo=; b=HU7duVW6uVuHV2++gJ6RD5A1OsILq8wwdmWYIjd5mA3k9/VoMC7XMOSQwds3WmOiGP NT+FqguVDKx+nOwoLVKRKQTle04PQtcx/ShwGABkfqQqh+HAndB2mrd90o0WYI5ic6cC n8gpai0f0vXHiPedP5KHtE/YANVzfLxze06c+PFU0gJYH1qAuefxWMyawmYLWO9iRAq2 0cKO1Ld1KdK6lETST24ZI5/MElFKnPPBhcY5LhWjFszTy48SufIXffdhasD4yZiPGgkl z6YU8IbGdpyJ/rAtsMz8F5nIp0iubuhwnTrkF90v2st3ijmlEJ5cMYBAq+12NixIL/Lx 8DRA== X-Gm-Message-State: ALoCoQm99DpW89nSFxoD+f0LwU9bcZELjbk5ysfoeuYyKprWE96l2zcDBEoAbdyFBMK1+lLh6nqE X-Received: by 10.68.57.175 with SMTP id j15mr8989441pbq.34.1445412288661; Wed, 21 Oct 2015 00:24:48 -0700 (PDT) Received: from localhost.localdomain (c-67-161-8-206.hsd1.ca.comcast.net. [67.161.8.206]) by smtp.gmail.com with ESMTPSA id x6sm7469097pbt.3.2015.10.21.00.24.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Oct 2015 00:24:48 -0700 (PDT) X-CudaMail-Envelope-Sender: jpettit@nicira.com X-Barracuda-Apparent-Source-IP: 67.161.8.206 From: Justin Pettit To: dev@openvswitch.org X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-V3-1020001290 X-CudaMail-DTE: 102115 X-CudaMail-Originating-IP: 209.85.220.47 Date: Wed, 21 Oct 2015 00:24:24 -0700 X-ASG-Orig-Subj: [##CM-V3-1020001290##][PATCH 03/10] ovn-northd: Fix memory leak in ARP reply flows. Message-Id: <1445412271-22019-3-git-send-email-jpettit@nicira.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1445412271-22019-1-git-send-email-jpettit@nicira.com> References: <1445412271-22019-1-git-send-email-jpettit@nicira.com> X-Barracuda-Connect: UNKNOWN[192.168.14.3] X-Barracuda-Start-Time: 1445412289 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Subject: [ovs-dev] [PATCH 03/10] ovn-northd: Fix memory leak in ARP reply flows. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" Signed-off-by: Justin Pettit Acked-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index e199937..2ebd3f4 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -1405,6 +1405,8 @@ build_lrouter_flows(struct hmap *datapaths, struct hmap *ports, op->json_key); ovn_lflow_add(lflows, op->od, S_ROUTER_IN_IP_INPUT, 90, match, actions); + free(match); + free(actions); /* Drop IP traffic to this router. */ match = xasprintf("ip4.dst == "IP_FMT, IP_ARGS(op->ip));