[ovs-dev,RFC,2/3] tests: Enable debugging in pyftpdlib.
diff mbox

Message ID 1445379840-113042-2-git-send-email-jrajahalme@nicira.com
State Accepted
Headers show

Commit Message

Jarno Rajahalme Oct. 20, 2015, 10:23 p.m. UTC
Helps diagnosing problems.

Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
---
 tests/test-l7.py | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Joe Stringer Oct. 23, 2015, 11:20 p.m. UTC | #1
On 20 October 2015 at 15:23, Jarno Rajahalme <jrajahalme@nicira.com> wrote:
> Helps diagnosing problems.
>
> Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>

I assume we don't check the output of this anywhere, so we don't need
to amend the testsuite to keep things passing.

Acked-by: Joe Stringer <joestringer@nicira.com>
Jarno Rajahalme Oct. 23, 2015, 11:38 p.m. UTC | #2
> On Oct 23, 2015, at 4:20 PM, Joe Stringer <joestringer@nicira.com> wrote:
> 
> On 20 October 2015 at 15:23, Jarno Rajahalme <jrajahalme@nicira.com> wrote:
>> Helps diagnosing problems.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
> 
> I assume we don't check the output of this anywhere, so we don't need
> to amend the testsuite to keep things passing.

Right. And when there are errors, the more detailed output is visible in the log.

> 
> Acked-by: Joe Stringer <joestringer@nicira.com>

Pushed to master,

  Jarno

Patch
diff mbox

diff --git a/tests/test-l7.py b/tests/test-l7.py
index 65c6c2a..faec2bc 100755
--- a/tests/test-l7.py
+++ b/tests/test-l7.py
@@ -30,6 +30,10 @@  def get_ftpd():
         from pyftpdlib.handlers import FTPHandler
         from pyftpdlib.servers import FTPServer
 
+        import logging
+        import pyftpdlib.log
+        pyftpdlib.log.LEVEL = logging.DEBUG
+
         class OVSFTPHandler(FTPHandler):
             authorizer = DummyAuthorizer()
             authorizer.add_anonymous("/tmp")