[ovs-dev,RFC,1/3] odp-util: Fix CT action formating.
diff mbox

Message ID 1445379840-113042-1-git-send-email-jrajahalme@nicira.com
State Accepted
Headers show

Commit Message

Jarno Rajahalme Oct. 20, 2015, 10:23 p.m. UTC
Comma was missing after "label" attribute.

Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
---
 lib/odp-util.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jarno Rajahalme Oct. 20, 2015, 10:27 p.m. UTC | #1
This 3-part RFC patch series applies to OVS master repo, the 5-part RFC series applies to net-next.

  Jarno

> On Oct 20, 2015, at 3:23 PM, Jarno Rajahalme <jrajahalme@nicira.com> wrote:
> 
> Comma was missing after "label" attribute.
> 
> Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
> ---
> lib/odp-util.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index e131e36..8f0f39a 100644
> --- a/lib/odp-util.c
> +++ b/lib/odp-util.c
> @@ -590,6 +590,7 @@ format_odp_conntrack_action(struct ds *ds, const struct nlattr *attr)
>         if (label) {
>             ds_put_format(ds, "label=");
>             format_u128(ds, label, label + 1, true);
> +            ds_put_char(ds, ',');
>         }
>         if (helper) {
>             ds_put_format(ds, "helper=%s,", helper);
> -- 
> 2.1.4
>
Joe Stringer Oct. 23, 2015, 11:20 p.m. UTC | #2
On 20 October 2015 at 15:23, Jarno Rajahalme <jrajahalme@nicira.com> wrote:
> Comma was missing after "label" attribute.
>
> Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>

Acked-by: Joe Stringer <joestringer@nicira.com>
Jarno Rajahalme Oct. 23, 2015, 11:37 p.m. UTC | #3
> On Oct 23, 2015, at 4:20 PM, Joe Stringer <joestringer@nicira.com> wrote:
> 
> On 20 October 2015 at 15:23, Jarno Rajahalme <jrajahalme@nicira.com> wrote:
>> Comma was missing after "label" attribute.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
> 
> Acked-by: Joe Stringer <joestringer@nicira.com>

Thanks for the review, pushed to master.

  Jarno

Patch
diff mbox

diff --git a/lib/odp-util.c b/lib/odp-util.c
index e131e36..8f0f39a 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -590,6 +590,7 @@  format_odp_conntrack_action(struct ds *ds, const struct nlattr *attr)
         if (label) {
             ds_put_format(ds, "label=");
             format_u128(ds, label, label + 1, true);
+            ds_put_char(ds, ',');
         }
         if (helper) {
             ds_put_format(ds, "helper=%s,", helper);