[ovs-dev,19/21] ofproto.at: Workaround a race
diff mbox

Message ID 1445228952-22445-19-git-send-email-yamamoto@midokura.com
State Awaiting Upstream
Headers show

Commit Message

Takashi Yamamoto Oct. 19, 2015, 4:29 a.m. UTC
While a barrier serializes requests from the same connection,
it doesn't wait for requests from other connections to the switch.
Replace the barrier with infamous "sleep 1" to workaround the problem.

Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com>
---
 tests/ofproto.at | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Ben Pfaff Nov. 10, 2015, 4:31 a.m. UTC | #1
On Mon, Oct 19, 2015 at 01:29:10PM +0900, YAMAMOTO Takashi wrote:
> While a barrier serializes requests from the same connection,
> it doesn't wait for requests from other connections to the switch.
> Replace the barrier with infamous "sleep 1" to workaround the problem.
> 
> Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com>

Acked-by: Ben Pfaff <blp@ovn.org>

Patch
diff mbox

diff --git a/tests/ofproto.at b/tests/ofproto.at
index e1cb430..c947582 100644
--- a/tests/ofproto.at
+++ b/tests/ofproto.at
@@ -2430,8 +2430,7 @@  udp,vlan_tci=0x0000,dl_src=00:26:b9:8c:b0:f9,dl_dst=00:25:83:df:b4:00,nw_src=172
     fi
     AT_FAIL_IF([test X"$1" != X])
 
-    ovs-appctl -t ovs-ofctl ofctl/barrier
-    echo >>expout "OFPT_BARRIER_REPLY (OF1.2):"
+    sleep 1
 
     AT_CHECK(
       [[sed '