[ovs-dev,05/21] openvswitch.m4: Portability improvement
diff mbox

Message ID 1445228952-22445-5-git-send-email-yamamoto@midokura.com
State Awaiting Upstream
Headers show

Commit Message

Takashi Yamamoto Oct. 19, 2015, 4:28 a.m. UTC
${parameter/pattern/string} substituion is not portable.
Replace them with $SED equivalent.

Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com>
---
 m4/openvswitch.m4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ben Pfaff Nov. 9, 2015, 11:24 p.m. UTC | #1
On Mon, Oct 19, 2015 at 01:28:56PM +0900, YAMAMOTO Takashi wrote:
> ${parameter/pattern/string} substituion is not portable.
> Replace them with $SED equivalent.
> 
> Signed-off-by: YAMAMOTO Takashi <yamamoto@midokura.com>

I'm surprised that it matters given that this should only be run on
Win32.  I guess that the shell still parses the substitution.

Acked-by: Ben Pfaff <blp@ovn.org>

Patch
diff mbox

diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4
index d355811..683a6a7 100644
--- a/m4/openvswitch.m4
+++ b/m4/openvswitch.m4
@@ -109,11 +109,11 @@  AC_DEFUN([OVS_CHECK_WIN32],
             fi
             if test "$cl_cv_x64" = yes; then
                 PTHREAD_WIN32_DIR=$withval/lib/x64
-                PTHREAD_WIN32_DIR_DLL=/${withval/:/}/dll/x64
+                PTHREAD_WIN32_DIR_DLL=/$(echo ${withval} | ${SED} -e '/://')/dll/x64
                 PTHREAD_WIN32_DIR_DLL_WIN_FORM=$withval/dll/x64
             else
                 PTHREAD_WIN32_DIR=$withval/lib/x86
-                PTHREAD_WIN32_DIR_DLL=/${withval/:/}/dll/x86
+                PTHREAD_WIN32_DIR_DLL=/$(echo ${withval} | ${SED} -e '/://')/dll/x64
                 PTHREAD_WIN32_DIR_DLL_WIN_FORM=$withval/dll/x86
             fi
             PTHREAD_INCLUDES=-I$withval/include