diff mbox

[ovs-dev,3/3] expr: Document error handling for expr_annotate().

Message ID 1444779541-80516-3-git-send-email-jpettit@nicira.com
State Accepted
Headers show

Commit Message

Justin Pettit Oct. 13, 2015, 11:39 p.m. UTC 
Signed-off-by: Justin Pettit <jpettit@nicira.com>
---
 ovn/lib/expr.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

Comments

Ben Pfaff Oct. 14, 2015, 12:31 a.m. UTC | #1 
On Tue, Oct 13, 2015 at 04:39:01PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit <jpettit@nicira.com>

Acked-by: Ben Pfaff <blp@nicira.com>
diff mbox

Patch

diff --git a/ovn/lib/expr.c b/ovn/lib/expr.c
index 8270b82..8ec62b5 100644
--- a/ovn/lib/expr.c
+++ b/ovn/lib/expr.c
@@ -1480,7 +1480,10 @@  expr_annotate__(struct expr *expr, const struct shash *symtab,
  *     - Expands references to predicate symbols, by replacing them by the
  *       expressions that they expand to.
  *
- * In each case, annotation occurs recursively as necessary. */
+ * In each case, annotation occurs recursively as necessary.
+ *
+ * On failure, returns NULL and sets '*errorp' to an explanatory error
+ * message, which the caller must free. */
 struct expr *
 expr_annotate(struct expr *expr, const struct shash *symtab, char **errorp)
 {