[ovs-dev,20/23] ovn-nb: Add "enabled" column to Logical_Router_Port.
diff mbox

Message ID 1444450902-12236-1-git-send-email-blp@nicira.com
State Accepted
Headers show

Commit Message

Ben Pfaff Oct. 10, 2015, 4:21 a.m. UTC
Signed-off-by: Ben Pfaff <blp@nicira.com>
---
 ovn/ovn-nb.ovsschema | 3 ++-
 ovn/ovn-nb.xml       | 7 +++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

Comments

Justin Pettit Oct. 16, 2015, 1:27 a.m. UTC | #1
> On Oct 9, 2015, at 9:21 PM, Ben Pfaff <blp@nicira.com> wrote:
> 
> Signed-off-by: Ben Pfaff <blp@nicira.com>

Acked-by: Justin Pettit <jpettit@nicira.com>

--Justin
Ben Pfaff Oct. 16, 2015, 8:52 p.m. UTC | #2
On Thu, Oct 15, 2015 at 06:27:49PM -0700, Justin Pettit wrote:
> 
> > On Oct 9, 2015, at 9:21 PM, Ben Pfaff <blp@nicira.com> wrote:
> > 
> > Signed-off-by: Ben Pfaff <blp@nicira.com>
> 
> Acked-by: Justin Pettit <jpettit@nicira.com>

Thanks.  Again, I've updated the commit message:

    ovn-nb: Add "enabled" column to Logical_Router_Port.

    This is just for symmetry with Logical_Port, since it seems that if users
    want to be able to disable switch ports they might want to disable router
    ports as well.

    There is no "up" column because a logical router port doesn't have the same
    concept.

    Signed-off-by: Ben Pfaff <blp@nicira.com>
    Acked-by: Justin Pettit <jpettit@nicira.com>

Patch
diff mbox

diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema
index 9d254e8..d45a682 100644
--- a/ovn/ovn-nb.ovsschema
+++ b/ovn/ovn-nb.ovsschema
@@ -1,7 +1,7 @@ 
 {
     "name": "OVN_Northbound",
     "version": "2.0.0",
-    "cksum": "1378979036 4524",
+    "cksum": "4186002454 4601",
     "tables": {
         "Logical_Switch": {
             "columns": {
@@ -85,6 +85,7 @@ 
                                           "refTable": "Logical_Router_Port",
                                           "refType": "strong"},
                                   "min": 0, "max": 1}},
+                "enabled": {"type": {"key": "boolean", "min": 0, "max": 1}},
                 "external_ids": {
                     "type": {"key": "string", "value": "string",
                              "min": 0, "max": "unlimited"}}},
diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml
index 89c3e7d..681f6c7 100644
--- a/ovn/ovn-nb.xml
+++ b/ovn/ovn-nb.xml
@@ -485,6 +485,13 @@ 
       The Ethernet address that belongs to this router port.
     </column>
 
+    <column name="enabled">
+      This column is used to administratively set port state.  If this column
+      is empty or is set to <code>true</code>, the port is enabled.  If this
+      column is set to <code>false</code>, the port is disabled.  A disabled
+      port has all ingress and egress traffic dropped.
+    </column>
+
     <group title="Attachment">
       <p>
         A given router port serves one of two purposes: