| Message ID | 1443729854-18301-1-git-send-email-rbryant@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, Oct 1, 2015 at 1:04 PM, Russell Bryant <rbryant@redhat.com> wrote: > Commit e91b927d8966bfcb9768225392324dde4fd7d7f6 added optional usage of > the libcap-ng library. It's packaged in Fedora, so go ahead and added > it to the Fedora spec file. > > Our default systemd unit files don't make use of the --user option that > requires this library, but conceivably someone may want to customize > them and use this option. > > Signed-off-by: Russell Bryant <rbryant@redhat.com> Should we apply similar changes to openvswitch.spec?
On Thu, Oct 01, 2015 at 03:35:05PM -0700, Andy Zhou wrote: > On Thu, Oct 1, 2015 at 1:04 PM, Russell Bryant <rbryant@redhat.com> wrote: > > Commit e91b927d8966bfcb9768225392324dde4fd7d7f6 added optional usage of > > the libcap-ng library. It's packaged in Fedora, so go ahead and added > > it to the Fedora spec file. > > > > Our default systemd unit files don't make use of the --user option that > > requires this library, but conceivably someone may want to customize > > them and use this option. > > > > Signed-off-by: Russell Bryant <rbryant@redhat.com> > Should we apply similar changes to openvswitch.spec? I would say so. The catch is when you need to specify the user to the initialization because one is systemd and the other is sysv. fbl
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 695f1d7..cda92dc 100644 --- a/rhel/openvswitch-fedora.spec.in +++ b/rhel/openvswitch-fedora.spec.in @@ -37,13 +37,14 @@ Source: http://openvswitch.org/releases/%{name}-%{version}.tar.gz BuildRequires: autoconf automake libtool BuildRequires: systemd-units openssl openssl-devel +BuildRequires: libcap-ng libcap-ng-devel BuildRequires: python python-twisted-core python-zope-interface PyQt4 BuildRequires: desktop-file-utils BuildRequires: groff graphviz # make check dependencies BuildRequires: procps-ng -Requires: openssl iproute module-init-tools +Requires: openssl iproute module-init-tools libcap-ng #Upstream kernel commit 4f647e0a3c37b8d5086214128614a136064110c3 #Requires: kernel >= 3.15.0-0 @@ -104,7 +105,8 @@ overlays and security groups. %setup -q %build -%configure --enable-ssl --with-pkidir=%{_sharedstatedir}/openvswitch/pki +%configure --enable-ssl --enable-libcapng \ + --with-pkidir=%{_sharedstatedir}/openvswitch/pki make %{?_smp_mflags} %install
Commit e91b927d8966bfcb9768225392324dde4fd7d7f6 added optional usage of the libcap-ng library. It's packaged in Fedora, so go ahead and added it to the Fedora spec file. Our default systemd unit files don't make use of the --user option that requires this library, but conceivably someone may want to customize them and use this option. Signed-off-by: Russell Bryant <rbryant@redhat.com> --- rhel/openvswitch-fedora.spec.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)