[ovs-dev] Correct Netronome Vendor Id
diff mbox

Message ID 1443581578-19213-1-git-send-email-simon.horman@netronome.com
State Changes Requested
Headers show

Commit Message

Simon Horman Sept. 30, 2015, 2:52 a.m. UTC
Due to an error on my part the Netronome vendor Id is incorrect:
the last digit should be 'D' rather than '0' as per the
Netronome IEEE OUI.

Signed-off-by: Simon Horman <simon.horman@netronome.com>

---

* Compile tested only

* This problem is also present in branch-2.4

* Regarding backwards compatibility.

  My understanding is that the Netronome Vendor Id is only used by the
  NTR (Netronome) selection method extension and that feature is not widely
  used.  Thus I have skipped on making this change backwards compatible.

  If backwards compatibility is desired I believe it can
  be achieved by having parse_ofp15_group_prop_exp() accept
  both the correct new and incorrect old value.
---
 Documentation/group-selection-method-property.txt | 2 +-
 include/openflow/openflow-common.h                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Ben Pfaff Sept. 30, 2015, 5:57 a.m. UTC | #1
On Wed, Sep 30, 2015 at 11:52:58AM +0900, Simon Horman wrote:
> Due to an error on my part the Netronome vendor Id is incorrect:
> the last digit should be 'D' rather than '0' as per the
> Netronome IEEE OUI.

Huh.  I guess the difference between Nortel and Netronome is 13.

> Signed-off-by: Simon Horman <simon.horman@netronome.com>
> 
> ---
> 
> * Compile tested only
> 
> * This problem is also present in branch-2.4
> 
> * Regarding backwards compatibility.
> 
>   My understanding is that the Netronome Vendor Id is only used by the
>   NTR (Netronome) selection method extension and that feature is not widely
>   used.  Thus I have skipped on making this change backwards compatible.
> 
>   If backwards compatibility is desired I believe it can
>   be achieved by having parse_ofp15_group_prop_exp() accept
>   both the correct new and incorrect old value.

It looks really easy to add that, would you mind taking care of it?
Simon Horman Sept. 30, 2015, 6:36 a.m. UTC | #2
On Tue, Sep 29, 2015 at 10:57:50PM -0700, Ben Pfaff wrote:
> On Wed, Sep 30, 2015 at 11:52:58AM +0900, Simon Horman wrote:
> > Due to an error on my part the Netronome vendor Id is incorrect:
> > the last digit should be 'D' rather than '0' as per the
> > Netronome IEEE OUI.
> 
> Huh.  I guess the difference between Nortel and Netronome is 13.

Yes, it seems so.

> > Signed-off-by: Simon Horman <simon.horman@netronome.com>
> > 
> > ---
> > 
> > * Compile tested only
> > 
> > * This problem is also present in branch-2.4
> > 
> > * Regarding backwards compatibility.
> > 
> >   My understanding is that the Netronome Vendor Id is only used by the
> >   NTR (Netronome) selection method extension and that feature is not widely
> >   used.  Thus I have skipped on making this change backwards compatible.
> > 
> >   If backwards compatibility is desired I believe it can
> >   be achieved by having parse_ofp15_group_prop_exp() accept
> >   both the correct new and incorrect old value.
> 
> It looks really easy to add that, would you mind taking care of it?

Sure, will do.

Patch
diff mbox

diff --git a/Documentation/group-selection-method-property.txt b/Documentation/group-selection-method-property.txt
index 36337c6b5aea..f9ebe4aa021f 100644
--- a/Documentation/group-selection-method-property.txt
+++ b/Documentation/group-selection-method-property.txt
@@ -47,7 +47,7 @@  allows controllers to:
 
 The Experimenter ID of this extension is:
 
-NTR_VENDOR_ID = 0x00001540
+NTR_VENDOR_ID = 0x0000154D
 
 
 4. Group Experimenter Property
diff --git a/include/openflow/openflow-common.h b/include/openflow/openflow-common.h
index c0d22820acdb..0731e24ba368 100644
--- a/include/openflow/openflow-common.h
+++ b/include/openflow/openflow-common.h
@@ -103,7 +103,7 @@  enum ofp_version {
  */
 #define OF_VENDOR_ID    0
 #define HPL_VENDOR_ID   0x000004EA /* HP Labs. */
-#define NTR_VENDOR_ID   0x00001540 /* Netronome. */
+#define NTR_VENDOR_ID   0x0000154D /* Netronome. */
 #define NX_VENDOR_ID    0x00002320 /* Nicira. */
 #define ONF_VENDOR_ID   0x4f4e4600 /* Open Networking Foundation. */