[ovs-dev,4/7] Include headers when using ovs_rundir
diff mbox

Message ID 1442951618-13080-5-git-send-email-aserdean@cloudbasesolutions.com
State Accepted
Headers show

Commit Message

Alin Serdean Sept. 22, 2015, 7:53 p.m. UTC
This patch adds an additional include file while compiling under MSVC.

Found by compiling under MSVC x64 and hitting the following problem:
http://stackoverflow.com/questions/23144151/64-bit-function-returns-32-bit-pointer

Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
---
 lib/stream-tcp.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Gurucharan Shetty Sept. 23, 2015, 3:02 p.m. UTC | #1
On Tue, Sep 22, 2015 at 12:53 PM, Alin Serdean
<aserdean@cloudbasesolutions.com> wrote:
> This patch adds an additional include file while compiling under MSVC.
>
> Found by compiling under MSVC x64 and hitting the following problem:
> http://stackoverflow.com/questions/23144151/64-bit-function-returns-32-bit-pointer
>
> Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Applied.
> ---
>  lib/stream-tcp.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lib/stream-tcp.c b/lib/stream-tcp.c
> index ac42924..fc5a606 100644
> --- a/lib/stream-tcp.c
> +++ b/lib/stream-tcp.c
> @@ -76,6 +76,8 @@ const struct stream_class tcp_stream_class = {
>  };
>
>  #ifdef _WIN32
> +#include "dirs.h"
> +
>  static int
>  windows_open(const char *name, char *suffix, struct stream **streamp,
>               uint8_t dscp)
> --
> 1.9.5.msysgit.0
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
Ben Pfaff Sept. 29, 2015, 4:33 a.m. UTC | #2
On Tue, Sep 22, 2015 at 07:53:31PM +0000, Alin Serdean wrote:
> This patch adds an additional include file while compiling under MSVC.
> 
> Found by compiling under MSVC x64 and hitting the following problem:
> http://stackoverflow.com/questions/23144151/64-bit-function-returns-32-bit-pointer
> 
> Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>

The referenced URL implies that the bug is that there's some function
that lacks a prototype without including dirs.h.  Doesn't that break the
build with an error?  If not, can we make it do that?

Patch
diff mbox

diff --git a/lib/stream-tcp.c b/lib/stream-tcp.c
index ac42924..fc5a606 100644
--- a/lib/stream-tcp.c
+++ b/lib/stream-tcp.c
@@ -76,6 +76,8 @@  const struct stream_class tcp_stream_class = {
 };
 
 #ifdef _WIN32
+#include "dirs.h"
+
 static int
 windows_open(const char *name, char *suffix, struct stream **streamp,
              uint8_t dscp)