| Message ID | 1442842450-29769-9-git-send-email-a.hajda@samsung.com |
|---|---|
| State | Not Applicable |
| Headers | show |
On Mon, Sep 21, 2015 at 6:33 AM, Andrzej Hajda <a.hajda@samsung.com> wrote: > The function can return negative value. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > net/openvswitch/conntrack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c > index 002a755..fde3391 100644 > --- a/net/openvswitch/conntrack.c > +++ b/net/openvswitch/conntrack.c > @@ -253,7 +253,7 @@ static int ovs_ct_helper(struct sk_buff *skb, u16 proto) > const struct nf_conntrack_helper *helper; > const struct nf_conn_help *help; > enum ip_conntrack_info ctinfo; > - unsigned int protoff; > + int protoff; > struct nf_conn *ct; > A patch is already pushed to the net tree to fix this issue.
diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c index 002a755..fde3391 100644 --- a/net/openvswitch/conntrack.c +++ b/net/openvswitch/conntrack.c @@ -253,7 +253,7 @@ static int ovs_ct_helper(struct sk_buff *skb, u16 proto) const struct nf_conntrack_helper *helper; const struct nf_conn_help *help; enum ip_conntrack_info ctinfo; - unsigned int protoff; + int protoff; struct nf_conn *ct; ct = nf_ct_get(skb, &ctinfo);
The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- net/openvswitch/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)