From patchwork Wed Sep 16 16:15:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gurucharan Shetty X-Patchwork-Id: 518483 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (li376-54.members.linode.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id ADA3014016A for ; Thu, 17 Sep 2015 02:17:30 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 4CBA210B5A; Wed, 16 Sep 2015 09:17:29 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v1.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 55CC9108F5 for ; Wed, 16 Sep 2015 09:17:28 -0700 (PDT) Received: from bar3.cudamail.com (bar1 [192.168.15.1]) by mx3v1.cudamail.com (Postfix) with ESMTP id 7700861837F for ; Wed, 16 Sep 2015 10:17:26 -0600 (MDT) X-ASG-Debug-ID: 1442420245-03dd7b668a02890001-byXFYA Received: from mx3-pf2.cudamail.com ([192.168.14.1]) by bar3.cudamail.com with ESMTP id tAUS0t7iEyqadUMk (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 16 Sep 2015 10:17:25 -0600 (MDT) X-Barracuda-Envelope-From: shettyg@nicira.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.1 Received: from unknown (HELO mail-io0-f179.google.com) (209.85.223.179) by mx3-pf2.cudamail.com with ESMTPS (RC4-SHA encrypted); 16 Sep 2015 16:15:24 -0000 Received-SPF: unknown (mx3-pf2.cudamail.com: Multiple SPF records returned) X-Barracuda-RBL-Trusted-Forwarder: 209.85.223.179 Received: by ioii196 with SMTP id i196so235506441ioi.3 for ; Wed, 16 Sep 2015 09:15:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=dU1Ht7tOxanhHb+bjAlQT0jJle77CXt8QpUa3sCy70A=; b=L7bBNgVo2GgIJK34HPu934A/mWz85iWjAShwNYEFN0alf43m48x3pvLZvfQ+9PRkmn TsWzDO3lGrjML/FpWhPni1HBbu8ELKOp7UYiG6+FTfbLX9s5npxxPyzEcGYbtBSGphUO TCFklW33jvA/XiX9yQK8h7odu8X1Cpp0812yKWs+d++ayLZTMZnngDTf0cFptubmfgSQ 9Mz+ohwUH0w/H3S+ooece9IujGbhrn5jdhD4h2bpdxddUtfEdREy9HHmvknGaMukeop1 dhdHpMKNjuQ7/k+DHUXh/lLXcecXI+0+oPSSFwv43hBgXoPHORlQiCDLKf1icPVzOWOT Gtiw== X-Gm-Message-State: ALoCoQmHzhE5EXy+EYOI8x+U52Js9OjVL4Ql1yotOagSPbxgLr3oNqY8D1SGxZywzJAqf4JBFHdT MIME-Version: 1.0 X-Received: by 10.107.169.216 with SMTP id f85mr44214598ioj.73.1442420123796; Wed, 16 Sep 2015 09:15:23 -0700 (PDT) Received: by 10.64.227.195 with HTTP; Wed, 16 Sep 2015 09:15:23 -0700 (PDT) In-Reply-To: References: Date: Wed, 16 Sep 2015 09:15:23 -0700 Message-ID: X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-V2-915033728 X-CudaMail-DTE: 091615 X-CudaMail-Originating-IP: 209.85.223.179 X-CudaMail-Envelope-Sender: shettyg@nicira.com X-ASG-Orig-Subj: [##CM-V2-915033728##]Re: [ovs-dev] [PATCH 1/3] rhel: fix 'cannot remove' build error From: Gurucharan Shetty To: Tashi Lu X-Barracuda-Connect: UNKNOWN[192.168.14.1] X-Barracuda-Start-Time: 1442420245 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Cc: dev Subject: Re: [ovs-dev] [PATCH 1/3] rhel: fix 'cannot remove' build error X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" On Tue, Sep 15, 2015 at 7:05 PM, Tashi Lu wrote: > Still the same error shown below. And i do have python2.7 installed and it > is the default $(python) > > % rpmbuild -bb --without check rhel/openvswitch.spec > . > . > . > Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.cqv4YQ > + umask 022 > + cd /root/rpmbuild/BUILD > + cd openvswitch-2.4.90 > + unset DISPLAY > + exit 0 > Processing files: openvswitch-2.4.90-1.x86_64 > error: File not found: > /root/rpmbuild/BUILDROOT/openvswitch-2.4.90-1.x86_64/usr/share/man/man1/ovs-sim.1.gz > Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.bpweQA > + umask 022 > + cd /root/rpmbuild/BUILD > + cd openvswitch-2.4.90 > + > DOCDIR=/root/rpmbuild/BUILDROOT/openvswitch-2.4.90-1.x86_64/usr/share/doc/openvswitch-2.4.90 > + export DOCDIR > + rm -rf > /root/rpmbuild/BUILDROOT/openvswitch-2.4.90-1.x86_64/usr/share/doc/openvswitch-2.4.90 > + /bin/mkdir -p > /root/rpmbuild/BUILDROOT/openvswitch-2.4.90-1.x86_64/usr/share/doc/openvswitch-2.4.90 > + cp -pr COPYING DESIGN.md INSTALL.SSL.md NOTICE README.md WHY-OVS.md FAQ.md > NEWS > /root/rpmbuild/BUILDROOT/openvswitch-2.4.90-1.x86_64/usr/share/doc/openvswitch-2.4.90 > + cp -pr INSTALL.DPDK.md rhel/README.RHEL README-native-tunneling.md > /root/rpmbuild/BUILDROOT/openvswitch-2.4.90-1.x86_64/usr/share/doc/openvswitch-2.4.90 > + exit 0 > > > RPM build errors: > File not found: > /root/rpmbuild/BUILDROOT/openvswitch-2.4.90-1.x86_64/usr/share/man/man1/ovs-sim.1.gz The above error is different than the one you saw in your first mail. So installing python 2.7 got rid of those errors and you ended up with the above. I only tested on the commit that changed python requirements and that worked and I happily made an assumption that no other commit breaks later. Sorry about that. The above error needs the following patch. > > > % python -V > Python 2.7.10 > > > On 16 September 2015 at 05:03, Gurucharan Shetty wrote: >> >> So it turns out that OVS master/OVS 2.4 depend on Python 2.7. Since >> Centos 6 comes with python 2.6.6, you have all the above problems. If >> you upgrade CentOS's python version, you will be able to build the >> RPMs. >> >> So on that respect, can you add the following patch to ovs sources and >> check whether you get the correct error? >> >> diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in >> index dad3e04..642986b 100644 >> --- a/rhel/openvswitch.spec.in >> +++ b/rhel/openvswitch.spec.in >> @@ -22,7 +22,7 @@ License: ASL 2.0 >> Release: 1 >> Source: openvswitch-%{version}.tar.gz >> Buildroot: /tmp/openvswitch-rpm >> -Requires: logrotate, python >> +Requires: logrotate, python >= 2.7 >> BuildRequires: openssl-devel >> >> %bcond_without check >> >> On Tue, Sep 15, 2015 at 1:05 PM, Gurucharan Shetty >> wrote: >> > Never mind. I see the errors on Centos 6.5 and openvswitch master >> > branch. Let me look at your patches. >> > >> > On Tue, Sep 15, 2015 at 12:43 PM, Gurucharan Shetty >> > wrote: >> >> The only reason I ask is because we have had successful RHEL rpm >> >> builds for a long time now. I have atleast tested it upto Centos 6.5 >> >> with OVS 2.3. Do you see problems with OVS 2.3 too?. I also have a >> >> internal system that builds a RHEL 7 rpm for every OVS commit and they >> >> have been building just fine. So trying to understand on why I have >> >> not come across a bug report like this. >> >> >> >> On Tue, Sep 15, 2015 at 11:16 AM, Tashi Lu >> >> wrote: >> >>> Only tested on several CentOS 6.6 boxes. >> >>> Is this distro version relevant? These missing files, including the >> >>> ones in >> >>> the 2nd patch, are really confusing to me. >> >>> blp cross referenced the better maintained fedora build spec, and >> >>> those >> >>> files are excluded. Why are these binaries not built and distributed >> >>> on >> >>> rhel? >> >>> >> >>> On 16 September 2015 at 01:54, Gurucharan Shetty >> >>> wrote: >> >>>> >> >>>> On Tue, Sep 15, 2015 at 10:43 AM, Tashi Lu >> >>>> wrote: >> >>>> > From 338df1bfb07f7b0f16037aa0bbb8fe5dba6aa005 Mon Sep 17 00:00:00 >> >>>> > 2001 >> >>>> > From: dotSlashLu >> >>>> > Date: Fri, 4 Sep 2015 21:38:13 +0800 >> >>>> > Subject: [PATCH 1/3] rhel: fix 'cannot remove' build error >> >>>> > >> >>>> > These 3 patches are for fixing several rpm build errors on CentOS >> >>>> > 6.x, >> >>>> > see >> >>>> > https://github.com/openvswitch/ovs/pull/65 >> >>>> > >> >>>> > Fix rpmbuild error: >> >>>> > rm: cannot remove >> >>>> > >> >>>> > `/root/rpmbuild/BUILDROOT/openvswitch-2.4.90-1.x86_64/usr/bin/ovs-test': >> >>>> > No >> >>>> > su >> >>>> > rm: cannot remove >> >>>> > >> >>>> > >> >>>> > `/root/rpmbuild/BUILDROOT/openvswitch-2.4.90-1.x86_64/usr/bin/ovs-l3ping': >> >>>> > No >> >>>> > error: Bad exit status from /var/tmp/rpm-tmp.dd9miw (%install) >> >>>> > >> >>>> > Signed-off-by: Dotslash Lu >> >>>> >> >>>> What centos do you see these errors in? Do you see it in centos6.5 or >> >>>> lower? >> >>>> >> >>>> >> >>>> > --- >> >>>> > rhel/openvswitch.spec.in | 2 +- >> >>>> > 1 files changed, 1 insertions(+), 1 deletions(-) >> >>>> > >> >>>> > diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in >> >>>> > index dad3e04..cc9d9ab 100644 >> >>>> > --- a/rhel/openvswitch.spec.in >> >>>> > +++ b/rhel/openvswitch.spec.in >> >>>> > @@ -56,7 +56,7 @@ rhel_cp etc_sysconfig_network-scripts_ifdown-ovs >> >>>> > 0755 >> >>>> > rhel_cp usr_share_openvswitch_scripts_sysconfig.template 0644 >> >>>> > >> >>>> > # Get rid of stuff we don't want to make RPM happy. >> >>>> > -rm \ >> >>>> > +rm -rf \ >> >>>> > $RPM_BUILD_ROOT/usr/bin/ovs-testcontroller \ >> >>>> > $RPM_BUILD_ROOT/usr/share/man/man8/ovs-testcontroller.8 \ >> >>>> > $RPM_BUILD_ROOT/usr/bin/ovs-test \ >> >>>> > -- >> >>>> > 1.7.1 >> >>>> > _______________________________________________ >> >>>> > dev mailing list >> >>>> > dev@openvswitch.org >> >>>> > http://openvswitch.org/mailman/listinfo/dev >> >>> >> >>> > > diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in index dad3e04..0ec65be 100644 --- a/rhel/openvswitch.spec.in +++ b/rhel/openvswitch.spec.in @@ -22,7 +22,7 @@ License: ASL 2.0 Release: 1 Source: openvswitch-%{version}.tar.gz Buildroot: /tmp/openvswitch-rpm -Requires: logrotate, python +Requires: logrotate, python >= 2.7 BuildRequires: openssl-devel %bcond_without check @@ -180,7 +180,6 @@ exit 0 /var/lib/openvswitch /var/log/openvswitch %exclude /usr/bin/ovn-* -%exclude /usr/share/man/man1/ovs-sim.1.gz %exclude /usr/share/man/man5/ovn-* %exclude /usr/share/man/man7/ovn-* %exclude /usr/share/man/man8/ovn-*