From patchwork Tue Sep 8 23:31:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Pfaff X-Patchwork-Id: 515640 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (unknown [IPv6:2600:3c00::f03c:91ff:fe6e:bdf7]) by ozlabs.org (Postfix) with ESMTP id 954EF14031D for ; Wed, 9 Sep 2015 09:31:27 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id BF433106C8; Tue, 8 Sep 2015 16:31:26 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v1.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 8A4E310264 for ; Tue, 8 Sep 2015 16:31:25 -0700 (PDT) Received: from bar3.cudamail.com (bar1 [192.168.15.1]) by mx3v1.cudamail.com (Postfix) with ESMTP id D65A8618BED for ; Tue, 8 Sep 2015 17:31:23 -0600 (MDT) X-ASG-Debug-ID: 1441755083-03dd7b55fb0e3b0001-byXFYA Received: from mx3-pf1.cudamail.com ([192.168.14.2]) by bar3.cudamail.com with ESMTP id yvXr7kXK9vZkG0j3 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 08 Sep 2015 17:31:23 -0600 (MDT) X-Barracuda-Envelope-From: blp@nicira.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.2 Received: from unknown (HELO mail-pa0-f50.google.com) (209.85.220.50) by mx3-pf1.cudamail.com with ESMTPS (RC4-SHA encrypted); 8 Sep 2015 23:31:23 -0000 Received-SPF: unknown (mx3-pf1.cudamail.com: Multiple SPF records returned) X-Barracuda-Apparent-Source-IP: 209.85.220.50 X-Barracuda-RBL-IP: 209.85.220.50 Received: by pacex6 with SMTP id ex6so137209784pac.0 for ; Tue, 08 Sep 2015 16:31:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=po9ZywRYcnStiHldFg8MkWARYWabiRFYJzMVNTputyo=; b=EN8PpKrXAogmRdApDQ/bGXcF4RMVuA0l9MI/sMMRtKoWywJ8sEEzjm2yr6W5FwvuHH NYF6lVvf+XeD1AvJt1sc6uKQSXgvrbEBG//dnliiWSKG/dcKD2f1lI58B7S+Vg8QdUl+ aaNbzKbj3J6zH2zcurQQoJ5jPAOYkYHiXDPzj1x7iv0SQyL9Wc5MsVxQ3sdd0koLsfn1 MFZggOAq78wY4d8QGVFJx4uu7sSEFPv15D8v7PDo8GgmHQITQ8YMChFnawrPw/AUD4jY sCa+3DBKH40mqtdy28w2zMQXB1hMEcB/M1RjGsxJw9s4ItUFrav5ZXFalO9quEwTihaL Gy7w== X-Gm-Message-State: ALoCoQkwaaMi8UW5uYNfbZhq1M6xh6CZMDUkMC2flxD+yQxMe4QTIgI0miBwE9NNS9A4D5097De5 X-Received: by 10.69.26.196 with SMTP id ja4mr62458970pbd.121.1441755082481; Tue, 08 Sep 2015 16:31:22 -0700 (PDT) Received: from sigabrt.benpfaff.org (173-228-112-165.dsl.dynamic.fusionbroadband.com. [173.228.112.165]) by smtp.gmail.com with ESMTPSA id t15sm4717846pbs.10.2015.09.08.16.31.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 Sep 2015 16:31:20 -0700 (PDT) X-CudaMail-Envelope-Sender: blp@nicira.com From: Ben Pfaff To: dev@openvswitch.org X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-V1-907065644 X-CudaMail-DTE: 090815 X-CudaMail-Originating-IP: 209.85.220.50 Date: Tue, 8 Sep 2015 16:31:30 -0700 X-ASG-Orig-Subj: [##CM-V1-907065644##][PATCH] ofproto-dpif-xlate: Lower missing netdev_max_backlog from WARN to INFO. Message-Id: <1441755090-11722-1-git-send-email-blp@nicira.com> X-Mailer: git-send-email 2.1.3 X-Barracuda-Connect: UNKNOWN[192.168.14.2] X-Barracuda-Start-Time: 1441755083 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Cc: Ben Pfaff , qcorba Subject: [ovs-dev] [PATCH] ofproto-dpif-xlate: Lower missing netdev_max_backlog from WARN to INFO. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" In a network namespace, /proc/sys/net/core/netdev_max_backlog is not present, so people running OVS inside Docker will always get a log message here. That's not important enough to rise to a WARN level that causes tests to fail, especially since the default value is rarely changed (and wouldn't normally be lowered), so reduce the log leve for this to INFO. Reported-by: qcorba Reported-at: http://openvswitch.org/pipermail/discuss/2015-August/018581.html Signed-off-by: Ben Pfaff Acked-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index de5c9b1..d7ecbe3 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -4634,7 +4634,7 @@ netdev_max_backlog(void) stream = fopen(filename, "r"); if (!stream) { - VLOG_WARN("%s: open failed (%s)", filename, ovs_strerror(errno)); + VLOG_INFO("%s: open failed (%s)", filename, ovs_strerror(errno)); } else { if (fscanf(stream, "%d", &n) != 1) { VLOG_WARN("%s: read error", filename);