[ovs-dev] ofproto-dpif-xlate: Lower missing netdev_max_backlog from WARN to INFO.
diff mbox

Message ID 1441755090-11722-1-git-send-email-blp@nicira.com
State Accepted
Headers show

Commit Message

Ben Pfaff Sept. 8, 2015, 11:31 p.m. UTC
In a network namespace, /proc/sys/net/core/netdev_max_backlog is not
present, so people running OVS inside Docker will always get a log message
here.  That's not important enough to rise to a WARN level that causes
tests to fail, especially since the default value is rarely changed (and
wouldn't normally be lowered), so reduce the log leve for this to INFO.

Reported-by: qcorba <qcorba@gmail.com>
Reported-at: http://openvswitch.org/pipermail/discuss/2015-August/018581.html
Signed-off-by: Ben Pfaff <blp@nicira.com>
---
 ofproto/ofproto-dpif-xlate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jarno Rajahalme Sept. 9, 2015, 1:22 a.m. UTC | #1
Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>

> On Sep 8, 2015, at 4:31 PM, Ben Pfaff <blp@nicira.com> wrote:
> 
> In a network namespace, /proc/sys/net/core/netdev_max_backlog is not
> present, so people running OVS inside Docker will always get a log message
> here.  That's not important enough to rise to a WARN level that causes
> tests to fail, especially since the default value is rarely changed (and
> wouldn't normally be lowered), so reduce the log leve for this to INFO.
> 
> Reported-by: qcorba <qcorba@gmail.com>
> Reported-at: http://openvswitch.org/pipermail/discuss/2015-August/018581.html
> Signed-off-by: Ben Pfaff <blp@nicira.com>
> ---
> ofproto/ofproto-dpif-xlate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
> index de5c9b1..d7ecbe3 100644
> --- a/ofproto/ofproto-dpif-xlate.c
> +++ b/ofproto/ofproto-dpif-xlate.c
> @@ -4634,7 +4634,7 @@ netdev_max_backlog(void)
> 
>         stream = fopen(filename, "r");
>         if (!stream) {
> -            VLOG_WARN("%s: open failed (%s)", filename, ovs_strerror(errno));
> +            VLOG_INFO("%s: open failed (%s)", filename, ovs_strerror(errno));
>         } else {
>             if (fscanf(stream, "%d", &n) != 1) {
>                 VLOG_WARN("%s: read error", filename);
> -- 
> 2.1.3
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
Ben Pfaff Sept. 9, 2015, 5:13 p.m. UTC | #2
Thanks, applied to master.

On Tue, Sep 08, 2015 at 06:22:31PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
> 
> > On Sep 8, 2015, at 4:31 PM, Ben Pfaff <blp@nicira.com> wrote:
> > 
> > In a network namespace, /proc/sys/net/core/netdev_max_backlog is not
> > present, so people running OVS inside Docker will always get a log message
> > here.  That's not important enough to rise to a WARN level that causes
> > tests to fail, especially since the default value is rarely changed (and
> > wouldn't normally be lowered), so reduce the log leve for this to INFO.
> > 
> > Reported-by: qcorba <qcorba@gmail.com>
> > Reported-at: http://openvswitch.org/pipermail/discuss/2015-August/018581.html
> > Signed-off-by: Ben Pfaff <blp@nicira.com>
> > ---
> > ofproto/ofproto-dpif-xlate.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
> > index de5c9b1..d7ecbe3 100644
> > --- a/ofproto/ofproto-dpif-xlate.c
> > +++ b/ofproto/ofproto-dpif-xlate.c
> > @@ -4634,7 +4634,7 @@ netdev_max_backlog(void)
> > 
> >         stream = fopen(filename, "r");
> >         if (!stream) {
> > -            VLOG_WARN("%s: open failed (%s)", filename, ovs_strerror(errno));
> > +            VLOG_INFO("%s: open failed (%s)", filename, ovs_strerror(errno));
> >         } else {
> >             if (fscanf(stream, "%d", &n) != 1) {
> >                 VLOG_WARN("%s: read error", filename);
> > -- 
> > 2.1.3
> > 
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>
Ben Pfaff Sept. 9, 2015, 5:13 p.m. UTC | #3
and branch-2.4.

On Wed, Sep 09, 2015 at 10:13:01AM -0700, Ben Pfaff wrote:
> Thanks, applied to master.
> 
> On Tue, Sep 08, 2015 at 06:22:31PM -0700, Jarno Rajahalme wrote:
> > Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
> > 
> > > On Sep 8, 2015, at 4:31 PM, Ben Pfaff <blp@nicira.com> wrote:
> > > 
> > > In a network namespace, /proc/sys/net/core/netdev_max_backlog is not
> > > present, so people running OVS inside Docker will always get a log message
> > > here.  That's not important enough to rise to a WARN level that causes
> > > tests to fail, especially since the default value is rarely changed (and
> > > wouldn't normally be lowered), so reduce the log leve for this to INFO.
> > > 
> > > Reported-by: qcorba <qcorba@gmail.com>
> > > Reported-at: http://openvswitch.org/pipermail/discuss/2015-August/018581.html
> > > Signed-off-by: Ben Pfaff <blp@nicira.com>
> > > ---
> > > ofproto/ofproto-dpif-xlate.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
> > > index de5c9b1..d7ecbe3 100644
> > > --- a/ofproto/ofproto-dpif-xlate.c
> > > +++ b/ofproto/ofproto-dpif-xlate.c
> > > @@ -4634,7 +4634,7 @@ netdev_max_backlog(void)
> > > 
> > >         stream = fopen(filename, "r");
> > >         if (!stream) {
> > > -            VLOG_WARN("%s: open failed (%s)", filename, ovs_strerror(errno));
> > > +            VLOG_INFO("%s: open failed (%s)", filename, ovs_strerror(errno));
> > >         } else {
> > >             if (fscanf(stream, "%d", &n) != 1) {
> > >                 VLOG_WARN("%s: read error", filename);
> > > -- 
> > > 2.1.3
> > > 
> > > _______________________________________________
> > > dev mailing list
> > > dev@openvswitch.org
> > > http://openvswitch.org/mailman/listinfo/dev
> >

Patch
diff mbox

diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index de5c9b1..d7ecbe3 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -4634,7 +4634,7 @@  netdev_max_backlog(void)
 
         stream = fopen(filename, "r");
         if (!stream) {
-            VLOG_WARN("%s: open failed (%s)", filename, ovs_strerror(errno));
+            VLOG_INFO("%s: open failed (%s)", filename, ovs_strerror(errno));
         } else {
             if (fscanf(stream, "%d", &n) != 1) {
                 VLOG_WARN("%s: read error", filename);