| Message ID | 1436607308-14852-1-git-send-email-kevin@darbyshire-bryant.me.uk |
|---|---|
| State | Rejected |
| Delegated to: | Felix Fietkau |
| Headers | show |
> When using DFS channels on Ath10k kernel log has warning message 'failed > to process fft', typically when under medium/heavy traffic. Ticket > https://dev.openwrt.org/ticket/19316 discusses and concludes messages > are harmless. They do still contribute to log noise, so this patch > enables them only in driver debug mode. Hopefully this will stop people > like me worrying about them. > > Tested on Archer C7 > > Signed-off-by: Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk <https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel>> > --- > .../931-ath10k_suppress_failed_to_process_fft_warning.patch | 11 +++++++++++ > 1 file changed, 11 insertions(+) > create mode 100644 package/kernel/mac80211/patches/931-ath10k_suppress_failed_to_process_fft_warning.patch > > diff --git a/package/kernel/mac80211/patches/931-ath10k_suppress_failed_to_process_fft_warning.patch b/package/kernel/mac80211/patches/931-ath10k_suppress_failed_to_process_fft_warning.patch > new file mode 100644 > index 0000000..dceab0f > --- /dev/null > +++ b/package/kernel/mac80211/patches/931-ath10k_suppress_failed_to_process_fft_warning.patch > @@ -0,0 +1,11 @@ > +--- a/drivers/net/wireless/ath/ath10k/wmi.c > ++++ b/drivers/net/wireless/ath/ath10k/wmi.c > +@@ -2658,7 +2658,7 @@ void ath10k_wmi_event_spectral_scan(stru > + fftr, fftr_len, > + tsf); > + if (res < 0) { > +- ath10k_warn(ar, "failed to process fft report: %d\n", > ++ ath10k_dbg(ar, ATH10K_DBG_WMI, "failed to process fft report: %d\n", > + res); > + return; > + } > -- > 1.9.1 Looks good to me. Could you also send a patch to the ath10k mailing list (against kvalo's ath git)? Matti
On 15/07/2015 13:22, Matti Laakso wrote: >> When using DFS channels on Ath10k kernel log has warning message 'failed >> to process fft', typically when under medium/heavy traffic. Ticket >> https://dev.openwrt.org/ticket/19316 discusses and concludes messages >> are harmless. They do still contribute to log noise, so this patch >> enables them only in driver debug mode. Hopefully this will stop people >> like me worrying about them. >> >> Tested on Archer C7 >> >> Signed-off-by: Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk >> <https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel>> >> --- >> .../931-ath10k_suppress_failed_to_process_fft_warning.patch | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> create mode 100644 package/kernel/mac80211/patches/931-ath10k_suppress_failed_to_process_fft_warning.patch >> >> diff --git a/package/kernel/mac80211/patches/931-ath10k_suppress_failed_to_process_fft_warning.patch b/package/kernel/mac80211/patches/931-ath10k_suppress_failed_to_process_fft_warning.patch >> new file mode 100644 >> index 0000000..dceab0f >> --- /dev/null >> +++ b/package/kernel/mac80211/patches/931-ath10k_suppress_failed_to_process_fft_warning.patch >> @@ -0,0 +1,11 @@ >> +--- a/drivers/net/wireless/ath/ath10k/wmi.c >> ++++ b/drivers/net/wireless/ath/ath10k/wmi.c >> +@@ -2658,7 +2658,7 @@ void ath10k_wmi_event_spectral_scan(stru >> + fftr, fftr_len, >> + tsf); >> + if (res < 0) { >> +- ath10k_warn(ar, "failed to process fft report: %d\n", >> ++ ath10k_dbg(ar, ATH10K_DBG_WMI, "failed to process fft report: %d\n", >> + res); >> + return; >> + } >> -- >> 1.9.1 > > Looks good to me. Could you also send a patch to the ath10k mailing > list (against kvalo's ath git)? > > Matti Yes shouldn't be a problem. It'll take me a few days to get the opportunity to do so as busy occupied on other things. Kevin
diff --git a/package/kernel/mac80211/patches/931-ath10k_suppress_failed_to_process_fft_warning.patch b/package/kernel/mac80211/patches/931-ath10k_suppress_failed_to_process_fft_warning.patch new file mode 100644 index 0000000..dceab0f --- /dev/null +++ b/package/kernel/mac80211/patches/931-ath10k_suppress_failed_to_process_fft_warning.patch @@ -0,0 +1,11 @@ +--- a/drivers/net/wireless/ath/ath10k/wmi.c ++++ b/drivers/net/wireless/ath/ath10k/wmi.c +@@ -2658,7 +2658,7 @@ void ath10k_wmi_event_spectral_scan(stru + fftr, fftr_len, + tsf); + if (res < 0) { +- ath10k_warn(ar, "failed to process fft report: %d\n", ++ ath10k_dbg(ar, ATH10K_DBG_WMI, "failed to process fft report: %d\n", + res); + return; + }
When using DFS channels on Ath10k kernel log has warning message 'failed to process fft', typically when under medium/heavy traffic. Ticket https://dev.openwrt.org/ticket/19316 discusses and concludes messages are harmless. They do still contribute to log noise, so this patch enables them only in driver debug mode. Hopefully this will stop people like me worrying about them. Tested on Archer C7 Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> --- .../931-ath10k_suppress_failed_to_process_fft_warning.patch | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 package/kernel/mac80211/patches/931-ath10k_suppress_failed_to_process_fft_warning.patch