| Message ID | 1435460618-18334-1-git-send-email-vz@mleia.com |
|---|---|
| State | Accepted |
| Delegated to: | Joe Hershberger |
| Headers | show |
Bonjour Vladimir, Le Sun, 28 Jun 2015 06:03:38 +0300, Vladimir Zapolskiy <vz@mleia.com> a écrit : > According to LPC32x0 User Manual the following bits in Command > register 0x3106_0100 are defined: > > Bit Symbol > 2 - Unused > 3 RegReset > 4 TxReset > 5 RxReset > > Fix wrong (1-bit shifted right) COMMAND_RESETS value, which sets > an unused bit, but neglects RxReset. > > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> > --- > drivers/net/lpc32xx_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/lpc32xx_eth.c b/drivers/net/lpc32xx_eth.c > index 8dcbb4a..72451a9 100644 > --- a/drivers/net/lpc32xx_eth.c > +++ b/drivers/net/lpc32xx_eth.c > @@ -170,7 +170,7 @@ struct lpc32xx_eth_registers { > #define COMMAND_PASSRUNTFRAME 0x00000040 > #define COMMAND_FULL_DUPLEX 0x00000400 > /* Helper: general reset */ > -#define COMMAND_RESETS 0x0000001C > +#define COMMAND_RESETS 0x00000038 > > /* STATUS register bitfields/masks and offsets (see Table 283) */ > #define STATUS_RXSTATUS 0x00000001 Acked-by: Albert ARIBAUD (3ADEV) <albert.aribaud@3adev.fr> Thanks for pointing this bug out! Cordialement, Albert ARIBAUD 3ADEV
Hi Vladimir, On Sat, Jun 27, 2015 at 10:03 PM, Vladimir Zapolskiy <vz@mleia.com> wrote: > According to LPC32x0 User Manual the following bits in Command > register 0x3106_0100 are defined: > > Bit Symbol > 2 - Unused > 3 RegReset > 4 TxReset > 5 RxReset > > Fix wrong (1-bit shifted right) COMMAND_RESETS value, which sets > an unused bit, but neglects RxReset. > > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> > --- Acked-by: Joe Hershberger <joe.hershberger@ni.com> I'll pull this into u-boot-net/next, Thanks! -Joe
Hi Joe, On 29.06.2015 23:38, Joe Hershberger wrote: > Hi Vladimir, > > On Sat, Jun 27, 2015 at 10:03 PM, Vladimir Zapolskiy <vz@mleia.com> wrote: >> According to LPC32x0 User Manual the following bits in Command >> register 0x3106_0100 are defined: >> >> Bit Symbol >> 2 - Unused >> 3 RegReset >> 4 TxReset >> 5 RxReset >> >> Fix wrong (1-bit shifted right) COMMAND_RESETS value, which sets >> an unused bit, but neglects RxReset. >> >> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> >> --- > > Acked-by: Joe Hershberger <joe.hershberger@ni.com> > > I'll pull this into u-boot-net/next, Thanks! > -Joe > ping. With best wishes, Vladimir
Hi Vladimir, On Sat, Jun 27, 2015 at 10:03 PM, Vladimir Zapolskiy <vz@mleia.com> wrote: > According to LPC32x0 User Manual the following bits in Command > register 0x3106_0100 are defined: > > Bit Symbol > 2 - Unused > 3 RegReset > 4 TxReset > 5 RxReset > > Fix wrong (1-bit shifted right) COMMAND_RESETS value, which sets > an unused bit, but neglects RxReset. > > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Applied to u-boot-net, thanks! -Joe
diff --git a/drivers/net/lpc32xx_eth.c b/drivers/net/lpc32xx_eth.c index 8dcbb4a..72451a9 100644 --- a/drivers/net/lpc32xx_eth.c +++ b/drivers/net/lpc32xx_eth.c @@ -170,7 +170,7 @@ struct lpc32xx_eth_registers { #define COMMAND_PASSRUNTFRAME 0x00000040 #define COMMAND_FULL_DUPLEX 0x00000400 /* Helper: general reset */ -#define COMMAND_RESETS 0x0000001C +#define COMMAND_RESETS 0x00000038 /* STATUS register bitfields/masks and offsets (see Table 283) */ #define STATUS_RXSTATUS 0x00000001
According to LPC32x0 User Manual the following bits in Command register 0x3106_0100 are defined: Bit Symbol 2 - Unused 3 RegReset 4 TxReset 5 RxReset Fix wrong (1-bit shifted right) COMMAND_RESETS value, which sets an unused bit, but neglects RxReset. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> --- drivers/net/lpc32xx_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)