| Message ID | 1407154628-12791-1-git-send-email-Anton.Kolesov@synopsys.com |
|---|---|
| State | Superseded |
| Headers | show |
Anton, All, On 2014-08-04 16:17 +0400, Anton Kolesov spake thusly: > Add atomic intrinsics to the examples of dependencies comments. > > Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > docs/manual/adding-packages-directory.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt > index 93e6a3e..4b4d056 100644 > --- a/docs/manual/adding-packages-directory.txt > +++ b/docs/manual/adding-packages-directory.txt > @@ -265,6 +265,10 @@ use in the comment. > ** Dependency symbol: +!BR2_PREFER_STATIC_LIB+ > ** Comment string: +dynamic library+ > > +* Atomic intrinsics > +** Dependency symbol: +!BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS+ > +** Comment string: +atomic intrinsics+ > + > ==== Dependencies on a Linux kernel built by buildroot > > Some packages need a Linux kernel to be built by buildroot. These are > -- > 1.8.4.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Dear Anton Kolesov, On Mon, 4 Aug 2014 16:17:08 +0400, Anton Kolesov wrote: > diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt > index 93e6a3e..4b4d056 100644 > --- a/docs/manual/adding-packages-directory.txt > +++ b/docs/manual/adding-packages-directory.txt > @@ -265,6 +265,10 @@ use in the comment. > ** Dependency symbol: +!BR2_PREFER_STATIC_LIB+ > ** Comment string: +dynamic library+ > > +* Atomic intrinsics > +** Dependency symbol: +!BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS+ > +** Comment string: +atomic intrinsics+ Actually, the more I think about this, and the more I believe it should be a property of the architecture rather than a property of the toolchain. So it should probably rather be BR2_ARCH_HAS_ATOMIC_INTRINSICS. And then, since it's a property of the architecture, i.e not something the user can enable/disable, there is no point in adding Config.in comment for that. So we would handle that like we handle BR2_USE_MMU, not like we handle BR2_LARGEFILE. Thoughts? Thomas
Thomas, Anton, All, On 2014-08-16 00:17 +0200, Thomas Petazzoni spake thusly: > On Mon, 4 Aug 2014 16:17:08 +0400, Anton Kolesov wrote: > > diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt > > index 93e6a3e..4b4d056 100644 > > --- a/docs/manual/adding-packages-directory.txt > > +++ b/docs/manual/adding-packages-directory.txt > > @@ -265,6 +265,10 @@ use in the comment. > > ** Dependency symbol: +!BR2_PREFER_STATIC_LIB+ > > ** Comment string: +dynamic library+ > > > > +* Atomic intrinsics > > +** Dependency symbol: +!BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS+ > > +** Comment string: +atomic intrinsics+ > > Actually, the more I think about this, and the more I believe it should > be a property of the architecture rather than a property of the > toolchain. So it should probably rather be > BR2_ARCH_HAS_ATOMIC_INTRINSICS. And then, since it's a property of the > architecture, i.e not something the user can enable/disable, there is > no point in adding Config.in comment for that. So we would handle that > like we handle BR2_USE_MMU, not like we handle BR2_LARGEFILE. > > Thoughts? Ah, I remember now, that we talked about that. My bad, I had forgotten during the review. However, we can't really change the implementation now, we're frozen for the release. What about adding this to the manual for now, since it does reflect the current status of the code, and switch to an architecture option in -next, or after the release is cut? Regards, Yann E. MORIN.
Dear Yann E. MORIN, On Sat, 16 Aug 2014 00:23:08 +0200, Yann E. MORIN wrote: > Ah, I remember now, that we talked about that. My bad, I had forgotten > during the review. > > However, we can't really change the implementation now, we're frozen for > the release. > > What about adding this to the manual for now, since it does reflect the > current status of the code, and switch to an architecture option in > -next, or after the release is cut? I disagree: it's still time to change this, before it gets set in stone by doing a release. Thomas
Thomas, All, On 2014-08-16 09:40 +0200, Thomas Petazzoni spake thusly: > On Sat, 16 Aug 2014 00:23:08 +0200, Yann E. MORIN wrote: > > > Ah, I remember now, that we talked about that. My bad, I had forgotten > > during the review. > > > > However, we can't really change the implementation now, we're frozen for > > the release. > > > > What about adding this to the manual for now, since it does reflect the > > current status of the code, and switch to an architecture option in > > -next, or after the release is cut? > > I disagree: it's still time to change this, before it gets set in stone > by doing a release. OK, I'll see to send a patch series for that tonight. Regards, Yann E. MORIN.
diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt index 93e6a3e..4b4d056 100644 --- a/docs/manual/adding-packages-directory.txt +++ b/docs/manual/adding-packages-directory.txt @@ -265,6 +265,10 @@ use in the comment. ** Dependency symbol: +!BR2_PREFER_STATIC_LIB+ ** Comment string: +dynamic library+ +* Atomic intrinsics +** Dependency symbol: +!BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS+ +** Comment string: +atomic intrinsics+ + ==== Dependencies on a Linux kernel built by buildroot Some packages need a Linux kernel to be built by buildroot. These are
Add atomic intrinsics to the examples of dependencies comments. Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com> --- docs/manual/adding-packages-directory.txt | 4 ++++ 1 file changed, 4 insertions(+)