Message ID | 20230804093354.6619-5-jonas@kwiboo.se |
---|---|
State | Accepted |
Commit | 9296f9a8d7ffc96b8a8220a0e74c7dacb1934b2e |
Delegated to: | Kever Yang |
Headers | show |
Series | rockchip: Clock fixes for RK3568 | expand |
On 2023/8/4 17:34, Jonas Karlman wrote: > Pine64 Quartz64 boards DT reference SCLK_GMAC1_RGMII_SPEED in the > assigned-clocks property of the gmac1 node. This result in a ENOENT > error when driver core tries to set a parent for this clock. > > The clock speed in rgmii/rmii mode is changed using clk_set_rate of the > tx_rx clock and not using clk_set_parent of the speed clock. > > Add dummy support for SCLK_GMAC1_RGMII_SPEED and similar clocks to clk > driver to allow a driver for gmac node to probe. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > drivers/clk/rockchip/clk_rk3568.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/clk/rockchip/clk_rk3568.c b/drivers/clk/rockchip/clk_rk3568.c > index dabc7e70dd5a..599b7b130eb9 100644 > --- a/drivers/clk/rockchip/clk_rk3568.c > +++ b/drivers/clk/rockchip/clk_rk3568.c > @@ -2843,6 +2843,10 @@ static int rk3568_clk_set_parent(struct clk *clk, struct clk *parent) > case CLK_RKVDEC_CORE: > return rk3568_rkvdec_set_parent(clk, parent); > case I2S1_MCLKOUT_TX: > + case SCLK_GMAC0_RGMII_SPEED: > + case SCLK_GMAC0_RMII_SPEED: > + case SCLK_GMAC1_RGMII_SPEED: > + case SCLK_GMAC1_RMII_SPEED: > break; > default: > return -ENOENT;
diff --git a/drivers/clk/rockchip/clk_rk3568.c b/drivers/clk/rockchip/clk_rk3568.c index dabc7e70dd5a..599b7b130eb9 100644 --- a/drivers/clk/rockchip/clk_rk3568.c +++ b/drivers/clk/rockchip/clk_rk3568.c @@ -2843,6 +2843,10 @@ static int rk3568_clk_set_parent(struct clk *clk, struct clk *parent) case CLK_RKVDEC_CORE: return rk3568_rkvdec_set_parent(clk, parent); case I2S1_MCLKOUT_TX: + case SCLK_GMAC0_RGMII_SPEED: + case SCLK_GMAC0_RMII_SPEED: + case SCLK_GMAC1_RGMII_SPEED: + case SCLK_GMAC1_RMII_SPEED: break; default: return -ENOENT;
Pine64 Quartz64 boards DT reference SCLK_GMAC1_RGMII_SPEED in the assigned-clocks property of the gmac1 node. This result in a ENOENT error when driver core tries to set a parent for this clock. The clock speed in rgmii/rmii mode is changed using clk_set_rate of the tx_rx clock and not using clk_set_parent of the speed clock. Add dummy support for SCLK_GMAC1_RGMII_SPEED and similar clocks to clk driver to allow a driver for gmac node to probe. Signed-off-by: Jonas Karlman <jonas@kwiboo.se> --- drivers/clk/rockchip/clk_rk3568.c | 4 ++++ 1 file changed, 4 insertions(+)