| Message ID | 20230527205048.418360-1-festevam@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2,1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 9 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Sat, 27 May 2023 17:50:46 -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The PFUZE100 PMIC has an interrupt pin that can be connected to > the host SoC. Describe it in the dt-bindings to avoid warnings like: > > imx6q-zii-rdu2.dtb: pmic@8: 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' > From schema: Documentation/devicetree/bindings/regulator/pfuze100.yaml > > Signed-off-by: Fabio Estevam <festevam@denx.de> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > --- > Changes since v1: > - None. Only collected Conor's Reviewed-by tag. > > Documentation/devicetree/bindings/regulator/pfuze100.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1786770 pf0100@8: $nodename:0: 'pf0100@8' does not match '^pmic@[0-9]$' arch/arm/boot/dts/imx6dl-riotboard.dtb pfuze100@8: $nodename:0: 'pfuze100@8' does not match '^pmic@[0-9]$' arch/arm/boot/dts/imx6dl-gw54xx.dtb arch/arm/boot/dts/imx6dl-sabreauto.dtb arch/arm/boot/dts/imx6dl-sabresd.dtb arch/arm/boot/dts/imx6dl-wandboard-revd1.dtb arch/arm/boot/dts/imx6q-dmo-edmqmx6.dtb arch/arm/boot/dts/imx6q-gw5400-a.dtb arch/arm/boot/dts/imx6q-gw54xx.dtb arch/arm/boot/dts/imx6q-novena.dtb arch/arm/boot/dts/imx6q-pistachio.dtb arch/arm/boot/dts/imx6qp-sabreauto.dtb arch/arm/boot/dts/imx6qp-sabresd.dtb arch/arm/boot/dts/imx6qp-wandboard-revd1.dtb arch/arm/boot/dts/imx6q-sabreauto.dtb arch/arm/boot/dts/imx6q-sabresd.dtb arch/arm/boot/dts/imx6q-wandboard-revd1.dtb arch/arm/boot/dts/imx6sl-evk.dtb arch/arm/boot/dts/imx6sx-sdb.dtb arch/arm/boot/dts/imx6sx-sdb-mqs.dtb arch/arm/boot/dts/imx6sx-sdb-reva.dtb arch/arm/boot/dts/imx6sx-sdb-sai.dtb arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb pfuze3000@8: $nodename:0: 'pfuze3000@8' does not match '^pmic@[0-9]$' arch/arm/boot/dts/imx6ul-pico-dwarf.dtb arch/arm/boot/dts/imx6ul-pico-hobbit.dtb arch/arm/boot/dts/imx6ul-pico-pi.dtb arch/arm/boot/dts/imx7d-nitrogen7.dtb arch/arm/boot/dts/imx7d-pico-dwarf.dtb arch/arm/boot/dts/imx7d-pico-hobbit.dtb arch/arm/boot/dts/imx7d-pico-nymph.dtb arch/arm/boot/dts/imx7d-pico-pi.dtb arch/arm/boot/dts/imx7d-sdb.dtb arch/arm/boot/dts/imx7d-sdb-reva.dtb arch/arm/boot/dts/imx7d-sdb-sht11.dtb arch/arm/boot/dts/imx7s-warp.dtb pmic@8: regulators: 'vcoin' does not match any of the regexes: '^(vsnvs|vref|vrefddr|swbst|coin|v33|vccsd)$', '^sw([1-4]|[1-4][a-c]|[1-4][a-c][a-c])$', '^vgen[1-6]$', '^vldo[1-4]$', 'pinctrl-[0-9]+' arch/arm/boot/dts/imx6ul-ccimx6ulsbcexpress.dtb arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dtb
On 30/05/2023 14:57, Krzysztof Kozlowski wrote: > On Sat, 27 May 2023 17:50:46 -0300, Fabio Estevam wrote: >> From: Fabio Estevam <festevam@denx.de> >> >> The PFUZE100 PMIC has an interrupt pin that can be connected to >> the host SoC. Describe it in the dt-bindings to avoid warnings like: >> >> imx6q-zii-rdu2.dtb: pmic@8: 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' >> From schema: Documentation/devicetree/bindings/regulator/pfuze100.yaml >> >> Signed-off-by: Fabio Estevam <festevam@denx.de> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> >> --- >> Changes since v1: >> - None. Only collected Conor's Reviewed-by tag. >> >> Documentation/devicetree/bindings/regulator/pfuze100.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1786770 > > > pf0100@8: $nodename:0: 'pf0100@8' does not match '^pmic@[0-9]$' > arch/arm/boot/dts/imx6dl-riotboard.dtb > > pfuze100@8: $nodename:0: 'pfuze100@8' does not match '^pmic@[0-9]$' It seems you fix all these. Best regards, Krzysztof
On 30/05/2023 09:59, Krzysztof Kozlowski wrote:
> It seems you fix all these.
That's correct. All these errors were fixed by this series.
On 27/05/2023 22:50, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Devicetree node names should be generic. Use 'pmic' as node name > to avoid devicetree check warning from pfuze100.yaml. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sat, 27 May 2023 17:50:46 -0300, Fabio Estevam wrote: > The PFUZE100 PMIC has an interrupt pin that can be connected to > the host SoC. Describe it in the dt-bindings to avoid warnings like: > > imx6q-zii-rdu2.dtb: pmic@8: 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' > From schema: Documentation/devicetree/bindings/regulator/pfuze100.yaml > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts commit: 87fe0214d7aae5e1152953710489c5ab5469b388 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Sat, May 27, 2023 at 05:50:47PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Devicetree node names should be generic. Use 'pmic' as node name > to avoid devicetree check warning from pfuze100.yaml. > > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied, thanks!
On Sat, May 27, 2023 at 05:50:48PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > As documented in pfuze100.yaml, the correct name for the regulator is > "coin", so change it to fix the following DT check warning: > > imx6ul-ccimx6ulsbcexpress.dtb: pmic@8: regulators: 'vcoin' does not match any of the regexes: > > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied, thanks!
diff --git a/Documentation/devicetree/bindings/regulator/pfuze100.yaml b/Documentation/devicetree/bindings/regulator/pfuze100.yaml index 67a30b23b92c..e384e4953f0a 100644 --- a/Documentation/devicetree/bindings/regulator/pfuze100.yaml +++ b/Documentation/devicetree/bindings/regulator/pfuze100.yaml @@ -36,6 +36,9 @@ properties: reg: maxItems: 1 + interrupts: + maxItems: 1 + fsl,pfuze-support-disable-sw: $ref: /schemas/types.yaml#/definitions/flag description: |