| Message ID | 20230515054402.27633-2-frank.li@vivo.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add T-HEAD th1520 soc clock support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 5 warnings, 60 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 15 May 2023 13:43:59 +0800, Yangtao Li wrote: > Add devicetree binding document and related header file > for the T-HEAD TH1520 clock. > > Cc: Icenowy Zheng <uwu@icenowy.me> > Cc: Wei Fu <wefu@redhat.com> > Cc: Jisheng Zhang <jszhang@kernel.org> > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > .../bindings/clock/thead,th1520-ccu.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml: properties:clock-names: 'const' should not be valid under {'enum': ['const', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'minimum', 'maximum', 'multipleOf', 'pattern']} hint: Scalar and array keywords cannot be mixed from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml: properties:clocks: 'const' should not be valid under {'enum': ['const', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'minimum', 'maximum', 'multipleOf', 'pattern']} hint: Scalar and array keywords cannot be mixed from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml: properties:clock-names:const: 2 is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml: properties:clocks: 'oneOf' conditional failed, one must be fixed: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml: properties:clocks: 'anyOf' conditional failed, one must be fixed: 'maxItems' is a required property hint: Only "maxItems" is required for a single entry if there are no constraints defined for the values. 'const' is not one of ['maxItems', 'description', 'deprecated'] hint: Only "maxItems" is required for a single entry if there are no constraints defined for the values. 'items' is not one of ['maxItems', 'description', 'deprecated'] hint: Only "maxItems" is required for a single entry if there are no constraints defined for the values. Additional properties are not allowed ('const' was unexpected) hint: Arrays must be described with a combination of minItems/maxItems/items 'items' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf'] hint: cell array properties must define how many entries and what the entries are when there is more than one entry. from schema $id: http://devicetree.org/meta-schemas/clocks.yaml# 'const' is not one of ['type', 'description', 'dependencies', 'dependentRequired', 'dependentSchemas', 'properties', 'patternProperties', 'additionalProperties', 'unevaluatedProperties', 'deprecated', 'required', 'not', 'allOf', 'anyOf', 'oneOf', '$ref'] 'items' is not one of ['type', 'description', 'dependencies', 'dependentRequired', 'dependentSchemas', 'properties', 'patternProperties', 'additionalProperties', 'unevaluatedProperties', 'deprecated', 'required', 'not', 'allOf', 'anyOf', 'oneOf', '$ref'] 'type' is a required property hint: DT nodes ("object" type in schemas) can only use a subset of json-schema keywords from schema $id: http://devicetree.org/meta-schemas/clocks.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.example.dtb: clock-controller@ffef010000: reg: [[255, 4009820160], [0, 4096]] is too long From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.example.dtb: clock-controller@ffef010000: clocks:0:0: 2 was expected From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.example.dtb: clock-controller@ffef010000: clock-names:0: 'losc' is not of type 'array' From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.example.dtb: clock-controller@ffef010000: clock-names: ['losc', 'hosc'] is too long From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml See https://patchwork.ozlabs.org/patch/1781099 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 15/05/2023 07:43, Yangtao Li wrote: > Add devicetree binding document and related header file > for the T-HEAD TH1520 clock. > > Cc: Icenowy Zheng <uwu@icenowy.me> > Cc: Wei Fu <wefu@redhat.com> > Cc: Jisheng Zhang <jszhang@kernel.org> > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > .../bindings/clock/thead,th1520-ccu.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml > > diff --git a/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml b/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml > new file mode 100644 > index 000000000000..c3e2d8c7efa6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/thead,th1520-ccu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: T-HEAD Clock Control Unit > + > +maintainers: > + - Jisheng Zhang <jszhang@kernel.org> > + - Wei Fu <wefu@redhat.com> > + - Yangtao Li <frank.li@vivo.com> > + > + Stray blank line. > +properties: > + "#clock-cells": > + const: 1 > + > + "#reset-cells": > + const: 1 > + > + compatible: Compatible is always first property. > + enum: > + - thead,th1520-ccu > + > + reg: > + maxItems: 1 > + > + clocks: > + const: 2 > + items: > + - description: High Frequency Oscillator (usually at 24MHz) > + - description: Low Frequency Oscillator (usually at 32kHz) Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). I'll stop review. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml b/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml new file mode 100644 index 000000000000..c3e2d8c7efa6 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml @@ -0,0 +1,60 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/thead,th1520-ccu.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: T-HEAD Clock Control Unit + +maintainers: + - Jisheng Zhang <jszhang@kernel.org> + - Wei Fu <wefu@redhat.com> + - Yangtao Li <frank.li@vivo.com> + + +properties: + "#clock-cells": + const: 1 + + "#reset-cells": + const: 1 + + compatible: + enum: + - thead,th1520-ccu + + reg: + maxItems: 1 + + clocks: + const: 2 + items: + - description: High Frequency Oscillator (usually at 24MHz) + - description: Low Frequency Oscillator (usually at 32kHz) + + clock-names: + const: 2 + items: + - const: hosc + - const: losc + +required: + - "#clock-cells" + - compatible + - reg + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + clk: clock-controller@ffef010000 { + compatible = "thead,th1520-ccu"; + reg = <0xff 0xef010000 0x0 0x1000>; + clocks = <&osc32k>, <&osc24m>; + clock-names = "losc", "hosc"; + #clock-cells = <1>; + }; + +...
Add devicetree binding document and related header file for the T-HEAD TH1520 clock. Cc: Icenowy Zheng <uwu@icenowy.me> Cc: Wei Fu <wefu@redhat.com> Cc: Jisheng Zhang <jszhang@kernel.org> Signed-off-by: Yangtao Li <frank.li@vivo.com> --- .../bindings/clock/thead,th1520-ccu.yaml | 60 +++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml