| Message ID | 1646547036-14885-3-git-send-email-vincent.sunplus@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add driver for ehci in Sunplus SP7021 | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On 06/03/2022 07:10, Vincent Shih wrote: > Add bindings doc for Sunplus EHCI driver > > Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> > --- > Changes in v2: > - Address the comments by Rob Herring. > > .../bindings/usb/sunplus,sp7021-usb-ehci.yaml | 63 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml > > diff --git a/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml > new file mode 100644 > index 0000000..905f68c > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) Sunplus Co., Ltd. 2021 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/sunplus,sp7021-usb-ehci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sunplus SP7021 EHCI Controller Device Tree bindings s/Device Tree bindings// (title describes hardware) > + > +allOf: > + - $ref: usb-hcd.yaml# > + > +maintainers: > + - Vincent Shih <vincent.sunplus@gmail.com> > + > +properties: > + compatible: > + const: sunplus,sp7021-usb2-ehci You do not use this compatible in the driver. > + > + clocks: > + maxItems: 1 > + > + resets: > + minItems: 1 Suddenly it became minItems. This looks odd, it should be maxItems: 1 rather. How many reset lines do you have there? > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + phys: > + maxItems: 1 > + > + phy-names: > + maxItems: 1 phy-names needs list of names. > + > +required: > + - compatible > + - clocks > + - resets > + - reg > + - interrupts > + - phys > + - phy-names > + > +additionalProperties: false This should be unevaluatedProperties:false, because you reference usb-hcd schema. > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + > + sp_ehci0: usb@9c102100 { > + compatible = "sunplus,sp7021-usb-ehci"; > + clocks = <&clkc 0x3a>; > + resets = <&rstc 0x2a>; > + reg = <0x9c102100 0x68>; reg goes after compatible in DTS. Best regards, Krzysztof
On Sun, 06 Mar 2022 14:10:36 +0800, Vincent Shih wrote: > Add bindings doc for Sunplus EHCI driver > > Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> > --- > Changes in v2: > - Address the comments by Rob Herring. > > .../bindings/usb/sunplus,sp7021-usb-ehci.yaml | 63 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.example.dts:37.5-6 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:378: Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1398: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1601662 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml new file mode 100644 index 0000000..905f68c --- /dev/null +++ b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) Sunplus Co., Ltd. 2021 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/sunplus,sp7021-usb-ehci.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sunplus SP7021 EHCI Controller Device Tree bindings + +allOf: + - $ref: usb-hcd.yaml# + +maintainers: + - Vincent Shih <vincent.sunplus@gmail.com> + +properties: + compatible: + const: sunplus,sp7021-usb2-ehci + + clocks: + maxItems: 1 + + resets: + minItems: 1 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + phys: + maxItems: 1 + + phy-names: + maxItems: 1 + +required: + - compatible + - clocks + - resets + - reg + - interrupts + - phys + - phy-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + sp_ehci0: usb@9c102100 { + compatible = "sunplus,sp7021-usb-ehci"; + clocks = <&clkc 0x3a>; + resets = <&rstc 0x2a>; + reg = <0x9c102100 0x68>; + interrupt-parent = <&intc>; + interrupts = <14 IRQ_TYPE_LEVEL_HIGH>; + phys = <&sp_uphy0>; + phy-names = "uphy"; + }; + ... diff --git a/MAINTAINERS b/MAINTAINERS index 6c2faf3..4e66993 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17951,6 +17951,7 @@ SUNPLUS USB EHCI DRIVER M: Vincent Shih <vincent.sunplus@gmail.com> L: linux-usb@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml F: drivers/usb/host/ehci-sunplus.c SUPERH
Add bindings doc for Sunplus EHCI driver Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> --- Changes in v2: - Address the comments by Rob Herring. .../bindings/usb/sunplus,sp7021-usb-ehci.yaml | 63 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml