| Message ID | 20220126141340.234125-3-alexander.stein@ew.tq-group.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | i.MX8MP: more USB3 glue layer feature support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, 26 Jan 2022 15:13:38 +0100, Alexander Stein wrote: > This adds bindings for features in the USB glue block. They allow > setting polarity of PWR and OC as well as disabling port power control. > Also permanently attached can be annotated as well. > Additional IO address and clock are needed. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > .../bindings/usb/fsl,imx8mp-dwc3.yaml | 31 ++++++++++++++++--- > 1 file changed, 27 insertions(+), 4 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1584490 usb@32f10100: reg: [[854655232, 8]] is too short arch/arm64/boot/dts/freescale/imx8mp-evk.dt.yaml arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dt.yaml usb@32f10108: reg: [[854655240, 8]] is too short arch/arm64/boot/dts/freescale/imx8mp-evk.dt.yaml arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dt.yaml
On Wed, 26 Jan 2022 15:13:38 +0100, Alexander Stein wrote: > This adds bindings for features in the USB glue block. They allow > setting polarity of PWR and OC as well as disabling port power control. > Also permanently attached can be annotated as well. > Additional IO address and clock are needed. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > .../bindings/usb/fsl,imx8mp-dwc3.yaml | 31 ++++++++++++++++--- > 1 file changed, 27 insertions(+), 4 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml b/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml index 974032b1fda0..01ab0f922ae8 100644 --- a/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml @@ -15,9 +15,9 @@ properties: const: fsl,imx8mp-dwc3 reg: - maxItems: 1 - description: Address and length of the register set for the wrapper of - dwc3 core on the SOC. + items: + - description: Address and length of the register set for HSIO Block Control + - description: Address and length of the register set for the wrapper of dwc3 core on the SOC. "#address-cells": enum: [ 1, 2 ] @@ -49,6 +49,28 @@ properties: - const: hsio - const: suspend + fsl,permanently-attached: + type: boolean + description: + Indicates if the device atached to a downstream port is + permanently attached. + + fsl,disable-port-power-control: + type: boolean + description: + Indicates whether the host controller implementation includes port + power control. Defines Bit 3 in capability register (HCCPARAMS). + + fsl,over-current-active-low: + type: boolean + description: + Over current signal polarity is active low. + + fsl,power-active-low: + type: boolean + description: + Power pad (PWR) polarity is active low. + # Required child node: patternProperties: @@ -74,7 +96,8 @@ examples: #include <dt-bindings/interrupt-controller/arm-gic.h> usb3_0: usb@32f10100 { compatible = "fsl,imx8mp-dwc3"; - reg = <0x32f10100 0x8>; + reg = <0x32f10100 0x8>, + <0x381f0000 0x20>; clocks = <&clk IMX8MP_CLK_HSIO_ROOT>, <&clk IMX8MP_CLK_USB_ROOT>; clock-names = "hsio", "suspend";
This adds bindings for features in the USB glue block. They allow setting polarity of PWR and OC as well as disabling port power control. Also permanently attached can be annotated as well. Additional IO address and clock are needed. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- .../bindings/usb/fsl,imx8mp-dwc3.yaml | 31 ++++++++++++++++--- 1 file changed, 27 insertions(+), 4 deletions(-)