Message ID | 20211224163344.54177-1-david@ixit.cz |
---|---|
State | Rejected, archived |
Headers | show |
Series | [1/2] dt-bindings: spmi: spmi can have at least up to 5 registers | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
On Fri, 24 Dec 2021 17:33:43 +0100, David Heidelberg wrote: > Since Qualcomm SPMI Controller (PMIC Arbiter) can have 5, > bump reg up to maxItems 5. > > Fixes warning as: > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: spmi@c440000: reg: [[0, 205783040, 0, 4352], [0, 207618048, 0, 33554432], [0, 241172480, 0, 1048576], [0, 242221056, 0, 655360], [0, 205561856, 0, 155648]] is too long > From schema: Documentation/devicetree/bindings/spmi/spmi.yaml > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > Documentation/devicetree/bindings/spmi/spmi.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1573074 spmi@c440000: #address-cells:0:0: 2 was expected arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml spmi@c440000: #size-cells:0:0: 0 was expected arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml
On Fri, Dec 24, 2021 at 05:33:43PM +0100, David Heidelberg wrote: > Since Qualcomm SPMI Controller (PMIC Arbiter) can have 5, > bump reg up to maxItems 5. Already has a fix in linux-next. > > Fixes warning as: > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: spmi@c440000: reg: [[0, 205783040, 0, 4352], [0, 207618048, 0, 33554432], [0, 241172480, 0, 1048576], [0, 242221056, 0, 655360], [0, 205561856, 0, 155648]] is too long > From schema: Documentation/devicetree/bindings/spmi/spmi.yaml > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > Documentation/devicetree/bindings/spmi/spmi.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spmi/spmi.yaml b/Documentation/devicetree/bindings/spmi/spmi.yaml > index 1d243faef2f8..d7d9345d7c60 100644 > --- a/Documentation/devicetree/bindings/spmi/spmi.yaml > +++ b/Documentation/devicetree/bindings/spmi/spmi.yaml > @@ -25,7 +25,8 @@ properties: > pattern: "^spmi@.*" > > reg: > - maxItems: 1 > + minItems: 1 > + maxItems: 5 > > "#address-cells": > const: 2 > -- > 2.34.1 > >
diff --git a/Documentation/devicetree/bindings/spmi/spmi.yaml b/Documentation/devicetree/bindings/spmi/spmi.yaml index 1d243faef2f8..d7d9345d7c60 100644 --- a/Documentation/devicetree/bindings/spmi/spmi.yaml +++ b/Documentation/devicetree/bindings/spmi/spmi.yaml @@ -25,7 +25,8 @@ properties: pattern: "^spmi@.*" reg: - maxItems: 1 + minItems: 1 + maxItems: 5 "#address-cells": const: 2
Since Qualcomm SPMI Controller (PMIC Arbiter) can have 5, bump reg up to maxItems 5. Fixes warning as: arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: spmi@c440000: reg: [[0, 205783040, 0, 4352], [0, 207618048, 0, 33554432], [0, 241172480, 0, 1048576], [0, 242221056, 0, 655360], [0, 205561856, 0, 155648]] is too long From schema: Documentation/devicetree/bindings/spmi/spmi.yaml Signed-off-by: David Heidelberg <david@ixit.cz> --- Documentation/devicetree/bindings/spmi/spmi.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)