| Message ID | 20211213072355.4079568-4-hsinyi@chromium.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 13 Dec 2021 15:23:55 +0800, Hsin-Yi Wang wrote: > Makomo is known as Lenovo 100e Gen 2 Chromebook. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > .../devicetree/bindings/arm/mediatek.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/mediatek.yaml: properties:compatible:oneOf:31:items: 'oneOf' conditional failed, one must be fixed: [{'enum': [{'const': 'google,makomo-rev4-sku0'}, {'const': 'google,makomo-rev5-sku0'}, {'const': 'google,makomo'}, {'const': 'mediatek,mt8183'}]}] is not of type 'object' {'const': 'google,makomo-rev4-sku0'} is not of type 'string' {'const': 'google,makomo-rev5-sku0'} is not of type 'string' {'const': 'google,makomo'} is not of type 'string' {'const': 'mediatek,mt8183'} is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/mediatek.yaml: properties:compatible:oneOf:32:items: 'oneOf' conditional failed, one must be fixed: [{'enum': [{'const': 'google,makomo-rev4-sku1'}, {'const': 'google,makomo-rev5-sku1'}, {'const': 'google,makomo'}, {'const': 'mediatek,mt8183'}]}] is not of type 'object' {'const': 'google,makomo-rev4-sku1'} is not of type 'string' {'const': 'google,makomo-rev5-sku1'} is not of type 'string' {'const': 'google,makomo'} is not of type 'string' {'const': 'mediatek,mt8183'} is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/mediatek.yaml: ignoring, error in schema: properties: compatible: oneOf: 31: items warning: no schema found in file: ./Documentation/devicetree/bindings/arm/mediatek.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1567163 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index 75bb06d1802a08..49e008faaa68a6 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -191,6 +191,20 @@ properties: - google,kodama-sku32 - const: google,kodama - const: mediatek,mt8183 + - description: Google Makomo (Lenovo 100e Gen 2) + items: + - enum: + - const: google,makomo-rev4-sku0 + - const: google,makomo-rev5-sku0 + - const: google,makomo + - const: mediatek,mt8183 + - description: Google Makomo (Lenovo 100e Gen 2) + items: + - enum: + - const: google,makomo-rev4-sku1 + - const: google,makomo-rev5-sku1 + - const: google,makomo + - const: mediatek,mt8183 - description: Google Willow (Acer Chromebook 311 C722/C722T) items: - enum:
Makomo is known as Lenovo 100e Gen 2 Chromebook. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- .../devicetree/bindings/arm/mediatek.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)