| Message ID | 20211210221033.912430-5-cmirabil@redhat.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, 10 Dec 2021 17:10:31 -0500, Charles Mirabile wrote: > This patch adds the device tree binding > for the Sense HAT in yaml form. > > Signed-off-by: Charles Mirabile <cmirabil@redhat.com> > Co-developed-by: Mwesigwa Guma <mguma@redhat.com> > Signed-off-by: Mwesigwa Guma <mguma@redhat.com> > Co-developed-by: Joel Savitz <jsavitz@redhat.com> > Signed-off-by: Joel Savitz <jsavitz@redhat.com> > --- > .../bindings/mfd/raspberrypi,sensehat.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml:2:1: [error] missing document start "---" (document-start) dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml: properties:interrupt-parent: False schema does not allow {'items': [{'description': 'gpio pin bank for interrupt pin'}]} from schema $id: http://devicetree.org/meta-schemas/interrupts.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml: ignoring, error in schema: properties: interrupt-parent warning: no schema found in file: ./Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.example.dt.yaml:0:0: /example-0/i2c/sensehat@46: failed to match any schema with compatible: ['raspberrypi,sensehat'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1566669 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Sat, Dec 11, 2021 at 01:59:31PM -0600, Rob Herring wrote: > On Fri, 10 Dec 2021 17:10:31 -0500, Charles Mirabile wrote: > > This patch adds the device tree binding > > for the Sense HAT in yaml form. > > > > Signed-off-by: Charles Mirabile <cmirabil@redhat.com> > > Co-developed-by: Mwesigwa Guma <mguma@redhat.com> > > Signed-off-by: Mwesigwa Guma <mguma@redhat.com> > > Co-developed-by: Joel Savitz <jsavitz@redhat.com> > > Signed-off-by: Joel Savitz <jsavitz@redhat.com> > > --- > > .../bindings/mfd/raspberrypi,sensehat.yaml | 54 +++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml:2:1: [error] missing document start "---" (document-start) > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml: properties:interrupt-parent: False schema does not allow {'items': [{'description': 'gpio pin bank for interrupt pin'}]} > from schema $id: http://devicetree.org/meta-schemas/interrupts.yaml# > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml: ignoring, error in schema: properties: interrupt-parent > warning: no schema found in file: ./Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml > Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.example.dt.yaml:0:0: /example-0/i2c/sensehat@46: failed to match any schema with compatible: ['raspberrypi,sensehat'] 'interrupt-parent' is not needed as it is always valid or could be in a parent node.
diff --git a/Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml b/Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml new file mode 100644 index 000000000000..a57d1face50e --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +$id: http://devicetree.org/schemas/mfd/raspberrypi,sensehat.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Raspberry Pi Sensehat + +maintainers: + - Charles Mirabile <cmirabil@redhat.com> + - Mwesigwa Guma <mguma@redhat.com> + - Joel Savitz <jsavitz@redhat.com> + +description: + The Raspberry Pi Sensehat is an addon board originally developed + for the Raspberry Pi that has a joystick and an 8x8 RGB LED display + as well as several environmental sensors. It connects via i2c and + a gpio for irq. + +properties: + compatible: + const: raspberrypi,sensehat + + reg: + items: + - description: i2c bus address + + interrupts: + items: + - description: pin number for joystick interrupt + + interrupt-parent: + items: + - description: gpio pin bank for interrupt pin + +required: + - compatible + - reg + - interrupts + - interrupt-parent + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + sensehat@46 { + compatible = "raspberrypi,sensehat"; + reg = <0x46>; + interrupts = <23 GPIO_ACTIVE_HIGH>; + interrupt-parent = <&gpio>; + }; + };