| Message ID | 20211210013129.811-7-biao.huang@mediatek.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | MediaTek Ethernet Patches on MT8195 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, 10 Dec 2021 09:31:29 +0800, Biao Huang wrote: > Add binding document for the ethernet on mt8195. > > Signed-off-by: Biao Huang <biao.huang@mediatek.com> > --- > .../bindings/net/mediatek-dwmac.yaml | 86 +++++++++++++++---- > 1 file changed, 70 insertions(+), 16 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1566168 ethernet@1101c000: clock-names: ['axi', 'apb', 'mac_main', 'ptp_ref'] is too short arch/arm64/boot/dts/mediatek/mt2712-evb.dt.yaml ethernet@1101c000: clocks: [[27, 34], [27, 37], [6, 154], [6, 155]] is too short arch/arm64/boot/dts/mediatek/mt2712-evb.dt.yaml ethernet@1101c000: compatible: ['mediatek,mt2712-gmac'] does not contain items matching the given schema arch/arm64/boot/dts/mediatek/mt2712-evb.dt.yaml ethernet@1101c000: compatible: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/mediatek/mt2712-evb.dt.yaml ethernet@1101c000: Unevaluated properties are not allowed ('compatible', 'reg', 'interrupts', 'interrupt-names', 'mac-address', 'clock-names', 'clocks', 'assigned-clocks', 'assigned-clock-parents', 'power-domains', 'snps,axi-config', 'snps,mtl-rx-config', 'snps,mtl-tx-config', 'snps,txpbl', 'snps,rxpbl', 'clk_csr', 'phy-mode', 'phy-handle', 'snps,reset-gpio', 'mdio' were unexpected) arch/arm64/boot/dts/mediatek/mt2712-evb.dt.yaml
On Fri, Dec 10, 2021 at 09:31:29AM +0800, Biao Huang wrote: > Add binding document for the ethernet on mt8195. > > Signed-off-by: Biao Huang <biao.huang@mediatek.com> > --- > .../bindings/net/mediatek-dwmac.yaml | 86 +++++++++++++++---- > 1 file changed, 70 insertions(+), 16 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > index 9207266a6e69..fb04166404d8 100644 > --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > @@ -19,11 +19,67 @@ select: > contains: > enum: > - mediatek,mt2712-gmac > + - mediatek,mt8195-gmac > required: > - compatible > > allOf: > - $ref: "snps,dwmac.yaml#" > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt2712-gmac > + > + then: > + properties: > + clocks: > + minItems: 5 > + items: > + - description: AXI clock > + - description: APB clock > + - description: MAC Main clock > + - description: PTP clock > + - description: RMII reference clock provided by MAC > + > + clock-names: > + minItems: 5 > + items: > + - const: axi > + - const: apb > + - const: mac_main > + - const: ptp_ref > + - const: rmii_internal > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8195-gmac > + > + then: > + properties: > + clocks: > + minItems: 6 > + items: > + - description: AXI clock > + - description: APB clock > + - description: MAC clock gate Add new clocks on to the end of existing clocks. That will simplify the binding as here you will just need 'minItems: 6'. > + - description: MAC Main clock > + - description: PTP clock > + - description: RMII reference clock provided by MAC > + > + clock-names: > + minItems: 6 > + items: > + - const: axi > + - const: apb > + - const: mac_cg > + - const: mac_main > + - const: ptp_ref > + - const: rmii_internal > > properties: > compatible: > @@ -32,22 +88,10 @@ properties: > - enum: > - mediatek,mt2712-gmac > - const: snps,dwmac-4.20a > - > - clocks: > - items: > - - description: AXI clock > - - description: APB clock > - - description: MAC Main clock > - - description: PTP clock > - - description: RMII reference clock provided by MAC > - > - clock-names: > - items: > - - const: axi > - - const: apb > - - const: mac_main > - - const: ptp_ref > - - const: rmii_internal > + - items: > + - enum: > + - mediatek,mt8195-gmac > + - const: snps,dwmac-5.10a > > mediatek,pericfg: > $ref: /schemas/types.yaml#/definitions/phandle > @@ -62,6 +106,8 @@ properties: > or will round down. Range 0~31*170. > For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550, > or will round down. Range 0~31*550. > + For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, > + or will round down. Range 0~31*290. > > mediatek,rx-delay-ps: > description: > @@ -70,6 +116,8 @@ properties: > or will round down. Range 0~31*170. > For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550, > or will round down. Range 0~31*550. > + For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple > + of 290, or will round down. Range 0~31*290. > > mediatek,rmii-rxc: > type: boolean > @@ -103,6 +151,12 @@ properties: > 3. the inside clock, which be sent to MAC, will be inversed in RMII case when > the reference clock is from MAC. > > + mediatek,mac-wol: > + type: boolean > + description: > + If present, indicates that MAC supports WOL(Wake-On-LAN), and MAC WOL will be enabled. > + Otherwise, PHY WOL is perferred. > + > required: > - compatible > - reg > -- > 2.25.1 > >
Dear Rob, Thanks for your comment~ On Fri, 2021-12-10 at 12:52 -0600, Rob Herring wrote: > On Fri, Dec 10, 2021 at 09:31:29AM +0800, Biao Huang wrote: > > Add binding document for the ethernet on mt8195. > > > > Signed-off-by: Biao Huang <biao.huang@mediatek.com> > > --- > > .../bindings/net/mediatek-dwmac.yaml | 86 > > +++++++++++++++---- > > 1 file changed, 70 insertions(+), 16 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/mediatek- > > dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek- > > dwmac.yaml > > index 9207266a6e69..fb04166404d8 100644 > > --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > @@ -19,11 +19,67 @@ select: > > contains: > > enum: > > - mediatek,mt2712-gmac > > + - mediatek,mt8195-gmac > > required: > > - compatible > > > > allOf: > > - $ref: "snps,dwmac.yaml#" > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - mediatek,mt2712-gmac > > + > > + then: > > + properties: > > + clocks: > > + minItems: 5 > > + items: > > + - description: AXI clock > > + - description: APB clock > > + - description: MAC Main clock > > + - description: PTP clock > > + - description: RMII reference clock provided by MAC > > + > > + clock-names: > > + minItems: 5 > > + items: > > + - const: axi > > + - const: apb > > + - const: mac_main > > + - const: ptp_ref > > + - const: rmii_internal > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - mediatek,mt8195-gmac > > + > > + then: > > + properties: > > + clocks: > > + minItems: 6 > > + items: > > + - description: AXI clock > > + - description: APB clock > > + - description: MAC clock gate > > Add new clocks on to the end of existing clocks. That will simplify > the > binding as here you will just need 'minItems: 6'. The "rmii_internal" clock is a special one we put it to the end on purpose, and will turn it on/off in driver according to whether phy_mode is rmii or not. So the "mac_cg" clock, which is new for mt8195, and not used in mt2712, can't put it to the end for simplicity. Can we just keep it this way? or other suggestions? [v3 reply] http://lists.infradead.org/pipermail/linux-mediatek/2021-November/031951.html > > + - description: MAC Main clock > > + - description: PTP clock > > + - description: RMII reference clock provided by MAC > > + > > + clock-names: > > + minItems: 6 > > + items: > > + - const: axi > > + - const: apb > > + - const: mac_cg > > + - const: mac_main > > + - const: ptp_ref > > + - const: rmii_internal > > > > properties: > > compatible: > > @@ -32,22 +88,10 @@ properties: > > - enum: > > - mediatek,mt2712-gmac > > - const: snps,dwmac-4.20a > > - > > - clocks: > > - items: > > - - description: AXI clock > > - - description: APB clock > > - - description: MAC Main clock > > - - description: PTP clock > > - - description: RMII reference clock provided by MAC > > - > > - clock-names: > > - items: > > - - const: axi > > - - const: apb > > - - const: mac_main > > - - const: ptp_ref > > - - const: rmii_internal > > + - items: > > + - enum: > > + - mediatek,mt8195-gmac > > + - const: snps,dwmac-5.10a > > > > mediatek,pericfg: > > $ref: /schemas/types.yaml#/definitions/phandle > > @@ -62,6 +106,8 @@ properties: > > or will round down. Range 0~31*170. > > For MT2712 RMII/MII interface, Allowed value need to be a > > multiple of 550, > > or will round down. Range 0~31*550. > > + For MT8195 RGMII/RMII/MII interface, Allowed value need to > > be a multiple of 290, > > + or will round down. Range 0~31*290. > > > > mediatek,rx-delay-ps: > > description: > > @@ -70,6 +116,8 @@ properties: > > or will round down. Range 0~31*170. > > For MT2712 RMII/MII interface, Allowed value need to be a > > multiple of 550, > > or will round down. Range 0~31*550. > > + For MT8195 RGMII/RMII/MII interface, Allowed value need to > > be a multiple > > + of 290, or will round down. Range 0~31*290. > > > > mediatek,rmii-rxc: > > type: boolean > > @@ -103,6 +151,12 @@ properties: > > 3. the inside clock, which be sent to MAC, will be inversed > > in RMII case when > > the reference clock is from MAC. > > > > + mediatek,mac-wol: > > + type: boolean > > + description: > > + If present, indicates that MAC supports WOL(Wake-On-LAN), > > and MAC WOL will be enabled. > > + Otherwise, PHY WOL is perferred. > > + > > required: > > - compatible > > - reg > > -- > > 2.25.1 > > > >
diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml index 9207266a6e69..fb04166404d8 100644 --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml @@ -19,11 +19,67 @@ select: contains: enum: - mediatek,mt2712-gmac + - mediatek,mt8195-gmac required: - compatible allOf: - $ref: "snps,dwmac.yaml#" + - if: + properties: + compatible: + contains: + enum: + - mediatek,mt2712-gmac + + then: + properties: + clocks: + minItems: 5 + items: + - description: AXI clock + - description: APB clock + - description: MAC Main clock + - description: PTP clock + - description: RMII reference clock provided by MAC + + clock-names: + minItems: 5 + items: + - const: axi + - const: apb + - const: mac_main + - const: ptp_ref + - const: rmii_internal + + - if: + properties: + compatible: + contains: + enum: + - mediatek,mt8195-gmac + + then: + properties: + clocks: + minItems: 6 + items: + - description: AXI clock + - description: APB clock + - description: MAC clock gate + - description: MAC Main clock + - description: PTP clock + - description: RMII reference clock provided by MAC + + clock-names: + minItems: 6 + items: + - const: axi + - const: apb + - const: mac_cg + - const: mac_main + - const: ptp_ref + - const: rmii_internal properties: compatible: @@ -32,22 +88,10 @@ properties: - enum: - mediatek,mt2712-gmac - const: snps,dwmac-4.20a - - clocks: - items: - - description: AXI clock - - description: APB clock - - description: MAC Main clock - - description: PTP clock - - description: RMII reference clock provided by MAC - - clock-names: - items: - - const: axi - - const: apb - - const: mac_main - - const: ptp_ref - - const: rmii_internal + - items: + - enum: + - mediatek,mt8195-gmac + - const: snps,dwmac-5.10a mediatek,pericfg: $ref: /schemas/types.yaml#/definitions/phandle @@ -62,6 +106,8 @@ properties: or will round down. Range 0~31*170. For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550, or will round down. Range 0~31*550. + For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, + or will round down. Range 0~31*290. mediatek,rx-delay-ps: description: @@ -70,6 +116,8 @@ properties: or will round down. Range 0~31*170. For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550, or will round down. Range 0~31*550. + For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple + of 290, or will round down. Range 0~31*290. mediatek,rmii-rxc: type: boolean @@ -103,6 +151,12 @@ properties: 3. the inside clock, which be sent to MAC, will be inversed in RMII case when the reference clock is from MAC. + mediatek,mac-wol: + type: boolean + description: + If present, indicates that MAC supports WOL(Wake-On-LAN), and MAC WOL will be enabled. + Otherwise, PHY WOL is perferred. + required: - compatible - reg
Add binding document for the ethernet on mt8195. Signed-off-by: Biao Huang <biao.huang@mediatek.com> --- .../bindings/net/mediatek-dwmac.yaml | 86 +++++++++++++++---- 1 file changed, 70 insertions(+), 16 deletions(-)