diff mbox series

[v2,1/2] yaml: Add dm9051 SPI network yaml file

Message ID 20211209100702.5609-2-josright123@gmail.com
State Changes Requested, archived
Headers show
Series ADD DM9051 ETHERNET DRIVER | expand

Checks

Context Check Description
robh/dtbs-check success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema fail build log
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success
robh/dtbs-check success
robh/dt-meta-schema success
robh/checkpatch success
robh/dtbs-check success
robh/dt-meta-schema success

Commit Message

Joseph CHAMG Dec. 9, 2021, 10:07 a.m. UTC 
For support davicom dm9051 device tree config

Signed-off-by: JosephCHANG <josright123@gmail.com>
---
 .../bindings/net/davicom,dm9051.yaml          | 62 +++++++++++++++++++
 1 file changed, 62 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/davicom,dm9051.yaml

Comments

Rob Herring (Arm) Dec. 9, 2021, 5:10 p.m. UTC | #1 
On Thu, 09 Dec 2021 18:07:01 +0800, JosephCHANG wrote:
> For support davicom dm9051 device tree config
> 
> Signed-off-by: JosephCHANG <josright123@gmail.com>
> ---
>  .../bindings/net/davicom,dm9051.yaml          | 62 +++++++++++++++++++
>  1 file changed, 62 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/davicom,dm9051.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/net/davicom,dm9051.example.dts:29.34-35 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:373: Documentation/devicetree/bindings/net/davicom,dm9051.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1413: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1565710

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/davicom,dm9051.yaml b/Documentation/devicetree/bindings/net/davicom,dm9051.yaml
new file mode 100644
index 000000000000..5e9ce2920bd3
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/davicom,dm9051.yaml
@@ -0,0 +1,62 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/davicom,dm9051.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Davicom DM9051 SPI Ethernet Controller
+
+maintainers:
+  - Joseph CHANG <josright123@gmail.com>
+
+description: |
+  The DM9051 is a fully integrated and cost-effective low pin count single
+  chip Fast Ethernet controller with a Serial Peripheral Interface (SPI).
+
+allOf:
+  - $ref: ethernet-controller.yaml#
+
+properties:
+  compatible:
+    const: davicom,dm9051
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 45000000
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - spi-max-frequency
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    /* for Raspberry Pi with pin control stuff for GPIO irq */
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        dm9051@0 {
+            compatible = "davicom,dm9051";
+            reg = <0>; /* spi chip select */
+            pinctrl-names = "default";
+            pinctrl-0 = <&eth_int_pins>;
+            interrupt-parent = <&gpio>;
+            interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
+            spi-max-frequency = <31200000>;
+        };
+    };
+    gpio {
+        eth_int_pins {
+            brcm,pins = <26>;
+            brcm,function = <0>; /* in */
+            brcm,pull = <0>; /* none */
+        };
+    };