| Message ID | 1637329568-31756-1-git-send-email-manish.narani@xilinx.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: usb: dwc3-xilinx: Convert USB DWC3 bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 119 lines checked |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On Fri, 19 Nov 2021 19:16:08 +0530, Manish Narani wrote: > Convert USB DWC3 bindings to DT schema format using json-schema. > > Signed-off-by: Manish Narani <manish.narani@xilinx.com> > --- > .../devicetree/bindings/usb/dwc3-xilinx.txt | 56 ---------- > .../devicetree/bindings/usb/dwc3-xilinx.yaml | 119 +++++++++++++++++++++ > 2 files changed, 119 insertions(+), 56 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/dwc3-xilinx.txt > create mode 100644 Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1557119 usb@ff9d0000: 'phy-names', 'phys' do not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml usb@ff9d0000: usb@fe200000:interrupt-names: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-smk-k26-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml usb@ff9e0000: 'phy-names', 'phys' do not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml usb@ff9e0000: usb@fe300000:interrupt-names: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-smk-k26-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml
On Fri, Nov 19, 2021 at 10:58:22AM -0600, Rob Herring wrote: > On Fri, 19 Nov 2021 19:16:08 +0530, Manish Narani wrote: > > Convert USB DWC3 bindings to DT schema format using json-schema. > > > > Signed-off-by: Manish Narani <manish.narani@xilinx.com> > > --- > > .../devicetree/bindings/usb/dwc3-xilinx.txt | 56 ---------- > > .../devicetree/bindings/usb/dwc3-xilinx.yaml | 119 +++++++++++++++++++++ > > 2 files changed, 119 insertions(+), 56 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/usb/dwc3-xilinx.txt > > create mode 100644 Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1557119 > > > usb@ff9d0000: 'phy-names', 'phys' do not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+' > arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.1.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml Looks like the schema is missing some properties. > > usb@ff9d0000: usb@fe200000:interrupt-names: 'oneOf' conditional failed, one must be fixed: > arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-smk-k26-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.1.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml > > usb@ff9e0000: 'phy-names', 'phys' do not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+' > arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml > > usb@ff9e0000: usb@fe300000:interrupt-names: 'oneOf' conditional failed, one must be fixed: > arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-smk-k26-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.1.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml > arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml > >
diff --git a/Documentation/devicetree/bindings/usb/dwc3-xilinx.txt b/Documentation/devicetree/bindings/usb/dwc3-xilinx.txt deleted file mode 100644 index 04813a4..00000000 --- a/Documentation/devicetree/bindings/usb/dwc3-xilinx.txt +++ /dev/null @@ -1,56 +0,0 @@ -Xilinx SuperSpeed DWC3 USB SoC controller - -Required properties: -- compatible: May contain "xlnx,zynqmp-dwc3" or "xlnx,versal-dwc3" -- reg: Base address and length of the register control block -- clocks: A list of phandles for the clocks listed in clock-names -- clock-names: Should contain the following: - "bus_clk" Master/Core clock, have to be >= 125 MHz for SS - operation and >= 60MHz for HS operation - - "ref_clk" Clock source to core during PHY power down -- resets: A list of phandles for resets listed in reset-names -- reset-names: - "usb_crst" USB core reset - "usb_hibrst" USB hibernation reset - "usb_apbrst" USB APB reset - -Required child node: -A child node must exist to represent the core DWC3 IP block. The name of -the node is not important. The content of the node is defined in dwc3.txt. - -Optional properties for snps,dwc3: -- dma-coherent: Enable this flag if CCI is enabled in design. Adding this - flag configures Global SoC bus Configuration Register and - Xilinx USB 3.0 IP - USB coherency register to enable CCI. -- interrupt-names: Should contain the following: - "dwc_usb3" USB gadget mode interrupts - "otg" USB OTG mode interrupts - "hiber" USB hibernation interrupts - -Example device node: - - usb@0 { - #address-cells = <0x2>; - #size-cells = <0x1>; - compatible = "xlnx,zynqmp-dwc3"; - reg = <0x0 0xff9d0000 0x0 0x100>; - clock-names = "bus_clk", "ref_clk"; - clocks = <&clk125>, <&clk125>; - resets = <&zynqmp_reset ZYNQMP_RESET_USB1_CORERESET>, - <&zynqmp_reset ZYNQMP_RESET_USB1_HIBERRESET>, - <&zynqmp_reset ZYNQMP_RESET_USB1_APB>; - reset-names = "usb_crst", "usb_hibrst", "usb_apbrst"; - ranges; - - dwc3@fe200000 { - compatible = "snps,dwc3"; - reg = <0x0 0xfe200000 0x40000>; - interrupt-names = "dwc_usb3", "otg", "hiber"; - interrupts = <0 65 4>, <0 69 4>, <0 75 4>; - phys = <&psgtr 2 PHY_TYPE_USB3 0 2>; - phy-names = "usb3-phy"; - dr_mode = "host"; - dma-coherent; - }; - }; diff --git a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml new file mode 100644 index 00000000..193c69a6 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml @@ -0,0 +1,119 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/dwc3-xilinx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xilinx SuperSpeed DWC3 USB SoC controller + +maintainers: + - Manish Narani <manish.narani@xilinx.com> + +properties: + compatible: + items: + - enum: + - xlnx,zynqmp-dwc3 + - xlnx,versal-dwc3 + reg: + maxItems: 1 + + "#address-cells": + enum: [ 1, 2 ] + + "#size-cells": + enum: [ 1, 2 ] + + ranges: true + + power-domains: + description: specifies a phandle to PM domain provider node + maxItems: 1 + + clocks: + description: + A list of phandle and clock-specifier pairs for the clocks + listed in clock-names. + items: + - description: Master/Core clock, has to be >= 125 MHz + for SS operation and >= 60MHz for HS operation. + - description: Clock source to core during PHY power down. + + clock-names: + items: + - const: bus_clk + - const: ref_clk + + resets: + description: + A list of phandles for resets listed in reset-names. + + items: + - description: USB core reset + - description: USB hibernation reset + - description: USB APB reset + + reset-names: + items: + - const: usb_crst + - const: usb_hibrst + - const: usb_apbrst + +# Required child node: + +patternProperties: + "^usb@[0-9a-f]+$": + $ref: snps,dwc3.yaml# + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + - ranges + - power-domains + - clocks + - clock-names + - resets + - reset-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/dma/xlnx-zynqmp-dpdma.h> + #include <dt-bindings/power/xlnx-zynqmp-power.h> + #include <dt-bindings/reset/xlnx-zynqmp-resets.h> + #include <dt-bindings/clock/xlnx-zynqmp-clk.h> + #include <dt-bindings/reset/xlnx-zynqmp-resets.h> + #include <dt-bindings/phy/phy.h> + axi { + #address-cells = <2>; + #size-cells = <2>; + + usb@0 { + #address-cells = <0x2>; + #size-cells = <0x2>; + compatible = "xlnx,zynqmp-dwc3"; + reg = <0x0 0xff9d0000 0x0 0x100>; + clocks = <&zynqmp_clk USB0_BUS_REF>, <&zynqmp_clk USB3_DUAL_REF>; + clock-names = "bus_clk", "ref_clk"; + power-domains = <&zynqmp_firmware PD_USB_0>; + resets = <&zynqmp_reset ZYNQMP_RESET_USB1_CORERESET>, + <&zynqmp_reset ZYNQMP_RESET_USB1_HIBERRESET>, + <&zynqmp_reset ZYNQMP_RESET_USB1_APB>; + reset-names = "usb_crst", "usb_hibrst", "usb_apbrst"; + ranges; + + usb@fe200000 { + compatible = "snps,dwc3"; + reg = <0x0 0xfe200000 0x0 0x40000>; + interrupt-names = "dwc_usb3"; + interrupts = <0 65 4>; + phys = <&psgtr 2 PHY_TYPE_USB3 0 2>; + phy-names = "usb3-phy"; + dr_mode = "host"; + dma-coherent; + }; + }; + };
Convert USB DWC3 bindings to DT schema format using json-schema. Signed-off-by: Manish Narani <manish.narani@xilinx.com> --- .../devicetree/bindings/usb/dwc3-xilinx.txt | 56 ---------- .../devicetree/bindings/usb/dwc3-xilinx.yaml | 119 +++++++++++++++++++++ 2 files changed, 119 insertions(+), 56 deletions(-) delete mode 100644 Documentation/devicetree/bindings/usb/dwc3-xilinx.txt create mode 100644 Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml