| Message ID | 20211023214856.30097-1-alexander.stein@mailbox.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/4] dt-bindings: sound: amlogic: t9015: Add missing AVDD-supply property | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 17 lines checked |
| robh/dt-meta-schema | fail | build log |
On Sat, 23 Oct 2021 23:48:53 +0200, Alexander Stein wrote: > Fixes the schema check warning "audio-controller@32000: 'AVDD-supply' > do not match any of the regexes: 'pinctrl-[0-9]+'" > > Fixes: 5c36abcd2621 ("ASoC: meson: add t9015 internal codec binding documentation") > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > --- > I am aware that adding required properties to bindings is frowned upon. But in > this case it seems acceptable for the following reasons: > * AVDD-supply was used from the very first driver commit > * All DT (g12 and gxl) using t9015 controller provide AVDD-supply > already > But I'm ok to not add it to required properties as well. The driver uses > it nevertheless though. > > Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/amlogic,t9015.example.dt.yaml: audio-controller@32000: 'AVDD-supply' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1545246 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 23/10/2021 23:48, Alexander Stein wrote: > Starting with commit 94274f20f6bf ("dt-bindings: opp: Convert to DT > schema") the opp node name has a mandatory pattern. This change > fixes the dtbs_check warning: > gpu-opp-table: $nodename:0: 'gpu-opp-table' does not match > '^opp-table(-[a-z0-9]+)?$' > Put the 'gpu' part at the end to match the pattern. > > Fixes: 916a0edc43f0 ("arm64: dts: amlogic: meson-g12: add the Mali OPP table and use DVFS") > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > --- > Same as with patch 2/4 about the 'Fixes' tag: At the time when > gpu-opp-table was added there was no schema present. So there was no bug at > the time of writing. I'm ok either way. > > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > index ff987e7ccff2..517519e6e87f 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > @@ -58,7 +58,7 @@ efuse: efuse { > secure-monitor = <&sm>; > }; > > - gpu_opp_table: gpu-opp-table { > + gpu_opp_table: opp-table-gpu { > compatible = "operating-points-v2"; > > opp-124999998 { > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
On 23/10/2021 23:48, Alexander Stein wrote: > Fix the schema warning: "spi-flash@0: $nodename:0: 'spi-flash@0' does > not match '^flash(@.*)?$'" from jedec,spi-nor.yaml > > Fixes: a084eaf3096c ("arm64: dts: meson-g12b-odroid-n2: add SPIFC controller node") > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > --- > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > index 6e9ff5076b38..9c05c83453f5 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > @@ -611,7 +611,7 @@ &spifc { > pinctrl-0 = <&nor_pins>; > pinctrl-names = "default"; > > - mx25u64: spi-flash@0 { > + mx25u64: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > compatible = "mxicy,mx25u6435f", "jedec,spi-nor"; > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
On Sat, Oct 23, 2021 at 11:48:53PM +0200, Alexander Stein wrote: > Fixes the schema check warning "audio-controller@32000: 'AVDD-supply' > do not match any of the regexes: 'pinctrl-[0-9]+'" Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On Sat 23 Oct 2021 at 23:48, Alexander Stein <alexander.stein@mailbox.org> wrote: > Fixes the schema check warning "audio-controller@32000: 'AVDD-supply' > do not match any of the regexes: 'pinctrl-[0-9]+'" > > Fixes: 5c36abcd2621 ("ASoC: meson: add t9015 internal codec binding documentation") > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> Hey Alexander, First, thanks for picking this up. I think Rob's automated reply is because you forgot to update the example (if the property is required, it should be there) Also, I believe this change could have been sent separately, to Marc (instead of Cc) and with the "ASoC" prefix. With this changed Reviewed-by: Jerome Brunet <jbrunet@baylibre.com> > --- > I am aware that adding required properties to bindings is frowned upon. But in > this case it seems acceptable for the following reasons: > * AVDD-supply was used from the very first driver commit > * All DT (g12 and gxl) using t9015 controller provide AVDD-supply > already > But I'm ok to not add it to required properties as well. The driver uses > it nevertheless though. > > Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml > index c7613ea728d4..5f4e25ab5af6 100644 > --- a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml > +++ b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml > @@ -34,6 +34,10 @@ properties: > resets: > maxItems: 1 > > + AVDD-supply: > + description: > + Analogue power supply. > + > required: > - "#sound-dai-cells" > - compatible > @@ -41,6 +45,7 @@ required: > - clocks > - clock-names > - resets > + - AVDD-supply > > additionalProperties: false
Hi, On 23/10/2021 23:48, Alexander Stein wrote: > This node is currently at /soc/thermal-zones, but the later introduced > bindings in commit 1202a442a31f ("dt-bindings: thermal: Add yaml bindings > for thermal zones") put this at /thermal-zones. > Fix dtb_check warning by moving the thermal-zones node to / > > Fixes: e7251ed74ef7 ("arm64: dts: meson: g12: Add minimal thermal zone") > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > --- > I admit I'm a bit unsure about the 'Fixes' tag as at the time when those > thermal-zones were added there was no schema present. So there was no bug at > the time of writing. I'm ok either way. I'm also unsure about it, either you list all commits that must be present for the fix to be applied, or remove it since it's not a bug. Neil > > .../boot/dts/amlogic/meson-g12-common.dtsi | 110 +++++++++--------- > 1 file changed, 55 insertions(+), 55 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > index 00c6f53290d4..ff987e7ccff2 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > @@ -159,61 +159,6 @@ &clkc CLKID_PCIE_COMB > status = "disabled"; > }; > > - thermal-zones { > - cpu_thermal: cpu-thermal { > - polling-delay = <1000>; > - polling-delay-passive = <100>; > - thermal-sensors = <&cpu_temp>; > - > - trips { > - cpu_passive: cpu-passive { > - temperature = <85000>; /* millicelsius */ > - hysteresis = <2000>; /* millicelsius */ > - type = "passive"; > - }; > - > - cpu_hot: cpu-hot { > - temperature = <95000>; /* millicelsius */ > - hysteresis = <2000>; /* millicelsius */ > - type = "hot"; > - }; > - > - cpu_critical: cpu-critical { > - temperature = <110000>; /* millicelsius */ > - hysteresis = <2000>; /* millicelsius */ > - type = "critical"; > - }; > - }; > - }; > - > - ddr_thermal: ddr-thermal { > - polling-delay = <1000>; > - polling-delay-passive = <100>; > - thermal-sensors = <&ddr_temp>; > - > - trips { > - ddr_passive: ddr-passive { > - temperature = <85000>; /* millicelsius */ > - hysteresis = <2000>; /* millicelsius */ > - type = "passive"; > - }; > - > - ddr_critical: ddr-critical { > - temperature = <110000>; /* millicelsius */ > - hysteresis = <2000>; /* millicelsius */ > - type = "critical"; > - }; > - }; > - > - cooling-maps { > - map { > - trip = <&ddr_passive>; > - cooling-device = <&mali THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > - }; > - }; > - }; > - }; > - > ethmac: ethernet@ff3f0000 { > compatible = "amlogic,meson-g12a-dwmac", > "snps,dwmac-3.70a", > @@ -2415,6 +2360,61 @@ mali: gpu@ffe40000 { > }; > }; > > + thermal-zones { > + cpu_thermal: cpu-thermal { > + polling-delay = <1000>; > + polling-delay-passive = <100>; > + thermal-sensors = <&cpu_temp>; > + > + trips { > + cpu_passive: cpu-passive { > + temperature = <85000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "passive"; > + }; > + > + cpu_hot: cpu-hot { > + temperature = <95000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "hot"; > + }; > + > + cpu_critical: cpu-critical { > + temperature = <110000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "critical"; > + }; > + }; > + }; > + > + ddr_thermal: ddr-thermal { > + polling-delay = <1000>; > + polling-delay-passive = <100>; > + thermal-sensors = <&ddr_temp>; > + > + trips { > + ddr_passive: ddr-passive { > + temperature = <85000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "passive"; > + }; > + > + ddr_critical: ddr-critical { > + temperature = <110000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + map { > + trip = <&ddr_passive>; > + cooling-device = <&mali THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + }; > + > timer { > compatible = "arm,armv8-timer"; > interrupts = <GIC_PPI 13 >
Hello, Am Dienstag, 26. Oktober 2021, 09:27:42 CEST schrieb Neil Armstrong: > On 23/10/2021 23:48, Alexander Stein wrote: > > This node is currently at /soc/thermal-zones, but the later introduced > > bindings in commit 1202a442a31f ("dt-bindings: thermal: Add yaml bindings > > for thermal zones") put this at /thermal-zones. > > Fix dtb_check warning by moving the thermal-zones node to / > > > > Fixes: e7251ed74ef7 ("arm64: dts: meson: g12: Add minimal thermal zone") > > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> > > --- > > I admit I'm a bit unsure about the 'Fixes' tag as at the time when those > > thermal-zones were added there was no schema present. So there was no bug > > at the time of writing. I'm ok either way. > > I'm also unsure about it, either you list all commits that must be present > for the fix to be applied, or remove it since it's not a bug. Alright, I'll remove the Fixes tag then and send a v2 with your Reviewed-By for patches 3 & 4. Best regards, Alexander
Hello Jerome, Am Montag, 25. Oktober 2021, 17:53:04 CEST schrieb Jerome Brunet: > On Sat 23 Oct 2021 at 23:48, Alexander Stein <alexander.stein@mailbox.org> wrote: > > Fixes the schema check warning "audio-controller@32000: 'AVDD-supply' > > do not match any of the regexes: 'pinctrl-[0-9]+'" > > > > Fixes: 5c36abcd2621 ("ASoC: meson: add t9015 internal codec binding > > documentation") Signed-off-by: Alexander Stein > > <alexander.stein@mailbox.org> > > Hey Alexander, > > First, thanks for picking this up. > > I think Rob's automated reply is because you forgot to update the > example (if the property is required, it should be there) Thanks for pointing that out, I noticed too that examples are validated as well, nice feature. > Also, I believe this change could have been sent separately, to Marc > (instead of Cc) and with the "ASoC" prefix. > > With this changed > Reviewed-by: Jerome Brunet <jbrunet@baylibre.com> Yeah, I'll split the set during v2. Thanks for the review. Best regards, Alexander > > > --- > > I am aware that adding required properties to bindings is frowned upon. > > But in this case it seems acceptable for the following reasons: > > * AVDD-supply was used from the very first driver commit > > * All DT (g12 and gxl) using t9015 controller provide AVDD-supply > > > > already > > > > But I'm ok to not add it to required properties as well. The driver uses > > it nevertheless though. > > > > Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml > > b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml index > > c7613ea728d4..5f4e25ab5af6 100644 > > --- a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml > > +++ b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml > > > > @@ -34,6 +34,10 @@ properties: > > resets: > > maxItems: 1 > > > > + AVDD-supply: > > + description: > > + Analogue power supply. > > + > > > > required: > > - "#sound-dai-cells" > > - compatible > > > > @@ -41,6 +45,7 @@ required: > > - clocks > > - clock-names > > - resets > > > > + - AVDD-supply > > > > additionalProperties: false
diff --git a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml index c7613ea728d4..5f4e25ab5af6 100644 --- a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml +++ b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml @@ -34,6 +34,10 @@ properties: resets: maxItems: 1 + AVDD-supply: + description: + Analogue power supply. + required: - "#sound-dai-cells" - compatible @@ -41,6 +45,7 @@ required: - clocks - clock-names - resets + - AVDD-supply additionalProperties: false
Fixes the schema check warning "audio-controller@32000: 'AVDD-supply' do not match any of the regexes: 'pinctrl-[0-9]+'" Fixes: 5c36abcd2621 ("ASoC: meson: add t9015 internal codec binding documentation") Signed-off-by: Alexander Stein <alexander.stein@mailbox.org> --- I am aware that adding required properties to bindings is frowned upon. But in this case it seems acceptable for the following reasons: * AVDD-supply was used from the very first driver commit * All DT (g12 and gxl) using t9015 controller provide AVDD-supply already But I'm ok to not add it to required properties as well. The driver uses it nevertheless though. Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 5 +++++ 1 file changed, 5 insertions(+)