| Message ID | 20211014083016.137441-2-y.oudjana@protonmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add support for MSM8996 Pro | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On Thu, 14 Oct 2021 08:31:32 +0000, Yassine Oudjana wrote: > Add CBF clock and reg. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > --- > .../devicetree/bindings/clock/qcom,msm8996-apcc.yaml | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1540828 clock-controller@6400000: clock-names:0: 'pwrcl_pll' was expected arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml clock-controller@6400000: clock-names: ['xo'] is too short arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml clock-controller@6400000: clocks: [[29]] is too short arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml clock-controller@6400000: clocks: [[33]] is too short arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml clock-controller@6400000: clocks: [[36]] is too short arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml clock-controller@6400000: clocks: [[41]] is too short arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml clock-controller@6400000: reg: [[104857600, 589824]] is too short arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml
On Thu, Oct 14 2021 at 18:31:04 +0400, Rob Herring <robh@kernel.org> wrote: > On Thu, 14 Oct 2021 08:31:32 +0000, Yassine Oudjana wrote: >> Add CBF clock and reg. >> >> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> >> --- >> .../devicetree/bindings/clock/qcom,msm8996-apcc.yaml | 10 >> ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for > dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1540828 > > > clock-controller@6400000: clock-names:0: 'pwrcl_pll' was expected > arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml > > clock-controller@6400000: clock-names: ['xo'] is too short > arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml > > clock-controller@6400000: clocks: [[29]] is too short > arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml > > clock-controller@6400000: clocks: [[33]] is too short > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml > > clock-controller@6400000: clocks: [[36]] is too short > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml > > clock-controller@6400000: clocks: [[41]] is too short > arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml > > clock-controller@6400000: reg: [[104857600, 589824]] is too short > arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml > These are old warnings. I wasn't quite sure about those clocks, so I didn't attempt to fix them. Yassine
On Thu, 14 Oct 2021 08:31:32 +0000, Yassine Oudjana wrote: > Add CBF clock and reg. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > --- > .../devicetree/bindings/clock/qcom,msm8996-apcc.yaml | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml b/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml index a20cb10636dd..325f8aef53b2 100644 --- a/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml @@ -10,8 +10,8 @@ maintainers: - Loic Poulain <loic.poulain@linaro.org> description: | - Qualcomm CPU clock controller for MSM8996 CPUs, clock 0 is for Power cluster - and clock 1 is for Perf cluster. + Qualcomm CPU clock controller for MSM8996 CPUs, clock 0 is for Power cluster, + clock 1 is for Perf cluster, and clock 2 is for Coherent bus fabric (CBF). properties: compatible: @@ -19,7 +19,9 @@ properties: - qcom,msm8996-apcc reg: - maxItems: 1 + items: + - description: Cluster clock registers + - description: CBF clock registers '#clock-cells': const: 1 @@ -49,6 +51,6 @@ examples: - | kryocc: clock-controller@6400000 { compatible = "qcom,msm8996-apcc"; - reg = <0x6400000 0x90000>; + reg = <0x6400000 0x90000>, <0x09a11000 0x10000>; #clock-cells = <1>; };
Add CBF clock and reg. Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> --- .../devicetree/bindings/clock/qcom,msm8996-apcc.yaml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)