| Message ID | 20211009161941.41634-1-david@ixit.cz |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v3] dt-bindings: net: nfc: nxp,pn544: Convert txt bindings to yaml | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 61 lines checked |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On 09/10/2021 18:19, David Heidelberg wrote: > Convert bindings for NXP PN544 NFC driver to YAML syntax. > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > v2 > - Krzysztof is a maintainer > - pintctrl dropped > - 4 space indent for example > - nfc node name > v3 > - remove whole pinctrl > .../bindings/net/nfc/nxp,pn544.yaml | 61 +++++++++++++++++++ > .../devicetree/bindings/net/nfc/pn544.txt | 33 ---------- > 2 files changed, 61 insertions(+), 33 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml > delete mode 100644 Documentation/devicetree/bindings/net/nfc/pn544.txt > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
On 09/10/2021 18:19, David Heidelberg wrote: > Convert bindings for NXP PN544 NFC driver to YAML syntax. > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > v2 > - Krzysztof is a maintainer > - pintctrl dropped > - 4 space indent for example > - nfc node name > v3 > - remove whole pinctrl > .../bindings/net/nfc/nxp,pn544.yaml | 61 +++++++++++++++++++ > .../devicetree/bindings/net/nfc/pn544.txt | 33 ---------- > 2 files changed, 61 insertions(+), 33 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml > delete mode 100644 Documentation/devicetree/bindings/net/nfc/pn544.txt > Rob, The netdev folks marked patch as not-applicable, so I guess they expect you to pick it up. Can you take it? Similarly to my NFC bindings conversion sent this weekend: https://lore.kernel.org/linux-nfc/20211010142317.168259-1-krzysztof.kozlowski@canonical.com/T/#t Best regards, Krzysztof
On Sat, 09 Oct 2021 18:19:42 +0200, David Heidelberg wrote: > Convert bindings for NXP PN544 NFC driver to YAML syntax. > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > v2 > - Krzysztof is a maintainer > - pintctrl dropped > - 4 space indent for example > - nfc node name > v3 > - remove whole pinctrl > .../bindings/net/nfc/nxp,pn544.yaml | 61 +++++++++++++++++++ > .../devicetree/bindings/net/nfc/pn544.txt | 33 ---------- > 2 files changed, 61 insertions(+), 33 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml > delete mode 100644 Documentation/devicetree/bindings/net/nfc/pn544.txt > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1538804 pn547@28: 'clock-frequency' is a required property arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dt.yaml arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml
On 10/10/2021 21:31, Rob Herring wrote: > On Sat, 09 Oct 2021 18:19:42 +0200, David Heidelberg wrote: >> Convert bindings for NXP PN544 NFC driver to YAML syntax. >> >> Signed-off-by: David Heidelberg <david@ixit.cz> >> --- >> v2 >> - Krzysztof is a maintainer >> - pintctrl dropped >> - 4 space indent for example >> - nfc node name >> v3 >> - remove whole pinctrl >> .../bindings/net/nfc/nxp,pn544.yaml | 61 +++++++++++++++++++ >> .../devicetree/bindings/net/nfc/pn544.txt | 33 ---------- >> 2 files changed, 61 insertions(+), 33 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml >> delete mode 100644 Documentation/devicetree/bindings/net/nfc/pn544.txt >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1538804 > > > pn547@28: 'clock-frequency' is a required property > arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dt.yaml > arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml > I think clock-frequency should be dropped from I2C slave device. Similarly to this one: https://lore.kernel.org/linux-nfc/f955726a-eb2d-7b3e-9c5f-978358710eb6@canonical.com/T/#u Best regards, Krzysztof
On Sun, Oct 10 2021 at 23:01:24 +0200, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > On 10/10/2021 21:31, Rob Herring wrote: >> On Sat, 09 Oct 2021 18:19:42 +0200, David Heidelberg wrote: >>> Convert bindings for NXP PN544 NFC driver to YAML syntax. >>> >>> Signed-off-by: David Heidelberg <david@ixit.cz> >>> --- >>> v2 >>> - Krzysztof is a maintainer >>> - pintctrl dropped >>> - 4 space indent for example >>> - nfc node name >>> v3 >>> - remove whole pinctrl >>> .../bindings/net/nfc/nxp,pn544.yaml | 61 >>> +++++++++++++++++++ >>> .../devicetree/bindings/net/nfc/pn544.txt | 33 ---------- >>> 2 files changed, 61 insertions(+), 33 deletions(-) >>> create mode 100644 >>> Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml >>> delete mode 100644 >>> Documentation/devicetree/bindings/net/nfc/pn544.txt >>> >> >> Running 'make dtbs_check' with the schema in this patch gives the >> following warnings. Consider if they are expected or the schema is >> incorrect. These may not be new warnings. >> >> Note that it is not yet a requirement to have 0 warnings for >> dtbs_check. >> This will change in the future. >> >> Full log is available here: >> https://patchwork.ozlabs.org/patch/1538804 >> >> >> pn547@28: 'clock-frequency' is a required property >> arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dt.yaml >> arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml >> > > I think clock-frequency should be dropped from I2C slave device. > Similarly to this one: > https://lore.kernel.org/linux-nfc/f955726a-eb2d-7b3e-9c5f-978358710eb6@canonical.com/T/#u > You have right, it isn't parsed by driver and values match parent i2c bus. I dropped it in next revision. David > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml new file mode 100644 index 000000000000..5fc57341cf33 --- /dev/null +++ b/Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/nfc/nxp,pn544.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP Semiconductors PN544 NFC Controller + +maintainers: + - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> + +properties: + compatible: + const: nxp,pn544-i2c + + clock-frequency: true + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + enable-gpios: + description: Output GPIO pin used for enabling/disabling the PN544 + + firmware-gpios: + description: Output GPIO pin used to enter firmware download mode + +required: + - compatible + - clock-frequency + - reg + - interrupts + - enable-gpios + - firmware-gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + nfc@28 { + compatible = "nxp,pn544-i2c"; + + reg = <0x28>; + clock-frequency = <400000>; + + interrupt-parent = <&gpio1>; + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; + + enable-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + firmware-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>; + }; + }; diff --git a/Documentation/devicetree/bindings/net/nfc/pn544.txt b/Documentation/devicetree/bindings/net/nfc/pn544.txt deleted file mode 100644 index 2bd82562ce8e..000000000000 --- a/Documentation/devicetree/bindings/net/nfc/pn544.txt +++ /dev/null @@ -1,33 +0,0 @@ -* NXP Semiconductors PN544 NFC Controller - -Required properties: -- compatible: Should be "nxp,pn544-i2c". -- clock-frequency: I²C work frequency. -- reg: address on the bus -- interrupts: GPIO interrupt to which the chip is connected -- enable-gpios: Output GPIO pin used for enabling/disabling the PN544 -- firmware-gpios: Output GPIO pin used to enter firmware download mode - -Optional SoC Specific Properties: -- pinctrl-names: Contains only one value - "default". -- pintctrl-0: Specifies the pin control groups used for this controller. - -Example (for ARM-based BeagleBone with PN544 on I2C2): - -&i2c2 { - - - pn544: pn544@28 { - - compatible = "nxp,pn544-i2c"; - - reg = <0x28>; - clock-frequency = <400000>; - - interrupt-parent = <&gpio1>; - interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; - - enable-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; - firmware-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>; - }; -};
Convert bindings for NXP PN544 NFC driver to YAML syntax. Signed-off-by: David Heidelberg <david@ixit.cz> --- v2 - Krzysztof is a maintainer - pintctrl dropped - 4 space indent for example - nfc node name v3 - remove whole pinctrl .../bindings/net/nfc/nxp,pn544.yaml | 61 +++++++++++++++++++ .../devicetree/bindings/net/nfc/pn544.txt | 33 ---------- 2 files changed, 61 insertions(+), 33 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,pn544.yaml delete mode 100644 Documentation/devicetree/bindings/net/nfc/pn544.txt