diff mbox series

[v3,02/25] dt-bindings: mfd: qcom-pm8xxx: add missing child nodes

Message ID 20211008012524.481877-3-dmitry.baryshkov@linaro.org
State Not Applicable, archived
Headers show
Series | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema success
robh/dtbs-check fail build log

Commit Message

Dmitry Baryshkov Oct. 8, 2021, 1:25 a.m. UTC
Add gpio@[0-9a-f]+, mpps@[0-9a-f]+ and xoadc@[0-9a-f]+ as possible child
nodes of qcom,pm8xxx, referencing existint schema files. Schema for
other possible nodes does not exist yet.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../devicetree/bindings/mfd/qcom-pm8xxx.yaml         | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Rob Herring (Arm) Oct. 8, 2021, 2:46 a.m. UTC | #1
On Fri, 08 Oct 2021 04:25:01 +0300, Dmitry Baryshkov wrote:
> Add gpio@[0-9a-f]+, mpps@[0-9a-f]+ and xoadc@[0-9a-f]+ as possible child
> nodes of qcom,pm8xxx, referencing existint schema files. Schema for
> other possible nodes does not exist yet.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../devicetree/bindings/mfd/qcom-pm8xxx.yaml         | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1538158


pmic@0: compatible:0: 'qcom,pm8018' is not one of ['qcom,pm8058', 'qcom,pm8821', 'qcom,pm8921']
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml

pmic@0: compatible: Additional items are not allowed ('qcom,pm8921' was unexpected)
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml

pmic@0: compatible: ['qcom,pm8018', 'qcom,pm8921'] is too long
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml

pmic@0: gpio@150: 'ak8975-gpios', 'bmp085-gpios', 'cm3605-gpios', 'ethernet-gpios', 'mpu3050-gpios', 'sdcc3-gpios', 'sdcc5-gpios', 'veth-gpios' do not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/qcom-apq8060-dragonboard.dt.yaml

pmic@0: gpio@150: 'gpio-keys-pin-active' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml

pmic@0: gpio@150: 'nled', 'wlan-gpios' do not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml

pmic@0: gpio@150: 'reg' is a required property
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml

pmic@0: gpio@150: 'usb_vbus_5v_pins' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml

pmic@0: gpio@150: 'wlan-gpios' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml

pmic@0: 'keypad@148', 'led@131', 'led@132', 'led@133', 'led@48', 'pwrkey@1c', 'vibrator@4a' do not match any of the regexes: 'gpio@[0-9a-f]+$', 'mpps@[0-9a-f]+$', 'pinctrl-[0-9]+', 'rtc@[0-9a-f]+$', 'xoadc@[0-9a-f]+$'
	arch/arm/boot/dts/qcom-apq8060-dragonboard.dt.yaml

pmic@0: 'keypad@148', 'pwrkey@1c' do not match any of the regexes: 'gpio@[0-9a-f]+$', 'mpps@[0-9a-f]+$', 'pinctrl-[0-9]+', 'rtc@[0-9a-f]+$', 'xoadc@[0-9a-f]+$'
	arch/arm/boot/dts/qcom-msm8960-cdp.dt.yaml

pmic@0: 'keypad@148', 'pwrkey@1c', 'vibrator@4a' do not match any of the regexes: 'gpio@[0-9a-f]+$', 'mpps@[0-9a-f]+$', 'pinctrl-[0-9]+', 'rtc@[0-9a-f]+$', 'xoadc@[0-9a-f]+$'
	arch/arm/boot/dts/qcom-msm8660-surf.dt.yaml

pmic@0: 'mpp@50', 'pwrkey@1c' do not match any of the regexes: 'gpio@[0-9a-f]+$', 'mpps@[0-9a-f]+$', 'pinctrl-[0-9]+', 'rtc@[0-9a-f]+$', 'xoadc@[0-9a-f]+$'
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml

pmic@0: mpps@50: 'cm3605-mpps' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/qcom-apq8060-dragonboard.dt.yaml

pmic@0: mpps@50: 'gpio-ranges' is a required property
	arch/arm/boot/dts/qcom-apq8060-dragonboard.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
	arch/arm/boot/dts/qcom-msm8660-surf.dt.yaml

pmic@0: 'pwrkey@1c' does not match any of the regexes: 'gpio@[0-9a-f]+$', 'mpps@[0-9a-f]+$', 'pinctrl-[0-9]+', 'rtc@[0-9a-f]+$', 'xoadc@[0-9a-f]+$'
	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml

pmic@0: rtc@11d:compatible: Additional items are not allowed ('qcom,pm8921-rtc' was unexpected)
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml

pmic@0: rtc@11d:compatible: ['qcom,pm8018-rtc', 'qcom,pm8921-rtc'] is too long
	arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml

pmic@0: xoadc@197: 'mpp5@5', 'mpp6@6', 'mpp7@7', 'mpp8@8', 'mpp9@9' do not match any of the regexes: '^(adc-channel@)[0-9a-f]$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/qcom-apq8060-dragonboard.dt.yaml

pmic@1: mpps@50: 'gpio-ranges' is a required property
	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
Linus Walleij Oct. 17, 2021, 9:28 p.m. UTC | #2
On Fri, Oct 8, 2021 at 3:25 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:

> Add gpio@[0-9a-f]+, mpps@[0-9a-f]+ and xoadc@[0-9a-f]+ as possible child
> nodes of qcom,pm8xxx, referencing existint schema files. Schema for
> other possible nodes does not exist yet.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Rob Herring (Arm) Oct. 18, 2021, 6:40 p.m. UTC | #3
On Fri, 08 Oct 2021 04:25:01 +0300, Dmitry Baryshkov wrote:
> Add gpio@[0-9a-f]+, mpps@[0-9a-f]+ and xoadc@[0-9a-f]+ as possible child
> nodes of qcom,pm8xxx, referencing existint schema files. Schema for
> other possible nodes does not exist yet.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../devicetree/bindings/mfd/qcom-pm8xxx.yaml         | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
index 9065ec53e643..10021eb7103e 100644
--- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
@@ -38,10 +38,22 @@  properties:
   interrupt-controller: true
 
 patternProperties:
+  "gpio@[0-9a-f]+$":
+    type: object
+    $ref: "../pinctrl/qcom,pmic-gpio.yaml"
+
+  "mpps@[0-9a-f]+$":
+    type: object
+    $ref: "../pinctrl/qcom,pmic-mpp.yaml"
+
   "rtc@[0-9a-f]+$":
     type: object
     $ref: "../rtc/qcom-pm8xxx-rtc.yaml"
 
+  "xoadc@[0-9a-f]+$":
+    type: object
+    $ref: "../iio/adc/qcom,pm8018-adc.yaml"
+
 required:
   - compatible
   - '#address-cells'