| Message ID | 1633060859-22969-3-git-send-email-skakit@codeaurora.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add Qualcomm Technologies, Inc. PM8008 regulator driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, 01 Oct 2021 09:30:57 +0530, Satya Priya wrote: > Add pm8008-regulator node and example. > > Signed-off-by: Satya Priya <skakit@codeaurora.org> > --- > Changes in V2: > - As per Rob's comments changed "pm8008[a-z]?-regulator" to > "^pm8008[a-z]?-regulators". > > .../devicetree/bindings/mfd/qcom,pm8008.yaml | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/qcom,pm8008.example.dt.yaml: pm8008i@8: pm8008-regulators:regulator@4000: 'regulator-max-microvolt', 'regulator-min-microvolt' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/qcom,pm8008.example.dt.yaml: pm8008-regulators: regulator@4000: 'regulator-max-microvolt', 'regulator-min-microvolt' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1535124 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Quoting Satya Priya (2021-09-30 21:00:57) > Add pm8008-regulator node and example. > > Signed-off-by: Satya Priya <skakit@codeaurora.org> > --- > Changes in V2: > - As per Rob's comments changed "pm8008[a-z]?-regulator" to > "^pm8008[a-z]?-regulators". > > .../devicetree/bindings/mfd/qcom,pm8008.yaml | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml > index ec3138c..0c9665e 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml > +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml > @@ -45,6 +45,10 @@ properties: > const: 0 > > patternProperties: > + "^pm8008[a-z]?-regulators$": Please just call it 'regulators' > + type: object > + $ref: "../regulator/qcom,pm8008-regulator.yaml#" > + > "^gpio@[0-9a-f]+$": > type: object > > @@ -122,6 +126,26 @@ examples: > interrupt-controller; > #interrupt-cells = <2>; > }; > + > + pm8008-regulators { Please just call it 'regulators' > + compatible = "qcom,pm8008-regulator"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + vdd_l1_l2-supply = <&vreg_s8b_1p2>; > + vdd_l3_l4-supply = <&vreg_s1b_1p8>; > + vdd_l5-supply = <&vreg_bob>; > + vdd_l6-supply = <&vreg_bob>; > + vdd_l7-supply = <&vreg_bob>; > + > + pm8008_l1: regulator@4000 { > + reg = <0x4000>; > + regulator-name = "pm8008_l1"; > + regulator-min-microvolt = <950000>; > + regulator-max-microvolt = <1300000>; > + qcom,min-dropout-voltage = <96000>; > + }; > + };
On 2021-10-05 23:40, Stephen Boyd wrote: > Quoting Satya Priya (2021-09-30 21:00:57) >> Add pm8008-regulator node and example. >> >> Signed-off-by: Satya Priya <skakit@codeaurora.org> >> --- >> Changes in V2: >> - As per Rob's comments changed "pm8008[a-z]?-regulator" to >> "^pm8008[a-z]?-regulators". >> >> .../devicetree/bindings/mfd/qcom,pm8008.yaml | 24 >> ++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml >> b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml >> index ec3138c..0c9665e 100644 >> --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml >> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml >> @@ -45,6 +45,10 @@ properties: >> const: 0 >> >> patternProperties: >> + "^pm8008[a-z]?-regulators$": > > Please just call it 'regulators' > >> + type: object >> + $ref: "../regulator/qcom,pm8008-regulator.yaml#" >> + >> "^gpio@[0-9a-f]+$": >> type: object >> >> @@ -122,6 +126,26 @@ examples: >> interrupt-controller; >> #interrupt-cells = <2>; >> }; >> + >> + pm8008-regulators { > > Please just call it 'regulators' > Okay >> + compatible = "qcom,pm8008-regulator"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + vdd_l1_l2-supply = <&vreg_s8b_1p2>; >> + vdd_l3_l4-supply = <&vreg_s1b_1p8>; >> + vdd_l5-supply = <&vreg_bob>; >> + vdd_l6-supply = <&vreg_bob>; >> + vdd_l7-supply = <&vreg_bob>; >> + >> + pm8008_l1: regulator@4000 { >> + reg = <0x4000>; >> + regulator-name = "pm8008_l1"; >> + regulator-min-microvolt = <950000>; >> + regulator-max-microvolt = <1300000>; >> + qcom,min-dropout-voltage = <96000>; >> + }; >> + };
diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml index ec3138c..0c9665e 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml @@ -45,6 +45,10 @@ properties: const: 0 patternProperties: + "^pm8008[a-z]?-regulators$": + type: object + $ref: "../regulator/qcom,pm8008-regulator.yaml#" + "^gpio@[0-9a-f]+$": type: object @@ -122,6 +126,26 @@ examples: interrupt-controller; #interrupt-cells = <2>; }; + + pm8008-regulators { + compatible = "qcom,pm8008-regulator"; + #address-cells = <1>; + #size-cells = <0>; + + vdd_l1_l2-supply = <&vreg_s8b_1p2>; + vdd_l3_l4-supply = <&vreg_s1b_1p8>; + vdd_l5-supply = <&vreg_bob>; + vdd_l6-supply = <&vreg_bob>; + vdd_l7-supply = <&vreg_bob>; + + pm8008_l1: regulator@4000 { + reg = <0x4000>; + regulator-name = "pm8008_l1"; + regulator-min-microvolt = <950000>; + regulator-max-microvolt = <1300000>; + qcom,min-dropout-voltage = <96000>; + }; + }; }; };
Add pm8008-regulator node and example. Signed-off-by: Satya Priya <skakit@codeaurora.org> --- Changes in V2: - As per Rob's comments changed "pm8008[a-z]?-regulator" to "^pm8008[a-z]?-regulators". .../devicetree/bindings/mfd/qcom,pm8008.yaml | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+)