| Message ID | 1632399378-12229-2-git-send-email-rajpat@codeaurora.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add QSPI and QUPv3 DT nodes for SC7280 SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On Thu, 23 Sep 2021 17:46:11 +0530, Rajesh Patil wrote: > Add compatible for sc7280 SoC. > > Signed-off-by: Rajesh Patil <rajpat@codeaurora.org> > Reviewed-by: Doug Anderson <dianders@chromium.org> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > --- > Change in V10: > - As per Stephen's comments, > sorted compatible names in alphabet order > > Changes in V9: > - No changes > > Changes in V8: > - As per Doug's comments, added "qcom,sc7280-qspi" compatible > > Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1531702 spi@88dc000: compatible:0: 'qcom,qspi-v1' is not one of ['qcom,sc7280-qspi', 'qcom,sdm845-qspi'] arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml spi@88dc000: compatible: ['qcom,qspi-v1'] is too short arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml spi@88dc000: interconnect-names: ['qspi-config'] is too short arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml >From nobody Thu Sep 23 17:37:11 2021 From: Rob Herring <robh@kernel.org> To: Konrad Dybcio <konrad.dybcio@somainline.org> Cc: Taniya Das <tdas@codeaurora.org>, marijn.suijten@somainline.org, Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>, martin.botka@somainline.org, Andy Gross <agross@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, angelogioacchino.delregno@somainline.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, jamipkettunen@somainline.org, Bjorn Andersson <bjorn.andersson@linaro.org>, Michael Turquette <mturquette@baylibre.com>, ~postmarketos/upstreaming@lists.sr.ht In-Reply-To: <20210923162645.23257-1-konrad.dybcio@somainline.org> References: <20210923162645.23257-1-konrad.dybcio@somainline.org> Subject: Re: [PATCH v4 1/9] dt-bindings: clk: qcom: Add bindings for MSM8994 GCC driver Status: RO Content-Length: 4225 Lines: 83 On Thu, 23 Sep 2021 18:26:34 +0200, Konrad Dybcio wrote: > Add documentation for the MSM8994 GCC driver. While at it, retire its > compatible from the old, everyone-get-in-here file. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > --- > Changes since v3: > - Don't document the compatible twice > > .../bindings/clock/qcom,gcc-msm8994.yaml | 70 +++++++++++++++++++ > .../devicetree/bindings/clock/qcom,gcc.yaml | 2 - > 2 files changed, 70 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8994.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1531778 clock-controller@100000: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sdm630-sony-xperia-ganges-kirin.dt.yaml arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-discovery.dt.yaml arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-pioneer.dt.yaml arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-voyager.dt.yaml arch/arm64/boot/dts/qcom/sdm636-sony-xperia-ganges-mermaid.dt.yaml arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dt.yaml clock-controller@1800000: '#power-domain-cells' is a required property arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml clock-controller@900000: '#power-domain-cells' is a required property arch/arm/boot/dts/qcom-apq8060-dragonboard.dt.yaml arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml arch/arm/boot/dts/qcom-msm8660-surf.dt.yaml arch/arm/boot/dts/qcom-msm8960-cdp.dt.yaml clock-controller@900000: 'thermal-sensor@900000' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/qcom-ipq8064-ap148.dt.yaml arch/arm/boot/dts/qcom-ipq8064-rb3011.dt.yaml clock-controller@fc400000: 'clock-names' is a required property arch/arm64/boot/dts/qcom/apq8094-sony-xperia-kitakami-karin_windy.dt.yaml arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dt.yaml arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dt.yaml arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dt.yaml arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dt.yaml arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-ivy.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-karin.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-satsuki.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-suzuran.dt.yaml clock-controller@fc400000: 'clocks' is a required property arch/arm64/boot/dts/qcom/apq8094-sony-xperia-kitakami-karin_windy.dt.yaml arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dt.yaml arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dt.yaml arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dt.yaml arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dt.yaml arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-ivy.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-karin.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-satsuki.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dt.yaml arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-suzuran.dt.yaml gcc@1800000: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml gcc@1800000: '#power-domain-cells' is a required property arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml
Hi, On Thu, Sep 23, 2021 at 3:37 PM Rob Herring <robh@kernel.org> wrote: > > On Thu, 23 Sep 2021 17:46:11 +0530, Rajesh Patil wrote: > > Add compatible for sc7280 SoC. > > > > Signed-off-by: Rajesh Patil <rajpat@codeaurora.org> > > Reviewed-by: Doug Anderson <dianders@chromium.org> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > --- > > Change in V10: > > - As per Stephen's comments, > > sorted compatible names in alphabet order > > > > Changes in V9: > > - No changes > > > > Changes in V8: > > - As per Doug's comments, added "qcom,sc7280-qspi" compatible > > > > Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1531702 > > > spi@88dc000: compatible:0: 'qcom,qspi-v1' is not one of ['qcom,sc7280-qspi', 'qcom,sdm845-qspi'] > arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml > > spi@88dc000: compatible: ['qcom,qspi-v1'] is too short > arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml Right. I mentioned this in earlier review feedback and Rajesh said he'd do a follow-up patch to add sc7180 to the list here and also add the proper compatible in the sc7180.dtsi file. That's not a new error and (IMO) shouldn't block this patch from moving forward, though it should be nearly trivial to do. -Doug
On Thu, Sep 23, 2021 at 5:45 PM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Thu, Sep 23, 2021 at 3:37 PM Rob Herring <robh@kernel.org> wrote: > > > > On Thu, 23 Sep 2021 17:46:11 +0530, Rajesh Patil wrote: > > > Add compatible for sc7280 SoC. > > > > > > Signed-off-by: Rajesh Patil <rajpat@codeaurora.org> > > > Reviewed-by: Doug Anderson <dianders@chromium.org> > > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > > --- > > > Change in V10: > > > - As per Stephen's comments, > > > sorted compatible names in alphabet order > > > > > > Changes in V9: > > > - No changes > > > > > > Changes in V8: > > > - As per Doug's comments, added "qcom,sc7280-qspi" compatible > > > > > > Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. > > > > Full log is available here: https://patchwork.ozlabs.org/patch/1531702 > > > > > > spi@88dc000: compatible:0: 'qcom,qspi-v1' is not one of ['qcom,sc7280-qspi', 'qcom,sdm845-qspi'] > > arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml > > > > spi@88dc000: compatible: ['qcom,qspi-v1'] is too short > > arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml > > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml > > Right. I mentioned this in earlier review feedback and Rajesh said > he'd do a follow-up patch to add sc7180 to the list here and also add > the proper compatible in the sc7180.dtsi file. That's not a new error > and (IMO) shouldn't block this patch from moving forward, though it > should be nearly trivial to do. To repeat: > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. But I think it is useful information to make an informed decision whether the schema is missing something or not, so I'm adding these to my semi-automated emails. Rob
On Thu, 23 Sep 2021 17:46:11 +0530, Rajesh Patil wrote: > Add compatible for sc7280 SoC. > > Signed-off-by: Rajesh Patil <rajpat@codeaurora.org> > Reviewed-by: Doug Anderson <dianders@chromium.org> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > --- > Change in V10: > - As per Stephen's comments, > sorted compatible names in alphabet order > > Changes in V9: > - No changes > > Changes in V8: > - As per Doug's comments, added "qcom,sc7280-qspi" compatible > > Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu 23 Sep 07:16 CDT 2021, Rajesh Patil wrote: > Add compatible for sc7280 SoC. > > Signed-off-by: Rajesh Patil <rajpat@codeaurora.org> > Reviewed-by: Doug Anderson <dianders@chromium.org> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> Can you please pick up Rob's review tag and send this patch out again, this time including the SPI maintainer (Mark Brown <broonie@kernel.org>) among the recipients. Thanks, Bjorn > --- > Change in V10: > - As per Stephen's comments, > sorted compatible names in alphabet order > > Changes in V9: > - No changes > > Changes in V8: > - As per Doug's comments, added "qcom,sc7280-qspi" compatible > > Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > index ef5698f..09aa955 100644 > --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > @@ -21,7 +21,10 @@ allOf: > properties: > compatible: > items: > - - const: qcom,sdm845-qspi > + - enum: > + - qcom,sc7280-qspi > + - qcom,sdm845-qspi > + > - const: qcom,qspi-v1 > > reg: > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >
On 2021-09-25 04:17, Bjorn Andersson wrote: > On Thu 23 Sep 07:16 CDT 2021, Rajesh Patil wrote: > >> Add compatible for sc7280 SoC. >> >> Signed-off-by: Rajesh Patil <rajpat@codeaurora.org> >> Reviewed-by: Doug Anderson <dianders@chromium.org> >> Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > Can you please pick up Rob's review tag and send this patch out again, > this time including the SPI maintainer (Mark Brown > <broonie@kernel.org>) > among the recipients. > > Thanks, > Bjorn Okay. > >> --- >> Change in V10: >> - As per Stephen's comments, >> sorted compatible names in alphabet order >> >> Changes in V9: >> - No changes >> >> Changes in V8: >> - As per Doug's comments, added "qcom,sc7280-qspi" compatible >> >> Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 >> ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml >> b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml >> index ef5698f..09aa955 100644 >> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml >> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml >> @@ -21,7 +21,10 @@ allOf: >> properties: >> compatible: >> items: >> - - const: qcom,sdm845-qspi >> + - enum: >> + - qcom,sc7280-qspi >> + - qcom,sdm845-qspi >> + >> - const: qcom,qspi-v1 >> >> reg: >> -- >> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a >> member >> of Code Aurora Forum, hosted by The Linux Foundation >>
diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml index ef5698f..09aa955 100644 --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml @@ -21,7 +21,10 @@ allOf: properties: compatible: items: - - const: qcom,sdm845-qspi + - enum: + - qcom,sc7280-qspi + - qcom,sdm845-qspi + - const: qcom,qspi-v1 reg: