| Message ID | 20210826185135.26599-2-dkangude@cadence.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v1] dt-bindings: ufshc: cdns: convert bindings for Cadence UFS host controller | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 80 lines checked |
| robh/dt-meta-schema | fail | build log |
On Thu, 26 Aug 2021 20:51:35 +0200, Dhananjay Kangude wrote: > Converted bindings into yaml format for Cadence UFS host controller > > Signed-off-by: Dhananjay Kangude <dkangude@cadence.com> > --- > .../devicetree/bindings/ufs/cdns,ufshc.txt | 32 -------- > .../devicetree/bindings/ufs/cdns,ufshc.yaml | 80 ++++++++++++++++++++ > 2 files changed, 80 insertions(+), 32 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.txt > create mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/ufs/ti,j721e-ufs.example.dt.yaml: ufs@4000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/ufs/cdns,ufshc.yaml doc reference errors (make refcheckdocs): Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml: Documentation/devicetree/bindings/ufs/cdns,ufshc.txt See https://patchwork.ozlabs.org/patch/1521296 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
This patch series converted the previous dt-binging text to yaml for Cadence UFS host.
Changes since v1:
1. Corrected reference to cdns,ufshc.yaml in ti,j721e-ufs.yaml
2. Removed power-doamin property from ufs node
Dhananjay Kangude (1):
dt-bindings: ufshc: cdns: convert bindings for Cadence UFS host
controller
.../devicetree/bindings/ufs/cdns,ufshc.txt | 32 --------
.../devicetree/bindings/ufs/cdns,ufshc.yaml | 80 ++++++++++++++++++++
.../devicetree/bindings/ufs/ti,j721e-ufs.yaml | 3 +-
3 files changed, 81 insertions(+), 34 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.txt
create mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.yaml
diff --git a/Documentation/devicetree/bindings/ufs/cdns,ufshc.txt b/Documentation/devicetree/bindings/ufs/cdns,ufshc.txt deleted file mode 100644 index 02347b0..0000000 --- a/Documentation/devicetree/bindings/ufs/cdns,ufshc.txt +++ /dev/null @@ -1,32 +0,0 @@ -* Cadence Universal Flash Storage (UFS) Controller - -UFS nodes are defined to describe on-chip UFS host controllers. -Each UFS controller instance should have its own node. -Please see the ufshcd-pltfrm.txt for a list of all available properties. - -Required properties: -- compatible : Compatible list, contains one of the following controllers: - "cdns,ufshc" - Generic CDNS HCI, - "cdns,ufshc-m31-16nm" - CDNS UFS HC + M31 16nm PHY - complemented with the JEDEC version: - "jedec,ufs-2.0" - -- reg : Address and length of the UFS register set. -- interrupts : One interrupt mapping. -- freq-table-hz : Clock frequency table. - See the ufshcd-pltfrm.txt for details. -- clocks : List of phandle and clock specifier pairs. -- clock-names : List of clock input name strings sorted in the same - order as the clocks property. "core_clk" is mandatory. - Depending on a type of a PHY, - the "phy_clk" clock can also be added, if needed. - -Example: - ufs@fd030000 { - compatible = "cdns,ufshc", "jedec,ufs-2.0"; - reg = <0xfd030000 0x10000>; - interrupts = <0 1 IRQ_TYPE_LEVEL_HIGH>; - freq-table-hz = <0 0>, <0 0>; - clocks = <&ufs_core_clk>, <&ufs_phy_clk>; - clock-names = "core_clk", "phy_clk"; - }; diff --git a/Documentation/devicetree/bindings/ufs/cdns,ufshc.yaml b/Documentation/devicetree/bindings/ufs/cdns,ufshc.yaml new file mode 100644 index 0000000..4509ae0 --- /dev/null +++ b/Documentation/devicetree/bindings/ufs/cdns,ufshc.yaml @@ -0,0 +1,80 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/ufs/cdns,ufshc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cadence Universal Flash Storage (UFS) Controller + +maintainers: + - Dhananjay Kangude <dkangude@cadence.com> + +description: + UFS nodes are defined to describe on-chip Cadence UFS host controllers. + Each UFS controller instance should have its own node. + +properties: + compatible: + oneOf: + - items: + - enum: + - cdns,ufshc + - cdns,ufshc-m31-16nm + - const: jedec,ufs-2.0 + - items: + - const: jedec,ufs-2.0 + + reg: + items: + - description: UFS controller register set + + interrupts: + maxItems: 1 + + clocks: + minItems: 1 + items: + - description: Description of core_clk + - description: Description of phy_clk + - description: Description of ref_clk + + clock-names: + minItems: 1 + items: + - const: core_clk + - const: phy_clk + - const: ref_clk + + freq-table-hz: + $ref: /schemas/types.yaml#/definitions/uint64-matrix + description: + Clock frequency table. + See the ufshcd-pltfrm.txt for details. + + dma-coherent: true + +required: + - compatible + - reg + - interrupts + - freq-table-hz + - clocks + - clock-names + +additionalProperties: false +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + ufs: ufs@fd030000 { + compatible = "cdns,ufshc", "jedec,ufs-2.0"; + reg = <0xfd030000 0x10000>; + interrupts = <0 1 IRQ_TYPE_LEVEL_HIGH>; + freq-table-hz = <0 0>; + clocks = <&ufs_core_clk>; + clock-names = "core_clk"; + }; +
Converted bindings into yaml format for Cadence UFS host controller Signed-off-by: Dhananjay Kangude <dkangude@cadence.com> --- .../devicetree/bindings/ufs/cdns,ufshc.txt | 32 -------- .../devicetree/bindings/ufs/cdns,ufshc.yaml | 80 ++++++++++++++++++++ 2 files changed, 80 insertions(+), 32 deletions(-) delete mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.txt create mode 100644 Documentation/devicetree/bindings/ufs/cdns,ufshc.yaml