| Message ID | 1629716132-21544-1-git-send-email-sugar.zhang@rock-chips.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Patches to update for rockchip i2s | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 1 errors, 0 warnings, 15 lines checked |
| robh/dt-meta-schema | fail | build log |
On Mon, 23 Aug 2021 18:55:32 +0800, Sugar Zhang wrote: > This patch documents property 'rockchip,clk-trcm' which is used > to specify the lrck. > > Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com> > Change-Id: I648142c57c568bbed209f2b9188b1f539a3285b2 > --- > Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/sound/rockchip-i2s.example.dts' Traceback (most recent call last): File "/usr/local/bin/dt-extract-example", line 45, in <module> binding = yaml.load(open(args.yamlfile, encoding='utf-8').read()) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load return constructor.get_single_data() File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 120, in get_single_data node = self.composer.get_single_node() File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node File "_ruamel_yaml.pyx", line 891, in _ruamel_yaml.CParser._compose_mapping_node File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event ruamel.yaml.scanner.ScannerError: mapping values are not allowed in this context in "<unicode string>", line 80, column 8 make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/sound/rockchip-i2s.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/sound/rockchip-i2s.yaml: mapping values are not allowed in this context in "<unicode string>", line 80, column 8 /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml: ignoring, error parsing file warning: no schema found in file: ./Documentation/devicetree/bindings/sound/rockchip-i2s.yaml make: *** [Makefile:1419: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1519630 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Mon, Aug 23, 2021 at 06:55:32PM +0800, Sugar Zhang wrote: > This patch documents property 'rockchip,clk-trcm' which is used > to specify the lrck. > > Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com> > Change-Id: I648142c57c568bbed209f2b9188b1f539a3285b2 Drop this. > --- > Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > index 11e911a..8d9dfed 100644 > --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > @@ -72,6 +72,15 @@ properties: > resets: > maxItems: 2 > > + rockchip,clk-trcm: > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 0 > + description: > + tx and rx lrck/bclk common use. > + 0: both tx_lrck/bclk and rx_lrck/bclk are used > + 1: only tx_lrck/bclk is used > + 2: only rx_lrck/bclk is used Sounds like constraints. Make a schema. > + > rockchip,capture-channels: > $ref: /schemas/types.yaml#/definitions/uint32 > default: 2 > -- > 2.7.4 > > > >
On 2021/8/24 1:36, Rob Herring wrote: > On Mon, Aug 23, 2021 at 06:55:32PM +0800, Sugar Zhang wrote: >> This patch documents property 'rockchip,clk-trcm' which is used >> to specify the lrck. >> >> Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com> >> Change-Id: I648142c57c568bbed209f2b9188b1f539a3285b2 > Drop this. okay, will do in v2. >> --- >> Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml >> index 11e911a..8d9dfed 100644 >> --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml >> +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml >> @@ -72,6 +72,15 @@ properties: >> resets: >> maxItems: 2 >> >> + rockchip,clk-trcm: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + default: 0 >> + description: >> + tx and rx lrck/bclk common use. >> + 0: both tx_lrck/bclk and rx_lrck/bclk are used >> + 1: only tx_lrck/bclk is used >> + 2: only rx_lrck/bclk is used > Sounds like constraints. Make a schema. will split into two properties: rockchip,trcm-sync-tx-only, rockchip,trcm-sync-rx-only. >> + >> rockchip,capture-channels: >> $ref: /schemas/types.yaml#/definitions/uint32 >> default: 2 >> -- >> 2.7.4 >> >> >> >> > >
diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml index 11e911a..8d9dfed 100644 --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml @@ -72,6 +72,15 @@ properties: resets: maxItems: 2 + rockchip,clk-trcm: + $ref: /schemas/types.yaml#/definitions/uint32 + default: 0 + description: + tx and rx lrck/bclk common use. + 0: both tx_lrck/bclk and rx_lrck/bclk are used + 1: only tx_lrck/bclk is used + 2: only rx_lrck/bclk is used + rockchip,capture-channels: $ref: /schemas/types.yaml#/definitions/uint32 default: 2
This patch documents property 'rockchip,clk-trcm' which is used to specify the lrck. Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com> Change-Id: I648142c57c568bbed209f2b9188b1f539a3285b2 --- Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)