| Message ID | 20210819092943.719433-3-yangcong5@huaqin.corp-partner.google.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Thu, 19 Aug 2021 17:29:43 +0800, yangcong wrote: > The auo,b101uan08.3 panel (already supported by this driver) has > a 3.3V rail that needs to be turned on. For previous users of > this panel this voltage was directly output by pmic. On a new > user (the not-yet-upstream sc7180-trogdor-mrbland board) we need > to turn the 3.3V rail on. > > Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com> > --- > .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.example.dt.yaml: panel@0: 'pp3300-supply' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1518552 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi, On Thu, Aug 19, 2021 at 2:31 AM yangcong <yangcong5@huaqin.corp-partner.google.com> wrote: > > The auo,b101uan08.3 panel (already supported by this driver) has > a 3.3V rail that needs to be turned on. For previous users of > this panel this voltage was directly output by pmic. On a new > user (the not-yet-upstream sc7180-trogdor-mrbland board) we need > to turn the 3.3V rail on. > > Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com> > > --- > .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml > index 38bc1d1b511e..e45de7a4360e 100644 > --- a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml > +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml > @@ -36,6 +36,9 @@ properties: > pp1800-supply: > description: core voltage supply > > + pp3300-supply: > + description: core voltage supply > + > avdd-supply: > description: phandle of the regulator that provides positive voltage > > @@ -52,6 +55,7 @@ required: > - reg > - enable-gpios > - pp1800-supply > + - pp3300-supply Please send a v2 _without_ this line. Old device trees that don't specify the 3.3V rail need to keep working fine and thus it's optional (not required) for people to include the 3.3 V rail. (NOTE: in the source code things will work fine without any changes because the regulator framework will automatically create a "dummy" regulator for you if one wasn't specified in the device tree). -Doug
diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml index 38bc1d1b511e..e45de7a4360e 100644 --- a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml @@ -36,6 +36,9 @@ properties: pp1800-supply: description: core voltage supply + pp3300-supply: + description: core voltage supply + avdd-supply: description: phandle of the regulator that provides positive voltage @@ -52,6 +55,7 @@ required: - reg - enable-gpios - pp1800-supply + - pp3300-supply - avdd-supply - avee-supply
The auo,b101uan08.3 panel (already supported by this driver) has a 3.3V rail that needs to be turned on. For previous users of this panel this voltage was directly output by pmic. On a new user (the not-yet-upstream sc7180-trogdor-mrbland board) we need to turn the 3.3V rail on. Signed-off-by: yangcong <yangcong5@huaqin.corp-partner.google.com> --- .../devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml | 4 ++++ 1 file changed, 4 insertions(+)