| Message ID | 20210401005702.28271-4-zev@bewilderbeest.net |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2,1/3] dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Thu, 1 Apr 2021, at 11:27, Zev Weiss wrote: > This provides a simpler, more direct alternative to the deprecated > aspeed,sirq-polarity-sense property for indicating the polarity of > the Aspeed VUART's SIRQ line. > > Signed-off-by: Zev Weiss <zev@bewilderbeest.net> > --- > Documentation/devicetree/bindings/serial/8250.yaml | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/serial/8250.yaml > b/Documentation/devicetree/bindings/serial/8250.yaml > index 491b9297432d..e79bb6ab9d2c 100644 > --- a/Documentation/devicetree/bindings/serial/8250.yaml > +++ b/Documentation/devicetree/bindings/serial/8250.yaml > @@ -12,8 +12,9 @@ maintainers: > allOf: > - $ref: /schemas/serial.yaml# > - if: > - required: > - - aspeed,sirq-polarity-sense > + anyOf: > + - required: [ aspeed,sirq-active-high ] Do you think we could make use of the approach I put forward here? https://lore.kernel.org/openbmc/20210319062752.145730-18-andrew@aj.id.au/T/#u Andrew
On Wed, Mar 31, 2021 at 11:04:44PM CDT, Andrew Jeffery wrote: > > >On Thu, 1 Apr 2021, at 11:27, Zev Weiss wrote: >> This provides a simpler, more direct alternative to the deprecated >> aspeed,sirq-polarity-sense property for indicating the polarity of >> the Aspeed VUART's SIRQ line. >> >> Signed-off-by: Zev Weiss <zev@bewilderbeest.net> >> --- >> Documentation/devicetree/bindings/serial/8250.yaml | 13 ++++++++++--- >> 1 file changed, 10 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/serial/8250.yaml >> b/Documentation/devicetree/bindings/serial/8250.yaml >> index 491b9297432d..e79bb6ab9d2c 100644 >> --- a/Documentation/devicetree/bindings/serial/8250.yaml >> +++ b/Documentation/devicetree/bindings/serial/8250.yaml >> @@ -12,8 +12,9 @@ maintainers: >> allOf: >> - $ref: /schemas/serial.yaml# >> - if: >> - required: >> - - aspeed,sirq-polarity-sense >> + anyOf: >> + - required: [ aspeed,sirq-active-high ] > >Do you think we could make use of the approach I put forward here? > >https://lore.kernel.org/openbmc/20210319062752.145730-18-andrew@aj.id.au/T/#u > >Andrew If you mean using a u32 property (say aspeed,sirq-polarity) with an explicit IRQ_TYPE_LEVEL_{LOW,HIGH} instead of a present/absent bool, sure, I guess that seems like a somewhat clearer, more orthogonal arrangement. Zev
On Wed, 31 Mar 2021 19:57:02 -0500, Zev Weiss wrote: > This provides a simpler, more direct alternative to the deprecated > aspeed,sirq-polarity-sense property for indicating the polarity of > the Aspeed VUART's SIRQ line. > > Signed-off-by: Zev Weiss <zev@bewilderbeest.net> > --- > Documentation/devicetree/bindings/serial/8250.yaml | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/serial/8250.yaml:16:30: [warning] too few spaces after comma (commas) ./Documentation/devicetree/bindings/serial/8250.yaml:17:30: [warning] too few spaces after comma (commas) dtschema/dtc warnings/errors: See https://patchwork.ozlabs.org/patch/1460791 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml index 491b9297432d..e79bb6ab9d2c 100644 --- a/Documentation/devicetree/bindings/serial/8250.yaml +++ b/Documentation/devicetree/bindings/serial/8250.yaml @@ -12,8 +12,9 @@ maintainers: allOf: - $ref: /schemas/serial.yaml# - if: - required: - - aspeed,sirq-polarity-sense + anyOf: + - required: [ aspeed,sirq-active-high ] + - required: [ aspeed,sirq-polarity-sense ] then: properties: compatible: @@ -190,6 +191,12 @@ properties: applicable to aspeed,ast2500-vuart. deprecated: true + aspeed,sirq-active-high: + type: boolean + description: | + Set to indicate that the SIRQ polarity is active-high (default + is active-low). Only applicable to aspeed,ast2500-vuart. + required: - reg - interrupts @@ -228,7 +235,7 @@ examples: interrupts = <8>; clocks = <&syscon ASPEED_CLK_APB>; no-loopback-test; - aspeed,sirq-polarity-sense = <&syscon 0x70 25>; + aspeed,sirq-active-high; }; ...
This provides a simpler, more direct alternative to the deprecated aspeed,sirq-polarity-sense property for indicating the polarity of the Aspeed VUART's SIRQ line. Signed-off-by: Zev Weiss <zev@bewilderbeest.net> --- Documentation/devicetree/bindings/serial/8250.yaml | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)