diff mbox series

[v2,2/3] dt-bindings: fpga: Add binding doc for versal fpga manager

Message ID 20210211060532.23662-3-nava.manne@xilinx.com
State Changes Requested, archived
Headers show
Series Add Bitstream configuration support for Versal | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema fail build log

Commit Message

Nava kishore Manne Feb. 11, 2021, 6:05 a.m. UTC 
From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>

This patch adds binding doc for versal fpga manager driver.

Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
---
Changes for v2:
                -Fixed file format and syntax issues.

 .../bindings/fpga/xlnx,versal-fpga.yaml       | 33 +++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml

Comments

Rob Herring (Arm) Feb. 11, 2021, 2:56 p.m. UTC | #1 
On Thu, 11 Feb 2021 11:35:31 +0530, Nava kishore Manne wrote:
> From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
> 
> This patch adds binding doc for versal fpga manager driver.
> 
> Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
> ---
> Changes for v2:
>                 -Fixed file format and syntax issues.
> 
>  .../bindings/fpga/xlnx,versal-fpga.yaml       | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:12:14: [warning] too many spaces after colon (colons)
./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:20:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

See https://patchwork.ozlabs.org/patch/1439305

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Nava kishore Manne Feb. 12, 2021, 6:13 a.m. UTC | #2 
Hi Rob,

Please find my response inline.

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Thursday, February 11, 2021 8:26 PM
> To: Nava kishore Manne <navam@xilinx.com>
> Cc: linux-arm-kernel@lists.infradead.org; mdf@kernel.org; linux-
> fpga@vger.kernel.org; git <git@xilinx.com>; Appana Durga Kedareswara Rao
> <appanad@xilinx.com>; devicetree@vger.kernel.org; robh+dt@kernel.org;
> chinnikishore369@gmail.com; linux-kernel@vger.kernel.org;
> trix@redhat.com; Michal Simek <michals@xilinx.com>
> Subject: Re: [PATCH v2 2/3] dt-bindings: fpga: Add binding doc for versal fpga
> manager
> 
> On Thu, 11 Feb 2021 11:35:31 +0530, Nava kishore Manne wrote:
> > From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
> >
> > This patch adds binding doc for versal fpga manager driver.
> >
> > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > Signed-off-by: Appana Durga Kedareswara rao
> > <appana.durga.rao@xilinx.com>
> > ---
> > Changes for v2:
> >                 -Fixed file format and syntax issues.
> >
> >  .../bindings/fpga/xlnx,versal-fpga.yaml       | 33 +++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> >
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:12:14:
> [warning] too many spaces after colon (colons)
> ./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:20:9:
> [warning] wrong indentation: expected 10 but found 8 (indentation)
> 
> dtschema/dtc warnings/errors:
> 
> See https://patchwork.ozlabs.org/patch/1439305
> 
> This check can fail if there are any dependencies. The base for a patch series
> is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.

Initially, I couldn't see any issue when I run.
After installing yamllint and with upgraded dt-schema, I am able to reproduce the above pointed issues.
Is there any prerequisite(Other than yamllint) I need to follow to run dt-schema?

Regards,
Navakishore.
Rob Herring (Arm) Feb. 17, 2021, 9:06 p.m. UTC | #3 
On Fri, Feb 12, 2021 at 06:13:33AM +0000, Nava kishore Manne wrote:
> Hi Rob,
> 
> Please find my response inline.
> 
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: Thursday, February 11, 2021 8:26 PM
> > To: Nava kishore Manne <navam@xilinx.com>
> > Cc: linux-arm-kernel@lists.infradead.org; mdf@kernel.org; linux-
> > fpga@vger.kernel.org; git <git@xilinx.com>; Appana Durga Kedareswara Rao
> > <appanad@xilinx.com>; devicetree@vger.kernel.org; robh+dt@kernel.org;
> > chinnikishore369@gmail.com; linux-kernel@vger.kernel.org;
> > trix@redhat.com; Michal Simek <michals@xilinx.com>
> > Subject: Re: [PATCH v2 2/3] dt-bindings: fpga: Add binding doc for versal fpga
> > manager
> > 
> > On Thu, 11 Feb 2021 11:35:31 +0530, Nava kishore Manne wrote:
> > > From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
> > >
> > > This patch adds binding doc for versal fpga manager driver.
> > >
> > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > > Signed-off-by: Appana Durga Kedareswara rao
> > > <appana.durga.rao@xilinx.com>
> > > ---
> > > Changes for v2:
> > >                 -Fixed file format and syntax issues.
> > >
> > >  .../bindings/fpga/xlnx,versal-fpga.yaml       | 33 +++++++++++++++++++
> > >  1 file changed, 33 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> > >
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > ./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:12:14:
> > [warning] too many spaces after colon (colons)
> > ./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:20:9:
> > [warning] wrong indentation: expected 10 but found 8 (indentation)
> > 
> > dtschema/dtc warnings/errors:
> > 
> > See https://patchwork.ozlabs.org/patch/1439305
> > 
> > This check can fail if there are any dependencies. The base for a patch series
> > is generally the most recent rc1.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above error(s),
> > then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit.
> 
> Initially, I couldn't see any issue when I run.
> After installing yamllint and with upgraded dt-schema, I am able to reproduce the above pointed issues.
> Is there any prerequisite(Other than yamllint) I need to follow to run dt-schema?

No, just keeping dtschema up to date.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
new file mode 100644
index 000000000000..65d6877b913e
--- /dev/null
+++ b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
@@ -0,0 +1,33 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/fpga/xlnx,versal-fpga.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Xilinx Versal FPGA driver.
+
+maintainers:
+  - Nava kishore Manne <nava.manne@xilinx.com>
+
+description:  |
+  Device Tree Versal FPGA bindings for the Versal SoC, controlled
+  using firmware interface.
+
+properties:
+  compatible:
+    items:
+      - enum:
+        - xlnx,versal-fpga
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    versal_fpga: fpga {
+         compatible = "xlnx,versal-fpga";
+    };
+
+...