| Message ID | 20210130022124.65083-62-mgross@linux.intel.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 118 lines checked |
| robh/dt-meta-schema | fail | build log |
On Fri, 29 Jan 2021 18:21:16 -0800, mgross@linux.intel.com wrote: > From: "C, Udhayakumar" <udhayakumar.c@intel.com> > > Add device tree bindings for local host thermal sensors > Intel Edge.AI Computer Vision platforms. > > The tsens module enables reading of on chip sensors present > in the Intel Bay series SoC. In the tsens module various junction > temperature and SoC temperature are reported using thermal subsystem > and i2c subsystem. > > Temperature data reported using thermal subsystem will be used for > various cooling agents such as DVFS, fan control and shutdown the > system in case of critical temperature. > > Temperature data reported using i2c subsytem will be used by > platform manageability software running in remote host. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Acked-by: mark gross <mgross@linux.intel.com> > Signed-off-by: C Udhayakumar <udhayakumar.c@intel.com> > Signed-off-by: Mark Gross <mgross@linux.intel.com> > --- > .../bindings/misc/intel,intel-tsens.yaml | 118 ++++++++++++++++++ > 1 file changed, 118 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/intel,intel-tsens.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/intel,intel-tsens.example.dt.yaml: example-0: tsens@20260000:reg:0: [0, 539361280, 0, 256] is too long From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml See https://patchwork.ozlabs.org/patch/1433609 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
> On Fri, 29 Jan 2021 18:21:16 -0800, mgross@linux.intel.com wrote: > > From: "C, Udhayakumar" <udhayakumar.c@intel.com> > > > > Add device tree bindings for local host thermal sensors Intel Edge.AI > > Computer Vision platforms. > > > > The tsens module enables reading of on chip sensors present in the > > Intel Bay series SoC. In the tsens module various junction temperature > > and SoC temperature are reported using thermal subsystem and i2c > > subsystem. > > > > Temperature data reported using thermal subsystem will be used for > > various cooling agents such as DVFS, fan control and shutdown the > > system in case of critical temperature. > > > > Temperature data reported using i2c subsytem will be used by platform > > manageability software running in remote host. > > > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: devicetree@vger.kernel.org > > Acked-by: mark gross <mgross@linux.intel.com> > > Signed-off-by: C Udhayakumar <udhayakumar.c@intel.com> > > Signed-off-by: Mark Gross <mgross@linux.intel.com> > > --- > > .../bindings/misc/intel,intel-tsens.yaml | 118 ++++++++++++++++++ > > 1 file changed, 118 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/misc/intel,intel-tsens.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/misc/intel,intel- > tsens.example.dt.yaml: example-0: tsens@20260000:reg:0: [0, 539361280, 0, > 256] is too long > From schema: /usr/local/lib/python3.8/dist- > packages/dtschema/schemas/reg.yaml > > See https://patchwork.ozlabs.org/patch/1433609 > This lint warning is due to missing address-cells and size-cells fields. make dt_binding_check dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/misc/intel,intel-tsens.yaml CHKDT Documentation/devicetree/bindings/misc/intel,intel-tsens.yaml DTC Documentation/devicetree/bindings/misc/intel,intel-tsens.example.dt.yaml CHECK Documentation/devicetree/bindings/misc/intel,intel-tsens.example.dt.yaml Will update the fix in next patch version. --- Thanks, Udhay > This check can fail if there are any dependencies. The base for a patch series > is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above error(s), > then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/misc/intel,intel-tsens.yaml b/Documentation/devicetree/bindings/misc/intel,intel-tsens.yaml new file mode 100644 index 000000000000..2418355d9c47 --- /dev/null +++ b/Documentation/devicetree/bindings/misc/intel,intel-tsens.yaml @@ -0,0 +1,118 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/misc/intel,intel-tsens.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Intel Temperature sensors in Bay series + +maintainers: + - Udhayakumar C <udhayakumar.c@intel.com> + +description: | + The tsens driver enables reading of onchip sensors present + in the Intel Bay SoC. + Each subnode of the tsens represents sensors available + on the soc. + +select: false + +properties: + compatible: + items: + - const: intel,intel-tsens + + plat_name: + contains: + enum: + - intel,keembay_thermal + + reg: + minItems: 1 + maxItems: 2 + + clocks: + items: + - description: thermal sensor clock + + clk-rate: + additionalItems: false + items: + - description: thermal sensor clock freq + + sensor_name: + type: object + description: + Details to configure sensor trip points and its types. + + properties: + passive_delay: + minItems: 1 + maxItems: 1 + description: number of milliseconds to wait between polls when + performing passive cooling + + polling_delay: + minItems: 1 + maxItems: 1 + description: number of milliseconds to wait between polls when checking + whether trip points have been crossed (0 for interrupt + driven systems) + + trip_temp: + minItems: 1 + description: temperature for trip points + + trip_type: + minItems: 1 + description: trip type list for trip points + + required: + - passive_delay + - polling_delay + - trip_temp + - trip_type + +required: + - compatible + +additionalProperties: false + +examples: + - | + tsens: tsens@20260000 { + compatible = "intel,intel-tsens"; + status = "disabled"; + plat_name = "intel,keembay_thermal"; + reg = <0x0 0x20260000 0x0 0x100>; + clocks = <&scmi_clk>; + clk-rate = <1250000>; + + mss { + passive_delay = <1000>; + polling_delay = <2000>; + trip_temp = <40000 80000 1000000>; + trip_type = "passive", "passive", "critical"; + }; + + css { + passive_delay = <1000>; + polling_delay = <2000>; + trip_temp = <40000 80000 1000000>; + trip_type = "passive", "passive", "critical"; + }; + + nce { + passive_delay = <1000>; + polling_delay = <2000>; + trip_temp = <40000 80000 1000000>; + trip_type = "passive", "passive", "critical"; + }; + + soc { + passive_delay = <1000>; + polling_delay = <2000>; + trip_temp = <40000 80000 1000000>; + trip_type = "passive", "passive", "critical"; + }; + };