| Message ID | 1596024483-21482-11-git-send-email-abel.vesa@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add BLK_CTRL support for i.MX8MP | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 55 lines checked |
| robh/dt-meta-schema | fail | build log |
Quoting Abel Vesa (2020-07-29 05:07:56) > diff --git a/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml b/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml > new file mode 100644 > index 00000000..036d3d3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/fsl,imx-blk-ctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# [...] > + > +examples: > + - | > + audio-blk-ctrl: blk-ctrl@30e20000 { clock-controller@30e20000 { > + compatible = "fsl,imx8mp-blk-ctrl", "syscon"; > + reg = <0x30e20000 0x10000>; > + power-domains = <&audiomix_pd>; > + > + #clock-cells = <1>; > + #reset-cells = <1>; > + };
On 20-07-29 12:49:41, Stephen Boyd wrote: > Quoting Abel Vesa (2020-07-29 05:07:56) > > diff --git a/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml b/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml > > new file mode 100644 > > index 00000000..036d3d3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml > > @@ -0,0 +1,55 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only) > > +%YAML 1.2 > > +--- > > +$id: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fclock%2Ffsl%2Cimx-blk-ctrl.yaml%23&data=02%7C01%7Cabel.vesa%40nxp.com%7C30d7fec624c44b4f85e108d833f88a5e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637316489861505079&sdata=63jhxp1rw%2BMYPlc%2BhwSjOwBvN%2Fikf5PXUKGjEXD5agM%3D&reserved=0 > > +$schema: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=02%7C01%7Cabel.vesa%40nxp.com%7C30d7fec624c44b4f85e108d833f88a5e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637316489861505079&sdata=9%2FLcFRkMHXx1%2FHsEfFyhNmI73hDC2GUu2s%2BE9EQTUSE%3D&reserved=0 > [...] > > + > > +examples: > > + - | > > + audio-blk-ctrl: blk-ctrl@30e20000 { > > clock-controller@30e20000 { Will change in the new version. > > > + compatible = "fsl,imx8mp-blk-ctrl", "syscon"; > > + reg = <0x30e20000 0x10000>; > > + power-domains = <&audiomix_pd>; > > + > > + #clock-cells = <1>; > > + #reset-cells = <1>; > > + };
On Wed, 29 Jul 2020 15:07:56 +0300, Abel Vesa wrote: > Document the i.MX BLK_CTRL with its devicetree properties. > > Signed-off-by: Abel Vesa <abel.vesa@nxp.com> > --- > .../bindings/clock/fsl,imx-blk-ctrl.yaml | 55 ++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml > My bot found errors running 'make dt_binding_check' on your patch: Error: Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.example.dts:19.23-24 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:315: recipe for target 'Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.example.dt.yaml' failed make[1]: *** [Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... Makefile:1347: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1338304 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml b/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml new file mode 100644 index 00000000..036d3d3 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0-only) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/fsl,imx-blk-ctrl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP i.MX BLK_CTRL + +description: | + i.MX BLK_CTRL is a conglomerate of different GPRs that are + dedicated to a specific subsystem. Because it usually contains + clocks amongst other things, it needs access to the i.MX clocks + API. All the other functionalities it provides can work just fine + from the clock subsystem tree. + +maintainers: + - Abel Vesa <abel.vesa@nxp.com> + +properties: + reg: + maxItems: 1 + + compatible: + items: + - const: fsl,imx8mp-blk-ctrl + - const: syscon + + power-domains: + maxItems: 1 + + '#clock-cells': + const: 1 + + '#reset-cells': + const: 1 + +required: + - compatible + - reg + - power-domains + - '#clock-cells' + - '#reset-cells' + +additionalProperties: false + +examples: + - | + audio-blk-ctrl: blk-ctrl@30e20000 { + compatible = "fsl,imx8mp-blk-ctrl", "syscon"; + reg = <0x30e20000 0x10000>; + power-domains = <&audiomix_pd>; + + #clock-cells = <1>; + #reset-cells = <1>; + };
Document the i.MX BLK_CTRL with its devicetree properties. Signed-off-by: Abel Vesa <abel.vesa@nxp.com> --- .../bindings/clock/fsl,imx-blk-ctrl.yaml | 55 ++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml