| Message ID | 1592559720-8482-2-git-send-email-neal.liu@mediatek.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2,1/2] dt-bindings: devapc: add bindings for devapc-mt6873 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, 19 Jun 2020 17:41:59 +0800, Neal Liu wrote: > Add bindings for MT6873 devapc. > > Signed-off-by: Neal Liu <neal.liu@mediatek.com> > --- > .../soc/mediatek/devapc/devapc-mt6873.yaml | 61 ++++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.yaml > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.example.dt.yaml: example-0: devapc@10207000:reg:0: [0, 270561280, 0, 4096] is too long /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.example.dt.yaml: example-0: devapc@10207000:reg:1: [0, 271007744, 0, 4096] is too long /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.example.dt.yaml: example-0: devapc@10207000:reg:2: [0, 271011840, 0, 4096] is too long /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.example.dt.yaml: example-0: devapc@10207000:reg:3: [0, 285343744, 0, 4096] is too long /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.example.dt.yaml: example-0: devapc@10207000:reg:4: [0, 270589952, 0, 4096] is too long See https://patchwork.ozlabs.org/patch/1312741 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
On Mon, 2020-06-29 at 15:56 -0600, Rob Herring wrote: > On Fri, 19 Jun 2020 17:41:59 +0800, Neal Liu wrote: > > Add bindings for MT6873 devapc. > > > > Signed-off-by: Neal Liu <neal.liu@mediatek.com> > > --- > > .../soc/mediatek/devapc/devapc-mt6873.yaml | 61 ++++++++++++++++++++ > > 1 file changed, 61 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.example.dt.yaml: example-0: devapc@10207000:reg:0: [0, 270561280, 0, 4096] is too long > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.example.dt.yaml: example-0: devapc@10207000:reg:1: [0, 271007744, 0, 4096] is too long > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.example.dt.yaml: example-0: devapc@10207000:reg:2: [0, 271011840, 0, 4096] is too long > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.example.dt.yaml: example-0: devapc@10207000:reg:3: [0, 285343744, 0, 4096] is too long > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.example.dt.yaml: example-0: devapc@10207000:reg:4: [0, 270589952, 0, 4096] is too long > > > See https://patchwork.ozlabs.org/patch/1312741 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. > I just pull the latest dt-schema from github, and it's still successful. Is there any other clue for this difference? $ PATH=~/virt_test/python36/bin:$PATH ARCH=arm64 make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.yaml CHKDT Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.yaml DTC Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.example.dt.yaml CHECK Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.example.dt.yaml
diff --git a/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.yaml b/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.yaml new file mode 100644 index 0000000..1deb7f6 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# # Copyright 2020 MediaTek Inc. +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/mediatek/devapc/devapc-mt6873.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: MediaTek MT6873 Device Access Permission Control driver + +description: | + MediaTek MT6873 bus frabric provides TrustZone security support and data + protection to prevent slaves from being accessed by unexpected masters. + The security violations are logged and sent to the processor for further + analysis and countermeasures. + +maintainers: + - Neal Liu <neal.liu@mediatek.com> + +properties: + compatible: + enum: + - mediatek,mt6873-devapc + + reg: + description: The base address of devapc register bank + maxItems: 5 + + interrupts: + description: A single interrupt specifier + maxItems: 1 + + clocks: + description: Contains module clock source and clock names + maxItems: 1 + + clock-names: + description: Names of the clocks list in clocks property + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/mt8183-clk.h> + devapc: devapc@10207000 { + compatible = "mediatek,mt6873-devapc"; + reg = <0 0x10207000 0 0x1000>, + <0 0x10274000 0 0x1000>, + <0 0x10275000 0 0x1000>, + <0 0x11020000 0 0x1000>, + <0 0x1020e000 0 0x1000>; + interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&infracfg CLK_INFRA_DEVICE_APC>; + clock-names = "devapc-infra-clock"; + };
Add bindings for MT6873 devapc. Signed-off-by: Neal Liu <neal.liu@mediatek.com> --- .../soc/mediatek/devapc/devapc-mt6873.yaml | 61 ++++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/mediatek/devapc/devapc-mt6873.yaml