| Message ID | 20200501175118.26226-3-dmurphy@ti.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | BQ25150/155 Batter charger | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, 1 May 2020 12:51:17 -0500, Dan Murphy wrote: > From: Ricardo Rivera-Matos <r-rivera-matos@ti.com> > > Description: > The BQ2515X family of devices are highly integrated battery management > ICs that integrate the most common functions for wearbale devices > namely a charger, an output voltage rail, ADC for battery and system > monitoring, and a push-button controller. > > Datasheets: > http://www.ti.com/lit/ds/symlink/bq25150.pdf > http://www.ti.com/lit/ds/symlink/bq25155.pdf > > CC: Rob Herring <robh@kernel.org> > Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com> > --- > .../bindings/power/supply/bq2515x.yaml | 99 +++++++++++++++++++ > 1 file changed, 99 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/bq2515x.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/power/supply/bq2515x.yaml: while scanning a block scalar in "<unicode string>", line 81, column 5 found a tab character where an indentation space is expected in "<unicode string>", line 96, column 1 Documentation/devicetree/bindings/Makefile:11: recipe for target 'Documentation/devicetree/bindings/power/supply/bq2515x.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/power/supply/bq2515x.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/supply/bq2515x.yaml: ignoring, error parsing file warning: no schema found in file: Documentation/devicetree/bindings/power/supply/bq2515x.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/supply/bq2515x.yaml: ignoring, error parsing file warning: no schema found in file: Documentation/devicetree/bindings/power/supply/bq2515x.yaml Makefile:1300: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1281414 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
Hi, On Fri, May 01, 2020 at 12:51:17PM -0500, Dan Murphy wrote: > From: Ricardo Rivera-Matos <r-rivera-matos@ti.com> > > Description: > The BQ2515X family of devices are highly integrated battery management > ICs that integrate the most common functions for wearbale devices > namely a charger, an output voltage rail, ADC for battery and system > monitoring, and a push-button controller. > > Datasheets: > http://www.ti.com/lit/ds/symlink/bq25150.pdf > http://www.ti.com/lit/ds/symlink/bq25155.pdf > > CC: Rob Herring <robh@kernel.org> > Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com> > --- > .../bindings/power/supply/bq2515x.yaml | 99 +++++++++++++++++++ > 1 file changed, 99 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/bq2515x.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/bq2515x.yaml b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml > new file mode 100644 > index 000000000000..673caf67a993 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml > @@ -0,0 +1,99 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (C) 2020 Texas Instruments Incorporated > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/power/supply/bq2515x.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: TI bq2515x 500-mA Linear charger family > + > +maintainers: > + - Dan Murphy <dmurphy@ti.com> > + > +description: | > + The BQ2515x family is a highly integrated battery charge management IC that > + integrates the most common functions for wearable devices, namely a charger, > + an output voltage rail, ADC for battery and system monitoring, and > + push-button controller. > + > + Specifications about the charger can be found at: > + http://www.ti.com/lit/ds/symlink/bq25150.pdf > + http://www.ti.com/lit/ds/symlink/bq25155.pdf > + > +properties: > + compatible: > + enum: > + - ti,bq25150 > + - ti,bq25155 > + > + reg: > + maxItems: 1 > + > + ac_detect-gpios: > + description: | > + GPIO used for connecting the bq2515x device PG (AC Detect) > + pin. This pin should be used if possible as this is the > + recommended way to obtain the charger's input PG state. > + If this pin is not specified a software-based approach for PG > + detection is used. No _ in DT properties, please use ac-detect-gpios as I wrote in PATCHv4. > + reset-gpios: > + description: | > + GPIO used for hardware reset. > + > + low-power-gpios: > + description: | > + GPIO used for low power mode of IC. > + > + charge-enable-gpios: > + description: | > + GPIO used to turn on and off charging. > + > + constant-charge-current-max-microamp: > + description: | > + Maximum charging current in micro Amps. > + minimum: 50000 > + maximum: 600000 > + > + precharge-current-max-microamp: > + description: | > + Maximum precharging current in micro Amps. > + minimum: 1250 > + maximum: 77500 > + > + input-current-limit-microamp: > + description: | > + Maximum input current in micro Amps. > + minimum: 50000 > + maximum: 500000 > + > + constant-charge-voltage-max-microvolt: > + description: | > + Maximum charging voltage in micro volts. > + minimum: 3600000 > + maximum: 4600000 The following properties describe battery properties and should go into a simple-battery node, which is referenced by the charger. Then you get the properties in the driver via power_supply_get_battery_info(): constant-charge-current-max-microamp constant-charge-voltage-max-microvolt precharge-current-max-microamp The binding for simple-battery can be found here: Documentation/devicetree/bindings/power/supply/battery.txt (still needs to be converted to YAML) > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + charger@6b { > + compatible = "ti,bq25150"; > + reg = <0x6b>; > + > + ac_detect-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>; > + low-power-gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>; > + charge-enable-gpios = <&gpio0 13 GPIO_ACTIVE_LOW>; > + constant-charge-current-max-microamp = <300000>; > + constant-charge-voltage-max-microvolt = <4200000>; > + precharge-current-max-microamp = <2500>; > + input-current-limit-microamp = <100000>; bogus indention > + }; > + }; -- Sebastian
diff --git a/Documentation/devicetree/bindings/power/supply/bq2515x.yaml b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml new file mode 100644 index 000000000000..673caf67a993 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml @@ -0,0 +1,99 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright (C) 2020 Texas Instruments Incorporated +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/power/supply/bq2515x.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: TI bq2515x 500-mA Linear charger family + +maintainers: + - Dan Murphy <dmurphy@ti.com> + +description: | + The BQ2515x family is a highly integrated battery charge management IC that + integrates the most common functions for wearable devices, namely a charger, + an output voltage rail, ADC for battery and system monitoring, and + push-button controller. + + Specifications about the charger can be found at: + http://www.ti.com/lit/ds/symlink/bq25150.pdf + http://www.ti.com/lit/ds/symlink/bq25155.pdf + +properties: + compatible: + enum: + - ti,bq25150 + - ti,bq25155 + + reg: + maxItems: 1 + + ac_detect-gpios: + description: | + GPIO used for connecting the bq2515x device PG (AC Detect) + pin. This pin should be used if possible as this is the + recommended way to obtain the charger's input PG state. + If this pin is not specified a software-based approach for PG + detection is used. + + reset-gpios: + description: | + GPIO used for hardware reset. + + low-power-gpios: + description: | + GPIO used for low power mode of IC. + + charge-enable-gpios: + description: | + GPIO used to turn on and off charging. + + constant-charge-current-max-microamp: + description: | + Maximum charging current in micro Amps. + minimum: 50000 + maximum: 600000 + + precharge-current-max-microamp: + description: | + Maximum precharging current in micro Amps. + minimum: 1250 + maximum: 77500 + + input-current-limit-microamp: + description: | + Maximum input current in micro Amps. + minimum: 50000 + maximum: 500000 + + constant-charge-voltage-max-microvolt: + description: | + Maximum charging voltage in micro volts. + minimum: 3600000 + maximum: 4600000 + +required: + - compatible + - reg + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + charger@6b { + compatible = "ti,bq25150"; + reg = <0x6b>; + + ac_detect-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>; + low-power-gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>; + charge-enable-gpios = <&gpio0 13 GPIO_ACTIVE_LOW>; + constant-charge-current-max-microamp = <300000>; + constant-charge-voltage-max-microvolt = <4200000>; + precharge-current-max-microamp = <2500>; + input-current-limit-microamp = <100000>; + }; + };