| Message ID | 1585678079-5999-2-git-send-email-weijie.gao@mediatek.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Wed, 1 Apr 2020 02:07:59 +0800, Weijie Gao wrote: > This patch adds documentation for MediaTek MT7621 NAND flash controller > driver. > > Signed-off-by: Weijie Gao <weijie.gao@mediatek.com> > --- > .../bindings/mtd/mediatek,mt7621-nfc.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/mediatek,mt7621-nfc.yaml > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/mediatek,mt7621-nfc.example.dt.yaml: nand@1e003000: reg: [[503328768, 2048, 503330816, 2048]] is too short See https://patchwork.ozlabs.org/patch/1264888 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/mtd/mediatek,mt7621-nfc.yaml b/Documentation/devicetree/bindings/mtd/mediatek,mt7621-nfc.yaml new file mode 100644 index 000000000000..1ca0c5e95e4c --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/mediatek,mt7621-nfc.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mtd/mediatek,mt7621-nfc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek MT7621 SoC NAND Flash Controller (NFC) DT binding + +maintainers: + - Weijie Gao <weijie.gao@mediatek.com> + +description: | + This driver uses a single node to describe both NAND Flash controller + interface (NFI) and ECC engine for MT7621 SoC. + MT7621 supports only one chip select. + +properties: + "#address-cells": false + "#size-cells": false + + compatible: + enum: + - mediatek,mt7621-nfc + + reg: + items: + - description: Register base of NFI core + - description: Register base of ECC engine + + reg-names: + items: + - const: nfi + - const: ecc + + clocks: + items: + - description: Source clock for NFI core, fixed 125MHz + + clock-names: + items: + - const: nfi_clk + +required: + - compatible + - reg + - reg-names + - clocks + - clock-names + +examples: + - | + nficlock: nficlock { + #clock-cells = <0>; + compatible = "fixed-clock"; + + clock-frequency = <125000000>; + }; + + nand@1e003000 { + compatible = "mediatek,mt7621-nfc"; + + reg = <0x1e003000 0x800 + 0x1e003800 0x800>; + reg-names = "nfi", "ecc"; + + clocks = <&nficlock>; + clock-names = "nfi_clk"; + };
This patch adds documentation for MediaTek MT7621 NAND flash controller driver. Signed-off-by: Weijie Gao <weijie.gao@mediatek.com> --- .../bindings/mtd/mediatek,mt7621-nfc.yaml | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/mediatek,mt7621-nfc.yaml