| Message ID | 20200313223227.2914645-6-blp@ovn.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | gateway documentation improvements | expand |
On Fri, Mar 13, 2020 at 3:33 PM Ben Pfaff <blp@ovn.org> wrote: > > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > ovn-architecture.7.xml | 14 +++++++------- > ovn-nb.xml | 6 +++--- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml > index 450b40ab7a8b..810937ea92cb 100644 > --- a/ovn-architecture.7.xml > +++ b/ovn-architecture.7.xml > @@ -1499,10 +1499,11 @@ > the VM or container to the outside world should be processed > completely on that VM's or container's hypervisor, eventually > traversing a localnet port instance on that hypervisor to the > - physical network. Whenever possible, packets from the outside > - world to a VM or container should be directed through the physical > - network directly to the VM's or container's hypervisor, where the > - packet will enter the integration bridge through a localnet port. > + physical network or a connection to a different OVN deployment. > + Whenever possible, packets from the outside world to a VM or > + container should be directed through the physical network directly > + to the VM's or container's hypervisor, where the packet will enter > + the integration bridge through a localnet port. > </p> > For interconnection, tunnels are used between GWs instead of localnet ports, so "traversing a localnet port" and "through a localnet port" described above are still not accurate. > <p> > @@ -1788,9 +1789,8 @@ > </p> > > <p> > - If the logical router doesn't have a distributed gateway port connecting > - to the localnet logical switch which provides external connectivity, > - then this option is ignored by <code>OVN</code>. > + OVN ignores this option if the logical router doesn't have a distributed > + gateway port that provides external connectivity. > </p> I think we shouldn't change the text here. The "reside-on-redirect-chassis" option is set to a logical router port instead of a router, and it does require a localnet-connected switch connected to this logical router port. The use case is for "Centralized routing for localnet VLAN tagged logical switches connected to a logical router", so it makes sense to require localnet connection. > > <p> > diff --git a/ovn-nb.xml b/ovn-nb.xml > index e113a9fe3f6a..2b0b045ab574 100644 > --- a/ovn-nb.xml > +++ b/ovn-nb.xml > @@ -2038,9 +2038,9 @@ > <p> > If any of these are set, this logical router port represents a > distributed gateway port that connects this router to a > - logical switch with a <code>localnet</code> port. There may > - be at most one such logical router port on each logical > - router. > + logical switch with a <code>localnet</code> port or a > + connection to another OVN deployment. There may be at most > + one such logical router port on each logical router. > </p> > > <p> > -- > 2.24.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Mar 13, 2020 at 05:13:02PM -0700, Han Zhou wrote: > On Fri, Mar 13, 2020 at 3:33 PM Ben Pfaff <blp@ovn.org> wrote: > > > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > ovn-architecture.7.xml | 14 +++++++------- > > ovn-nb.xml | 6 +++--- > > 2 files changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml > > index 450b40ab7a8b..810937ea92cb 100644 > > --- a/ovn-architecture.7.xml > > +++ b/ovn-architecture.7.xml > > @@ -1499,10 +1499,11 @@ > > the VM or container to the outside world should be processed > > completely on that VM's or container's hypervisor, eventually > > traversing a localnet port instance on that hypervisor to the > > - physical network. Whenever possible, packets from the outside > > - world to a VM or container should be directed through the physical > > - network directly to the VM's or container's hypervisor, where the > > - packet will enter the integration bridge through a localnet port. > > + physical network or a connection to a different OVN deployment. > > + Whenever possible, packets from the outside world to a VM or > > + container should be directed through the physical network directly > > + to the VM's or container's hypervisor, where the packet will enter > > + the integration bridge through a localnet port. > > </p> > > > For interconnection, tunnels are used between GWs instead of localnet > ports, so "traversing a localnet port" and "through a localnet port" > described above are still not accurate. Thanks. This is what I put into v2: The primary design goal of distributed gateway ports is to allow as much traffic as possible to be handled locally on the hypervisor where a VM or container resides. Whenever possible, packets from the VM or container to the outside world should be processed completely on that VM's or container's hypervisor, eventually traversing a localnet port instance or a tunnel to the physical network or a different OVN deployment. Whenever possible, packets from the outside world to a VM or container should be directed through the physical network directly to the VM's or container's hypervisor. > > <p> > > @@ -1788,9 +1789,8 @@ > > </p> > > > > <p> > > - If the logical router doesn't have a distributed gateway port > connecting > > - to the localnet logical switch which provides external connectivity, > > - then this option is ignored by <code>OVN</code>. > > + OVN ignores this option if the logical router doesn't have a > distributed > > + gateway port that provides external connectivity. > > </p> > > I think we shouldn't change the text here. The "reside-on-redirect-chassis" > option is set to a logical router port instead of a router, and it does > require a localnet-connected switch connected to this logical router port. > The use case is for "Centralized routing for localnet VLAN tagged logical > switches connected to a logical router", so it makes sense to require > localnet connection. OK. I dropped this change. I'll send v2 soon.
diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index 450b40ab7a8b..810937ea92cb 100644 --- a/ovn-architecture.7.xml +++ b/ovn-architecture.7.xml @@ -1499,10 +1499,11 @@ the VM or container to the outside world should be processed completely on that VM's or container's hypervisor, eventually traversing a localnet port instance on that hypervisor to the - physical network. Whenever possible, packets from the outside - world to a VM or container should be directed through the physical - network directly to the VM's or container's hypervisor, where the - packet will enter the integration bridge through a localnet port. + physical network or a connection to a different OVN deployment. + Whenever possible, packets from the outside world to a VM or + container should be directed through the physical network directly + to the VM's or container's hypervisor, where the packet will enter + the integration bridge through a localnet port. </p> <p> @@ -1788,9 +1789,8 @@ </p> <p> - If the logical router doesn't have a distributed gateway port connecting - to the localnet logical switch which provides external connectivity, - then this option is ignored by <code>OVN</code>. + OVN ignores this option if the logical router doesn't have a distributed + gateway port that provides external connectivity. </p> <p> diff --git a/ovn-nb.xml b/ovn-nb.xml index e113a9fe3f6a..2b0b045ab574 100644 --- a/ovn-nb.xml +++ b/ovn-nb.xml @@ -2038,9 +2038,9 @@ <p> If any of these are set, this logical router port represents a distributed gateway port that connects this router to a - logical switch with a <code>localnet</code> port. There may - be at most one such logical router port on each logical - router. + logical switch with a <code>localnet</code> port or a + connection to another OVN deployment. There may be at most + one such logical router port on each logical router. </p> <p>
Signed-off-by: Ben Pfaff <blp@ovn.org> --- ovn-architecture.7.xml | 14 +++++++------- ovn-nb.xml | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-)