diff mbox series

[2/4] dts: imx: Add fixed-link property to HSC and DDC (imx53) devices

Message ID 20200226113703.10526-3-lukma@denx.de
State Accepted
Commit 4a45f4046b57f29d6c25652c683378c338cf2084
Delegated to: Stefano Babic
Headers show
Series imx: Fixes for i.MX53 based HSC|DDC boards | expand

Commit Message

Lukasz Majewski Feb. 26, 2020, 11:37 a.m. UTC
Those two boards are supposed to be run with a single u-boot binary.
There are notable differences though - HSC uses DSA switch (which
phy_id == 0x0) and DCC (DP83848C).

After the commit 3bf135b6c367
("drivers: net: phy: Ignore PHY ID 0 during PHY probing") the PHY devices
with phy_id == 0 are not created in U-Boot anymore. This caused regression
on HSC.

To fix this problem - the fec's 'fixed-link' node has been introduced and
the phy_id is not assessed anymore. This approach works on both boards.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---

 arch/arm/dts/imx53-kp-u-boot.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Stefano Babic April 19, 2020, 9:09 a.m. UTC | #1
> Those two boards are supposed to be run with a single u-boot binary.
> There are notable differences though - HSC uses DSA switch (which
> phy_id == 0x0) and DCC (DP83848C).
> After the commit 3bf135b6c367
> ("drivers: net: phy: Ignore PHY ID 0 during PHY probing") the PHY devices
> with phy_id == 0 are not created in U-Boot anymore. This caused regression
> on HSC.
> To fix this problem - the fec's 'fixed-link' node has been introduced and
> the phy_id is not assessed anymore. This approach works on both boards.
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/arch/arm/dts/imx53-kp-u-boot.dtsi b/arch/arm/dts/imx53-kp-u-boot.dtsi
index acab9b3657..a112db9d1a 100644
--- a/arch/arm/dts/imx53-kp-u-boot.dtsi
+++ b/arch/arm/dts/imx53-kp-u-boot.dtsi
@@ -5,6 +5,13 @@ 
  * SPDX-License-Identifier:     GPL-2.0+ or X11
  */
 
+&fec {
+	fixed-link { /* RMII fixed link for both HSC|DDC */
+		speed = <100>;
+		full-duplex;
+	};
+};
+
 &pmic {
 	u-boot,i2c-transaction-bytes = <3>;
 };