doc: Chromebook Coral: Fix typo for "Top of CAR region"
diff mbox series

Message ID 20200221112009.524406-1-wolfgang.wallner@br-automation.com
State Accepted
Delegated to: Bin Meng
Headers show
Series
  • doc: Chromebook Coral: Fix typo for "Top of CAR region"
Related show

Commit Message

Wolfgang Wallner Feb. 21, 2020, 11:20 a.m. UTC
The value for "Top of CAR region" should be fefc0000, not
fefc000. This matches the Kconfig default values, as
SYS_CAR_ADDR and SYS_CAR_SIZE are 0xfef00000 and 0xc0000
respectively.

Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>

---

 doc/board/google/chromebook_coral.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bin Meng Feb. 25, 2020, 1:17 p.m. UTC | #1
On Fri, Feb 21, 2020 at 7:20 PM Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> The value for "Top of CAR region" should be fefc0000, not
> fefc000. This matches the Kconfig default values, as
> SYS_CAR_ADDR and SYS_CAR_SIZE are 0xfef00000 and 0xc0000
> respectively.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
>
> ---
>
>  doc/board/google/chromebook_coral.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Bin Meng Feb. 28, 2020, 8:04 a.m. UTC | #2
On Tue, Feb 25, 2020 at 9:17 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Fri, Feb 21, 2020 at 7:20 PM Wolfgang Wallner
> <wolfgang.wallner@br-automation.com> wrote:
> >
> > The value for "Top of CAR region" should be fefc0000, not
> > fefc000. This matches the Kconfig default values, as
> > SYS_CAR_ADDR and SYS_CAR_SIZE are 0xfef00000 and 0xc0000
> > respectively.
> >
> > Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> >
> > ---
> >
> >  doc/board/google/chromebook_coral.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!

Patch
diff mbox series

diff --git a/doc/board/google/chromebook_coral.rst b/doc/board/google/chromebook_coral.rst
index d10e0c4954..40bd9397d4 100644
--- a/doc/board/google/chromebook_coral.rst
+++ b/doc/board/google/chromebook_coral.rst
@@ -179,7 +179,7 @@  Partial memory map
     ffffffff       Top of ROM (and last byte of 32-bit address space)
     ffff8000       TPL loaded here (from IFWI)
     ff000000       Bottom of ROM
-     fefc000       Top of CAR region
+    fefc0000       Top of CAR region
     fef96000       Stack for FSP-M
     fef40000 59000 FSP-M
     fef11000       SPL loaded here