diff mbox series

gpiolib: use gpiochip_get_desc() where applicable

Message ID 20200219094702.6463-1-brgl@bgdev.pl
State New
Headers show
Series gpiolib: use gpiochip_get_desc() where applicable | expand

Commit Message

Bartosz Golaszewski Feb. 19, 2020, 9:47 a.m. UTC 
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Whenever retrieving a descriptor from a gpiochip: use the provided
helper which checks for errors.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 drivers/gpio/gpiolib.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Linus Walleij Feb. 21, 2020, 2:51 p.m. UTC | #1 
On Wed, Feb 19, 2020 at 10:47 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Whenever retrieving a descriptor from a gpiochip: use the provided
> helper which checks for errors.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Patch applied!

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 4d0106ceeba7..5c761a738065 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -2953,7 +2953,9 @@  const char *gpiochip_is_requested(struct gpio_chip *chip, unsigned offset)
 	if (offset >= chip->ngpio)
 		return NULL;
 
-	desc = &chip->gpiodev->descs[offset];
+	desc = gpiochip_get_desc(chip, offset);
+	if (IS_ERR(desc))
+		return NULL;
 
 	if (test_bit(FLAG_REQUESTED, &desc->flags) == 0)
 		return NULL;