| Message ID | 20200204095059.7315-1-giulio.benetti@benettiengineering.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v2] package/libnspr: remove BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT | expand |
On Tue, 4 Feb 2020 10:50:59 +0100 Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > Since all architectures supported by Buildroot are supported by libnspr > BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT makes no sense anymore, so let's remove > it all around. > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Arnout and I both agreed that we want to keep this blind option, so I'm not sure I understand why you're sending this patch. Did we miss something? Thanks, Thomas
On 04/02/2020 11:04, Thomas Petazzoni wrote: > On Tue, 4 Feb 2020 10:50:59 +0100 > Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > >> Since all architectures supported by Buildroot are supported by libnspr >> BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT makes no sense anymore, so let's remove >> it all around. >> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > > Arnout and I both agreed that we want to keep this blind option, so I'm > not sure I understand why you're sending this patch. Did we miss something? Actually, Giulio replied that in the other thread (but it should be part of the commit log here, maybe): adding architecture support is trivial (just a matter of defining the right sizes), so we should never need to re-add this option. Just fix libnspr. Regards, Arnout
Hi Arnout, All, On 2/4/20 3:36 PM, Arnout Vandecappelle wrote: > > > On 04/02/2020 11:04, Thomas Petazzoni wrote: >> On Tue, 4 Feb 2020 10:50:59 +0100 >> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: >> >>> Since all architectures supported by Buildroot are supported by libnspr >>> BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT makes no sense anymore, so let's remove >>> it all around. >>> >>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> >> Arnout and I both agreed that we want to keep this blind option, so I'm >> not sure I understand why you're sending this patch. Did we miss something? > > Actually, Giulio replied that in the other thread (but it should be part of the > commit log here, maybe): adding architecture support is trivial (just a matter > of defining the right sizes), so we should never need to re-add this option. > Just fix libnspr. Oops, again, sorry, I was on Mobile. Anyway yes, to add support for new architecture in nspr it's enough add 2 entries as you can see on my previous upstreamed patch: https://hg.mozilla.org/projects/nspr/rev/ef5d8d008815e8367e684149f88b43f5ae53e1d7 But IMHO if a new architecture is added to Buildroot nspr will fail to build for it, but fix it(*at the moment at least*) is trivial. Thank you Arnout for pointing. Best regards
On Tue, 4 Feb 2020 15:36:01 +0100 Arnout Vandecappelle <arnout@mind.be> wrote: > > Arnout and I both agreed that we want to keep this blind option, so I'm > > not sure I understand why you're sending this patch. Did we miss something? > > Actually, Giulio replied that in the other thread (but it should be part of the > commit log here, maybe): adding architecture support is trivial (just a matter > of defining the right sizes), so we should never need to re-add this option. > Just fix libnspr. Yes, it is true that the architecture support in libnspr is trivial. Though we lived for quite some time without it for some CPU architectures :-) Thomas
diff --git a/package/ecryptfs-utils/Config.in b/package/ecryptfs-utils/Config.in index 0c39f48d08..08210f05eb 100644 --- a/package/ecryptfs-utils/Config.in +++ b/package/ecryptfs-utils/Config.in @@ -3,7 +3,6 @@ config BR2_PACKAGE_ECRYPTFS_UTILS depends on BR2_USE_WCHAR # gettext depends on BR2_USE_MMU # keyutils depends on BR2_TOOLCHAIN_HAS_THREADS # libnss -> libnspr - depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnss -> libnspr depends on !BR2_MIPS_NABI32 # libnss depends on !BR2_STATIC_LIBS # libnss, keyutils select BR2_PACKAGE_KEYUTILS @@ -29,7 +28,6 @@ config BR2_PACKAGE_ECRYPTFS_UTILS http://ecryptfs.org comment "ecryptfs-utils needs a toolchain w/ threads, wchar, dynamic library" - depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \ BR2_STATIC_LIBS diff --git a/package/libnspr/Config.in b/package/libnspr/Config.in index c1be7151e0..de8dd0a06b 100644 --- a/package/libnspr/Config.in +++ b/package/libnspr/Config.in @@ -1,8 +1,3 @@ -config BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT - def_bool y - -if BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT - config BR2_PACKAGE_LIBNSPR bool "libnspr" depends on BR2_TOOLCHAIN_HAS_THREADS @@ -17,5 +12,3 @@ config BR2_PACKAGE_LIBNSPR comment "libnspr needs a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS - -endif diff --git a/package/libnss/Config.in b/package/libnss/Config.in index 2dd0197236..feedcd4029 100644 --- a/package/libnss/Config.in +++ b/package/libnss/Config.in @@ -1,7 +1,6 @@ config BR2_PACKAGE_LIBNSS bool "libnss" depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr - depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr depends on !BR2_STATIC_LIBS select BR2_PACKAGE_LIBNSPR select BR2_PACKAGE_SQLITE @@ -28,5 +27,4 @@ config BR2_PACKAGE_LIBNSS_ARCH endif comment "libnss needs a toolchain w/ threads, dynamic library" - depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS diff --git a/package/spidermonkey/Config.in b/package/spidermonkey/Config.in index 5f12110626..150b941c94 100644 --- a/package/spidermonkey/Config.in +++ b/package/spidermonkey/Config.in @@ -8,7 +8,6 @@ config BR2_PACKAGE_SPIDERMONKEY_ARCH_SUPPORTS default y if BR2_riscv default y if BR2_sh4 || BR2_sh4a default y if BR2_sparc || BR2_sparc64 - depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr config BR2_PACKAGE_SPIDERMONKEY_JIT_ARCH_SUPPORTS bool
Since all architectures supported by Buildroot are supported by libnspr BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT makes no sense anymore, so let's remove it all around. Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- V1->V2: rebased on top of master --- package/ecryptfs-utils/Config.in | 2 -- package/libnspr/Config.in | 7 ------- package/libnss/Config.in | 2 -- package/spidermonkey/Config.in | 1 - 4 files changed, 12 deletions(-)