[1/4] rockchip: rk3288: Enable pre console buffer
diff mbox series

Message ID 20200123141222.486-1-jagan@amarulasolutions.com
State Accepted
Delegated to: Kever Yang
Headers show
Series
  • [1/4] rockchip: rk3288: Enable pre console buffer
Related show

Commit Message

Jagan Teki Jan. 23, 2020, 2:12 p.m. UTC
Enable pre console buffer for rk3288 platform.

This would help to capture the console messages prior to
the console being initialised. Enabling this would help
to capture all the console messages on video output source
like HDMI. So we can find the full console messages of
U-Boot proper on HDMI display when enabled it for RK3288
platform boards.

Buffer address used for pre console is 0x0f000000 which is
ram base plus 240MiB. right now the Allwinner SoC is using
similar computation.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 arch/arm/mach-rockchip/Kconfig | 1 +
 common/Kconfig                 | 1 +
 2 files changed, 2 insertions(+)

Comments

Kever Yang Jan. 30, 2020, 3:55 a.m. UTC | #1
On 2020/1/23 下午10:12, Jagan Teki wrote:
> Enable pre console buffer for rk3288 platform.
>
> This would help to capture the console messages prior to
> the console being initialised. Enabling this would help
> to capture all the console messages on video output source
> like HDMI. So we can find the full console messages of
> U-Boot proper on HDMI display when enabled it for RK3288
> platform boards.
>
> Buffer address used for pre console is 0x0f000000 which is
> ram base plus 240MiB. right now the Allwinner SoC is using
> similar computation.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/mach-rockchip/Kconfig | 1 +
>   common/Kconfig                 | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index 2f260a5c5f..ed7514ab75 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -102,6 +102,7 @@ config ROCKCHIP_RK3288
>   	select SUPPORT_SPL
>   	select SPL
>   	select SUPPORT_TPL
> +	imply PRE_CONSOLE_BUFFER
>   	imply ROCKCHIP_COMMON_BOARD
>   	imply SPL_ROCKCHIP_COMMON_BOARD
>   	imply TPL_CLK
> diff --git a/common/Kconfig b/common/Kconfig
> index a7c5ba278a..21d0244050 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -567,6 +567,7 @@ config PRE_CON_BUF_ADDR
>   	depends on PRE_CONSOLE_BUFFER
>   	default 0x2f000000 if ARCH_SUNXI && MACH_SUN9I
>   	default 0x4f000000 if ARCH_SUNXI && !MACH_SUN9I
> +	default 0x0f000000 if ROCKCHIP_RK3288
>   	help
>   	  This sets the start address of the pre-console buffer. This must
>   	  be in available memory and is accessed before relocation and

Patch
diff mbox series

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 2f260a5c5f..ed7514ab75 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -102,6 +102,7 @@  config ROCKCHIP_RK3288
 	select SUPPORT_SPL
 	select SPL
 	select SUPPORT_TPL
+	imply PRE_CONSOLE_BUFFER
 	imply ROCKCHIP_COMMON_BOARD
 	imply SPL_ROCKCHIP_COMMON_BOARD
 	imply TPL_CLK
diff --git a/common/Kconfig b/common/Kconfig
index a7c5ba278a..21d0244050 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -567,6 +567,7 @@  config PRE_CON_BUF_ADDR
 	depends on PRE_CONSOLE_BUFFER
 	default 0x2f000000 if ARCH_SUNXI && MACH_SUN9I
 	default 0x4f000000 if ARCH_SUNXI && !MACH_SUN9I
+	default 0x0f000000 if ROCKCHIP_RK3288
 	help
 	  This sets the start address of the pre-console buffer. This must
 	  be in available memory and is accessed before relocation and